From 6f32afb99e6c6f7cbd20fbaab02a740603efcf86 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Wed, 22 Oct 2025 17:04:37 +0530 Subject: [PATCH 01/16] Align dropdown to button --- .../messaging/createMessageDropdown.svelte | 2 +- .../messaging/providers/createProviderDropdown.svelte | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/messaging/createMessageDropdown.svelte b/src/routes/(console)/project-[region]-[project]/messaging/createMessageDropdown.svelte index e91f92669d..49e018a16f 100644 --- a/src/routes/(console)/project-[region]-[project]/messaging/createMessageDropdown.svelte +++ b/src/routes/(console)/project-[region]-[project]/messaging/createMessageDropdown.svelte @@ -7,7 +7,7 @@ import { page } from '$app/state'; - + - - {/if} - + + + + + + {#if $canWriteProviders} + + + + {/if} + + {#if data.providers.total} diff --git a/src/routes/(console)/project-[region]-[project]/messaging/topics/+page.svelte b/src/routes/(console)/project-[region]-[project]/messaging/topics/+page.svelte index 47a3056034..325fc4054d 100644 --- a/src/routes/(console)/project-[region]-[project]/messaging/topics/+page.svelte +++ b/src/routes/(console)/project-[region]-[project]/messaging/topics/+page.svelte @@ -4,17 +4,18 @@ import { Empty, EmptySearch, PaginationWithLimit, EmptyFilter } from '$lib/components'; import Create from './create.svelte'; import { goto } from '$app/navigation'; - import { Container, ResponsiveContainerHeader } from '$lib/layout'; + import { Container } from '$lib/layout'; import { base } from '$app/paths'; import type { Models } from '@appwrite.io/console'; import type { PageData } from './$types'; import { showCreate } from './store'; - import { hasPageQueries } from '$lib/components/filters'; + import { hasPageQueries, Filters } from '$lib/components/filters'; + import { SearchQuery, ViewSelector } from '$lib/components'; import Table from './table.svelte'; import type { Column } from '$lib/helpers/types'; import { writable } from 'svelte/store'; import { canWriteTopics } from '$lib/stores/roles'; - import { Icon } from '@appwrite.io/pink-svelte'; + import { Icon, Layout } from '@appwrite.io/pink-svelte'; import { View } from '$lib/helpers/load'; import { IconPlus } from '@appwrite.io/pink-icons-svelte'; import { Click, trackEvent } from '$lib/actions/analytics'; @@ -65,26 +66,24 @@ - - {#if $canWriteTopics} - - {/if} - + + + + + + {#if $canWriteTopics} + + {/if} + + {#if data.topics.total}
From 6fc0360684c057538165f7d4c80362a891afe54d Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Wed, 22 Oct 2025 18:29:53 +0530 Subject: [PATCH 04/16] use resposnsiveheader and isCustomFiltersOnoly prop --- .../layout/responsiveContainerHeader.svelte | 15 +++++- .../messaging/providers/+page.svelte | 40 ++++++++-------- .../messaging/topics/+page.svelte | 46 ++++++++++--------- 3 files changed, 58 insertions(+), 43 deletions(-) diff --git a/src/lib/layout/responsiveContainerHeader.svelte b/src/lib/layout/responsiveContainerHeader.svelte index 29eed0f56c..98e10321b8 100644 --- a/src/lib/layout/responsiveContainerHeader.svelte +++ b/src/lib/layout/responsiveContainerHeader.svelte @@ -1,6 +1,11 @@ - - - - - - {#if $canWriteProviders} - - - - {/if} - - + + {#if $canWriteProviders} + + + + {/if} + {#if data.providers.total}
diff --git a/src/routes/(console)/project-[region]-[project]/messaging/topics/+page.svelte b/src/routes/(console)/project-[region]-[project]/messaging/topics/+page.svelte index 325fc4054d..30682ca9d7 100644 --- a/src/routes/(console)/project-[region]-[project]/messaging/topics/+page.svelte +++ b/src/routes/(console)/project-[region]-[project]/messaging/topics/+page.svelte @@ -4,18 +4,17 @@ import { Empty, EmptySearch, PaginationWithLimit, EmptyFilter } from '$lib/components'; import Create from './create.svelte'; import { goto } from '$app/navigation'; - import { Container } from '$lib/layout'; + import { Container, ResponsiveContainerHeader } from '$lib/layout'; import { base } from '$app/paths'; import type { Models } from '@appwrite.io/console'; import type { PageData } from './$types'; import { showCreate } from './store'; - import { hasPageQueries, Filters } from '$lib/components/filters'; - import { SearchQuery, ViewSelector } from '$lib/components'; + import { hasPageQueries } from '$lib/components/filters'; import Table from './table.svelte'; import type { Column } from '$lib/helpers/types'; import { writable } from 'svelte/store'; import { canWriteTopics } from '$lib/stores/roles'; - import { Icon, Layout } from '@appwrite.io/pink-svelte'; + import { Icon } from '@appwrite.io/pink-svelte'; import { View } from '$lib/helpers/load'; import { IconPlus } from '@appwrite.io/pink-icons-svelte'; import { Click, trackEvent } from '$lib/actions/analytics'; @@ -66,24 +65,27 @@ - - - - - - {#if $canWriteTopics} - - {/if} - - + + {#if $canWriteTopics} + + {/if} + {#if data.topics.total}
From 1f262bed6c464bd5a675a44ce2f2c13ca6603bf7 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Wed, 22 Oct 2025 18:39:03 +0530 Subject: [PATCH 05/16] Image should open in a new tab --- src/lib/components/imagePreview.svelte | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lib/components/imagePreview.svelte b/src/lib/components/imagePreview.svelte index 1c5f3cfdf8..e377b07390 100644 --- a/src/lib/components/imagePreview.svelte +++ b/src/lib/components/imagePreview.svelte @@ -12,6 +12,8 @@ style="inline-size: 100%; block-size: 100%;" target="_blank" rel="noopener noreferrer" + on:click|stopPropagation + on:mousedown|stopPropagation aria-label="open file in new window">
From 8abd63c14f55fa19656c89b986d7fcf2e6e45695 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Wed, 22 Oct 2025 18:44:00 +0530 Subject: [PATCH 06/16] We have a lot of inconsistencies in the terms we use for subscribers, the idea in console is to use CRUD so let's just go with --- .../messaging/topics/topic-[topic]/+page.svelte | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte b/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte index 50e8468c64..ac7f37e07f 100644 --- a/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte +++ b/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte @@ -72,7 +72,7 @@ await Promise.all(promises); addNotification({ type: 'success', - message: `${targetIds.length} subscriber${targetIds.length !== 1 ? 's' : ''} have been added` + message: `${targetIds.length} subscriber${targetIds.length !== 1 ? 's' : ''} created` }); trackEvent(Submit.MessagingTopicSubscriberAdd); await invalidate(Dependencies.MESSAGING_TOPIC_SUBSCRIBERS); @@ -99,7 +99,7 @@ }} event="create_subscriber"> - Add subscriber + Create subscriber @@ -141,7 +141,7 @@ on:update={addTargets}> - Add subscribers to this topic by selecting the targets for directing messages.{' '} + Create subscribers for this topic by selecting the targets for directing messages.{' '} From c70de3915bfc8825a67648a417e0c169187f552e Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Wed, 22 Oct 2025 18:57:08 +0530 Subject: [PATCH 07/16] Removed the custom empty state --- .../messaging/topics/topic-[topic]/+page.svelte | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte b/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte index ac7f37e07f..6c525dff3d 100644 --- a/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte +++ b/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte @@ -115,14 +115,11 @@ {:else if $hasPageQueries} {:else if data.search} - -
- Sorry, we couldn't find '{data.search}' -

There are no subscribers that match your search.

-
+ {:else} From 5ab33113364d2bde26186168984605897c6dba7a Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Wed, 22 Oct 2025 18:59:18 +0530 Subject: [PATCH 08/16] Placeholder should be Search by type or ID --- .../messaging/topics/topic-[topic]/+page.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte b/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte index 6c525dff3d..565ecd9f95 100644 --- a/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte +++ b/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte @@ -88,7 +88,7 @@ - + From 64687a75b912b9bf267515e99fe59cf88a77f46e Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Wed, 22 Oct 2025 19:02:43 +0530 Subject: [PATCH 09/16] Description in the wrong place (should be below the modal title) --- .../messaging/userTargetsModal.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/(console)/project-[region]-[project]/messaging/userTargetsModal.svelte b/src/routes/(console)/project-[region]-[project]/messaging/userTargetsModal.svelte index 179c869d9a..e02be6c80f 100644 --- a/src/routes/(console)/project-[region]-[project]/messaging/userTargetsModal.svelte +++ b/src/routes/(console)/project-[region]-[project]/messaging/userTargetsModal.svelte @@ -139,7 +139,7 @@ - + Date: Wed, 22 Oct 2025 19:07:17 +0530 Subject: [PATCH 10/16] space between helper text 6px --- src/lib/elements/forms/helper.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elements/forms/helper.svelte b/src/lib/elements/forms/helper.svelte index 99e580c8d8..76ac8cab5c 100644 --- a/src/lib/elements/forms/helper.svelte +++ b/src/lib/elements/forms/helper.svelte @@ -5,7 +5,7 @@

Date: Wed, 22 Oct 2025 19:10:17 +0530 Subject: [PATCH 11/16] use lowercase push --- .../project-[region]-[project]/messaging/topicsModal.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/(console)/project-[region]-[project]/messaging/topicsModal.svelte b/src/routes/(console)/project-[region]-[project]/messaging/topicsModal.svelte index 38e2d5f28c..67f0022f93 100644 --- a/src/routes/(console)/project-[region]-[project]/messaging/topicsModal.svelte +++ b/src/routes/(console)/project-[region]-[project]/messaging/topicsModal.svelte @@ -185,7 +185,7 @@