Skip to content

Commit 1c1ad10

Browse files
appleboyappleboy
authored
ci(action): remove script stop functionality from project (#350)
- Remove the `stop script if command error` step from GitHub workflows - Remove the `script_stop` option from the README and its translations - Remove the `script_stop` input from `action.yml` Signed-off-by: appleboy <appleboy.tw@gmail.com>
1 parent 4853185 commit 1c1ad10

File tree

6 files changed

+0
-137
lines changed

6 files changed

+0
-137
lines changed

‎.github/workflows/main.yml‎

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -123,22 +123,6 @@ jobs:
123123
port: 2222
124124
script: whoami
125125

126-
- name: stop script if command error
127-
uses: ./
128-
continue-on-error: true
129-
with:
130-
host: ${{ env.REMOTE_HOST }}
131-
username: linuxserver.io
132-
password: password
133-
key: password
134-
port: 2222
135-
script_stop: true
136-
sync: true
137-
debug: true
138-
script: |
139-
mkdir abc/def
140-
ls -al
141-
142126
support-key-passphrase:
143127
runs-on: ubuntu-latest
144128
steps:
@@ -215,7 +199,6 @@ jobs:
215199
key: ${{ env.PRIVATE_KEY }}
216200
port: 2222
217201
passphrase: 1234
218-
script_stop: true
219202
script: |
220203
ls \
221204
-lah
@@ -292,7 +275,6 @@ jobs:
292275
username: linuxserver.io
293276
key: ${{ env.PRIVATE_KEY }}
294277
passphrase: 1234
295-
script_stop: true
296278
script: |
297279
whoami
298280
@@ -488,7 +470,6 @@ jobs:
488470
username: linuxserver.io
489471
key: ${{ env.PRIVATE_KEY }}
490472
port: 2222
491-
script_stop: true
492473
request_pty: true
493474
command_timeout: 30s
494475
script: |

‎.github/workflows/stable.yml‎

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -123,22 +123,6 @@ jobs:
123123
port: 2222
124124
script: whoami
125125

126-
- name: stop script if command error
127-
uses: appleboy/ssh-action@v1.2.0
128-
continue-on-error: true
129-
with:
130-
host: ${{ env.REMOTE_HOST }}
131-
username: linuxserver.io
132-
password: password
133-
key: password
134-
port: 2222
135-
script_stop: true
136-
sync: true
137-
debug: true
138-
script: |
139-
mkdir abc/def
140-
ls -al
141-
142126
support-key-passphrase:
143127
runs-on: ubuntu-latest
144128
steps:
@@ -215,7 +199,6 @@ jobs:
215199
key: ${{ env.PRIVATE_KEY }}
216200
port: 2222
217201
passphrase: 1234
218-
script_stop: true
219202
script: |
220203
ls \
221204
-lah
@@ -292,7 +275,6 @@ jobs:
292275
username: linuxserver.io
293276
key: ${{ env.PRIVATE_KEY }}
294277
passphrase: 1234
295-
script_stop: true
296278
script: |
297279
whoami
298280
@@ -478,7 +460,6 @@ jobs:
478460
username: linuxserver.io
479461
key: ${{ env.PRIVATE_KEY }}
480462
port: 2222
481-
script_stop: true
482463
request_pty: true
483464
command_timeout: 30s
484465
script: |

‎README.md‎

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ See [action.yml](./action.yml) for more detailed information.
4444
| proxy_use_insecure_cipher | Include more ciphers with use_insecure_cipher for the proxy | false |
4545
| script | Execute commands | |
4646
| script_file | Execute commands from a file | |
47-
| script_stop | Stop script after first failure | false |
4847
| envs | Pass environment variables to shell script | |
4948
| envs_format | Flexible configuration of environment value transfer | |
5049
| debug | Enable debug mode | false |
@@ -304,37 +303,6 @@ The default value of `port` is `22`.
304303

305304
_Inside `env` object, you need to pass every environment variable as a string, passing `Integer` data type or any other may output unexpected results._
306305

307-
#### Stop script after first failure
308-
309-
> ex: missing `abc` folder
310-
311-
```diff
312-
- name: stop script if command error
313-
uses: appleboy/ssh-action@v1.2.0
314-
with:
315-
host: ${{ secrets.HOST }}
316-
username: ${{ secrets.USERNAME }}
317-
key: ${{ secrets.KEY }}
318-
port: ${{ secrets.PORT }}
319-
+ script_stop: true
320-
script: |
321-
mkdir abc/def
322-
ls -al
323-
```
324-
325-
output:
326-
327-
```sh
328-
======CMD======
329-
mkdir abc/def
330-
ls -al
331-
332-
======END======
333-
2019/11/21 01:16:21 Process exited with status 1
334-
err: mkdir: cannot create directory ‘abc/def’: No such file or directory
335-
##[error]Docker run failed with exit code 1
336-
```
337-
338306
#### How to connect remote server using `ProxyCommand`?
339307

340308
```bash

‎README.zh-cn.md‎

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
| proxy_use_insecure_cipher | 使用不安全的密码算法 | false |
4545
| script | 执行命令 | |
4646
| script_file | 从文件执行命令 | |
47-
| script_stop | 在第一次失败后停止脚本 | false |
4847
| envs | 传递环境变量到 shell 脚本 | |
4948
| envs_format | 环境变量传递的灵活配置 | |
5049
| debug | 启用调试模式 | false |
@@ -285,37 +284,6 @@ ssh-keygen -t ed25519 -a 200 -C ”your_email@example.com“
285284
286285
_在 `env` 对象中，您需要将每个环境变量作为字符串传递，传递 `Integer` 数据类型或任何其他类型可能会产生意外结果。_
287286

288-
#### 在第一次失败后停止脚本
289-
290-
> ex: missing `abc` folder
291-
292-
```diff
293-
- name: stop script if command error
294-
uses: appleboy/ssh-action@v1.2.0
295-
with:
296-
host: ${{ secrets.HOST }}
297-
username: ${{ secrets.USERNAME }}
298-
key: ${{ secrets.KEY }}
299-
port: ${{ secrets.PORT }}
300-
+ script_stop: true
301-
script: |
302-
mkdir abc/def
303-
ls -al
304-
```
305-
306-
画面输出：
307-
308-
```sh
309-
======CMD======
310-
mkdir abc/def
311-
ls -al
312-
313-
======END======
314-
2019/11/21 01:16:21 Process exited with status 1
315-
err: mkdir: cannot create directory ‘abc/def’: No such file or directory
316-
##[error]Docker run failed with exit code 1
317-
```
318-
319287
#### 如何使用 `ProxyCommand` 连接远程服务器？
320288

321289
```bash

‎README.zh-tw.md‎

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
| proxy_use_insecure_cipher | 包含更多不安全的加密算法 | false |
4545
| script | 執行命令 | |
4646
| script_file | 從文件中執行命令 | |
47-
| script_stop | 在第一次失敗後停止腳本 | false |
4847
| envs | 將環境變數傳遞給 shell 腳本 | |
4948
| envs_format | 環境值傳遞的靈活配置 | |
5049
| debug | 啟用調試模式 | false |
@@ -285,37 +284,6 @@ ssh-keygen -t ed25519 -a 200 -C "your_email@example.com"
285284
286285
_在 `env` 對象中，您需要將每個環境變量作為字符串傳遞，傳遞 `Integer` 數據類型或任何其他類型可能會產生意外結果。_
287286

288-
#### 在第一次失敗後停止腳本
289-
290-
> ex: missing `abc` folder
291-
292-
```diff
293-
- name: stop script if command error
294-
uses: appleboy/ssh-action@v1.2.0
295-
with:
296-
host: ${{ secrets.HOST }}
297-
username: ${{ secrets.USERNAME }}
298-
key: ${{ secrets.KEY }}
299-
port: ${{ secrets.PORT }}
300-
+ script_stop: true
301-
script: |
302-
mkdir abc/def
303-
ls -al
304-
```
305-
306-
畫面輸出:
307-
308-
```sh
309-
======CMD======
310-
mkdir abc/def
311-
ls -al
312-
313-
======END======
314-
2019/11/21 01:16:21 Process exited with status 1
315-
err: mkdir: cannot create directory ‘abc/def’: No such file or directory
316-
##[error]Docker run failed with exit code 1
317-
```
318-
319287
#### 如何使用 `ProxyCommand` 連接遠程服務器？
320288

321289
```bash

‎action.yml‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,6 @@ inputs:
6565
description: "Commands to be executed."
6666
script_path:
6767
description: "Path to the file containing commands to be executed."
68-
script_stop:
69-
description: "Stop the script after the first failure."
7068
envs:
7169
description: "Environment variables to be passed to the shell script."
7270
envs_format:
@@ -113,7 +111,6 @@ runs:
113111
INPUT_COMMAND_TIMEOUT: ${{ inputs.command_timeout }}
114112
INPUT_SCRIPT: ${{ inputs.script }}
115113
INPUT_SCRIPT_FILE: ${{ inputs.script_path }}
116-
INPUT_SCRIPT_STOP: ${{ inputs.script_stop }}
117114
INPUT_ENVS: ${{ inputs.envs }}
118115
INPUT_ENVS_FORMAT: ${{ inputs.envs_format }}
119116
INPUT_DEBUG: ${{ inputs.debug }}

0 commit comments

Comments
 (0)