Skip to content

Commit f9b58f2

Browse files
authored
CMake Updater: Output difference in expectations (#3314)
Teach the script to indicate what is different on failure rather than keeping quiet. This helps when the script is failing in CI but not locally. ### Motivation: The script is reporting that there are missing changes in CI on swift-crypto, but I am unable to reproduce them locally. This is to get immediate insight on why the check fails rather than keeping quiet. ### Modifications: Include the diff in the update-cmake-lists script. ### Result: update-cmake-lists script outputs the difference between what is in a PR vs what it expects to see instead of shrugging and leaving it as an exercise to the user.
1 parent a5fea86 commit f9b58f2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/update-cmake-lists.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ done
129129

130130
if [[ "${fail_on_changes}" == true ]]; then
131131
if [ -n "$(git status --untracked-files=no --porcelain)" ]; then
132-
fatal "Changes in the cmake files detected. Please update."
132+
fatal "Changes in the cmake files detected. Please update. -- $(git diff)"
133133
else
134134
log "✅ CMake files are up-to-date."
135135
fi

0 commit comments

Comments
 (0)