Skip to content

Commit b8b1940

Browse files
madrobLukasa
andauthored
Move conditional setup logic from bash to actions (#3313)
Instead of checking for a setup command in bash, we use GitHub Actions to determine if there is anything to run ### Motivation: Slightly cleaner output when looking at logs. ### Modifications: Moved an if statement from bash to yaml. ### Result: The setup commands step will generally be skipped instead of executing a no-op Co-authored-by: Cory Benfield <lukasa@apple.com>
1 parent f9b58f2 commit b8b1940

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

.github/workflows/macos_tests.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -312,10 +312,8 @@ jobs:
312312
persist-credentials: false
313313
submodules: true
314314
- name: Setup command
315-
run: |
316-
if [ -n "${{ matrix.config.setup_command }}" ]; then
317-
bash -c "${{ matrix.config.setup_command }}"
318-
fi
315+
if: ${{ matrix.config.setup_command != '' }}
316+
run: bash -c "${{ matrix.config.setup_command }}"
319317
- name: Swift build
320318
run: |
321319
if [ -n "${{ matrix.config.build_arguments_override }}" ]; then

0 commit comments

Comments
 (0)