Skip to content

perf: Improve webpage load by defering the script loading and add theme color for nice consistent UI 🎨🚤 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: Improve webpage load by defering the script loading and add theme color for nice consistent UI 🎨🚤 #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/supplemental-ui/layouts/landing.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{{> head defaultPageTitle='Pkl'}}
<link rel="stylesheet" href="{{uiRootPath}}/css/atom-one-dark.min.css">
<link rel="stylesheet" href="{{uiRootPath}}/css/landing.css">
<meta name="theme-color" content="#2b471b" />
</head>
<body>
{{> header}}
Expand Down
4 changes: 0 additions & 4 deletions src/supplemental-ui/partials/footer-scripts-landing.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +0,0 @@
<script src="{{uiRootPath}}/js/site.js"></script>
<script src="{{uiRootPath}}/js/site-support.js"></script>
<script async src="{{uiRootPath}}/js/vendor/highlight.js"></script>
<script src="{{uiRootPath}}/js/landing-page-support.js"></script>
5 changes: 5 additions & 0 deletions src/supplemental-ui/partials/head-meta.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,8 @@
<link rel="apple-touch-icon" sizes="180x180" href="{{uiRootPath}}/img/apple-touch-icon.png">
<link rel="icon" type="image/png" sizes="32x32" href="{{uiRootPath}}/img/favicon-32x32.png">
<link rel="icon" type="image/png" sizes="16x16" href="{{uiRootPath}}/img/favicon-16x16.png">

<script defer src="{{uiRootPath}}/js/site.js"></script>
<script defer src="{{uiRootPath}}/js/site-support.js"></script>
<script defer async src="{{uiRootPath}}/js/vendor/highlight.js"></script>
<script defer src="{{uiRootPath}}/js/landing-page-support.js"></script>