Make deprecation.reason non-nullable (#6311)

* Make deprecation.reason non-nullable

* update apolloDump

* fix test fixture

Author: martinbonnin

libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo/ast/internal/definitions.kt

@@ -310,7 +310,7 @@ internal val builtinsDefinitionsStr = """
   directive @include(if: Boolean!) on FIELD | FRAGMENT_SPREAD | INLINE_FRAGMENT
 
   directive @deprecated(
-    reason: String = "No longer supported"
+    reason: String! = "No longer supported"
   ) on FIELD_DEFINITION | ARGUMENT_DEFINITION | INPUT_FIELD_DEFINITION | ENUM_VALUE
 
   directive @defer(

libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo/ast/introspection/introspection_reader.kt

@@ -369,16 +369,11 @@ private class GQLDocumentBuilder(private val introspectionSchema: IntrospectionS
   }
 
   /**
-   * This assumes the case where `deprecationReason == null && isDeprecated` is not valid
-   * which is unclear from reading the spec as the below seems allowed:
+   * This assumes the case where `deprecationReason == null && isDeprecated` is not valid.
    *
-   * ```
-   * type Query {
-   *   foo: Int @deprecated(reason: null)
-   * }
-   * ```
+   * See https://github.com/graphql/graphql-spec/pull/1040
    *
-   * If there are legit use cases for `@deprecated(reason: null)` we should update this function
+   * If a legacy schema contains `@deprecated(reason: null)`, the field appears as non-deprecated.
    */
   fun makeDirectives(deprecationReason: String?): List<GQLDirective> {
     if (deprecationReason == null) {

libraries/apollo-ast/test-fixtures/sdl/type_redefinitions.expected

@@ -190,7 +190,7 @@ directive @skip (if: Boolean!) on FIELD|FRAGMENT_SPREAD|INLINE_FRAGMENT
 
 directive @include (if: Boolean!) on FIELD|FRAGMENT_SPREAD|INLINE_FRAGMENT
 
-directive @deprecated (reason: String = "No longer supported") on FIELD_DEFINITION|ARGUMENT_DEFINITION|INPUT_FIELD_DEFINITION|ENUM_VALUE
+directive @deprecated (reason: String! = "No longer supported") on FIELD_DEFINITION|ARGUMENT_DEFINITION|INPUT_FIELD_DEFINITION|ENUM_VALUE
 
 directive @defer (label: String, if: Boolean! = true) on FRAGMENT_SPREAD|INLINE_FRAGMENT