Merge pull request #115 from apisearch-io/fix/fix-comparision-type-on-ranges

Is not the same assertEquals than assertSame

Author: mmoreram

Query/Range.php

@@ -51,13 +51,13 @@ class Range
     public static function stringToArray(string $string): array
     {
         list($from, $to) = explode(self::SEPARATOR, $string);
-        $from = empty($from)
+        $from = '' === $from
             ? self::MINUS_INFINITE
             : (is_numeric($from)
                 ? (int) $from
                 : $from);
 
-        $to = empty($to)
+        $to = '' === $to
             ? self::INFINITE
             : (is_numeric($to)
                 ? (int) $to

Tests/Query/RangeTest.php

@@ -33,7 +33,7 @@ class RangeTest extends TestCase
      */
     public function testStringToArray(string $string, array $result)
     {
-        $this->assertEquals(
+        $this->assertSame(
             $result,
             Range::stringToArray($string)
         );
@@ -53,6 +53,8 @@ public function dataStringToArray(): array
             ['0..100', [0, 100]],
             ['-100..0', [-100, 0]],
             ['..', [Range::MINUS_INFINITE, Range::INFINITE]],
+            ['0..', [0, Range::INFINITE]],
+            ['..0', [Range::MINUS_INFINITE, 0]],
         ];
     }
 
@@ -66,7 +68,7 @@ public function dataStringToArray(): array
      */
     public function testArrayToString(array $array, string $result)
     {
-        $this->assertEquals(
+        $this->assertSame(
             $result,
             Range::arrayToString($array)
         );
@@ -94,7 +96,7 @@ public function dataArrayToString(): array
      */
     public function testCreateRanges()
     {
-        $this->assertEquals(
+        $this->assertSame(
             [
                 '1..3',
                 '3..5',
@@ -103,7 +105,7 @@ public function testCreateRanges()
             Range::createRanges(1, 7, 2)
         );
 
-        $this->assertEquals(
+        $this->assertSame(
             [
                 '0..2',
                 '2..4',