Added make_response to FlaskView as a class method #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the ability to override Flask's
make_responsefunction by adding a newmake_responseclass method to FlaskView.The motivation is to provide an final and inheritable "decorator-like" function that wraps the view's response.
Decorators are inheritable; however, if a subclass wishes to modify the decorator list, they need to be aware of the parents decorators to do so.
I'm not sure if this function should be an instance function or a class method. I've created it as a class method; however, I'd be willing to change it to an instance method to provide easier and cleaner subclassing.
My personal motivation for this pull request is to replace Flask-RESTful's
MethodViewwithFlaskView.I like the design where the API views return the data directly and the
make_responseprovides the final conversion to the output representation requested.