Merge pull request dynamodb-toolbox#89 from fredericbarthelet/allow-0-in-comparaison-operators

Allow 0 in comparaison operators

Author: jeremydaly

__tests__/expressionBuilder.unit.test.js

@@ -342,4 +342,15 @@ describe('expressionBuilder',() => {
       .toThrow(`A condition is required`)
   })
 
+  it('allows 0 in comparaison expression', () => {
+    expect(() => expressionBuilder({ attr: 'a', lte: 0 },TestTable,'TestEntity'))
+      .not.toThrow(`A condition is required`)
+    expect(() => expressionBuilder({ attr: 'a', lt: 0 },TestTable,'TestEntity'))
+      .not.toThrow(`A condition is required`)
+    expect(() => expressionBuilder({ attr: 'a', gte: 0 },TestTable,'TestEntity'))
+      .not.toThrow(`A condition is required`)
+    expect(() => expressionBuilder({ attr: 'a', gt: 0 },TestTable,'TestEntity'))
+      .not.toThrow(`A condition is required`)
+  })
+
 })

lib/expressionBuilder.js

@@ -130,10 +130,10 @@ const parseClause = (_clause,grp,table) => {
   if (eq !== undefined) { value = eq; f = 'eq'; operator = '=' }
   if (ne !== undefined) { value = value ? conditionError(f) : ne; f = 'ne'; operator = '<>' }
   if (_in) { value = value ? conditionError(f) : _in; f = 'in'; operator = 'IN' }
-  if (lt) { value = value ? conditionError(f) : lt; f = 'lt'; operator = '<' }
-  if (lte) { value = value ? conditionError(f) : lte; f = 'lte'; operator = '<=' }
-  if (gt) { value = value ? conditionError(f) : gt; f = 'gt'; operator = '>' }
-  if (gte) { value = value ? conditionError(f) : gte; f = 'gte';  operator = '>=' }
+  if (lt !== undefined) { value = value ? conditionError(f) : lt; f = 'lt'; operator = '<' }
+  if (lte !== undefined) { value = value ? conditionError(f) : lte; f = 'lte'; operator = '<=' }
+  if (gt !== undefined) { value = value ? conditionError(f) : gt; f = 'gt'; operator = '>' }
+  if (gte !== undefined) { value = value ? conditionError(f) : gte; f = 'gte';  operator = '>=' }
   if (between) { value = value ? conditionError(f) : between; f = 'between'; operator = 'BETWEEN' }
   if (exists !== undefined) { value = value ? conditionError(f) : exists; f = 'exists'; operator = 'EXISTS' }
   if (contains) { value = value ? conditionError(f) : contains; f = 'contains'; operator = 'CONTAINS' }