Remove branch you can't get to

Author: omichowdhury

__tests__/formatItem.unit.test.js

@@ -28,7 +28,10 @@ DefaultTable.entities = new Entity({
     list_alias2: { type: 'list', map: 'list2' },
     test: 'map',
     linked1: ['sk',0, { save: false }],
-    linked2: ['sk',1, { save: false }]
+    linked2: ['sk',1, { save: false }],
+    composite: { type: 'string', alias: 'composite_alias' },
+    linked_alias1: ['composite',0, { save: false, alias: 'linked_alias_one' }],
+    linked_alias2: ['composite',1, { save: false, alias: 'linked_alias_two' }],
   }
 })
 
@@ -83,6 +86,11 @@ describe('formatItem', () => {
     expect(result).toEqual({ linked1: 'test1' })
   })
 
+  it('formats item with linked aliased fields', () => {
+    let result = formatItem(DocumentClient)(DefaultTable.User.schema.attributes,DefaultTable.User.linked,{ composite: 'test1#test2' })  
+    expect(result).toEqual({ composite_alias: 'test1#test2', linked_alias_one: 'test1', linked_alias_two: 'test2' })
+  })
+
   it('passes through attribute not specified in entity', () => {
     let result = formatItem(DocumentClient)(DefaultTable.User.schema.attributes,DefaultTable.User.linked,{ unspecified: 'value' })  
     expect(result).toEqual({ unspecified: 'value' })

lib/formatItem.js

@@ -18,9 +18,8 @@ module.exports = (DocumentClient) => (attributes,linked,item,include=[]) => {
   const validateType = validateTypes(DocumentClient)
 
   return Object.keys(item).reduce((acc,field) => {
-
-    if (linked[field] || attributes[field] && linked[attributes[field]] && linked[attributes[field]].alias) {
-      Object.assign(acc, (linked[field] || linked[attributes[field].alias]).reduce((acc,f,i) => {
+    if (linked[field]) {
+      Object.assign(acc, (linked[field]).reduce((acc,f,i) => {
         if (attributes[f].save || attributes[f].hidden || (include.length > 0 && !include.includes(f))) return acc    
         return Object.assign(acc,{
           [attributes[f].alias || f]: validateType(attributes[f],f,