Handle all decaffeinate suggestions

Author: realityking

lib/parser.js

@@ -1,9 +1,3 @@
-/*
- * decaffeinate suggestions:
- * DS101: Remove unnecessary use of Array.from
- * DS102: Remove unnecessary code created because of implicit returns
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
- */
 const parse = function (trace) {
   let data;
   let dir = function (ident) {
@@ -29,7 +23,7 @@ const parse = function (trace) {
   const asciiHexSets = [];
   let lastDir = '';
 
-  for (const line of Array.from(traceLines)) {
+  for (const line of traceLines) {
     const dirMatch = dirPattern.exec(line);
     if (dirMatch !== null) {
       lastDir = dirMatch[0].trim();
@@ -45,9 +39,9 @@ const parse = function (trace) {
 
   // split lines by spaces and make array of ASCII hex bytes
   const asciiHexBuffer = { request: [], response: [] };
-  for (const set of Array.from(asciiHexSets)) {
+  for (const set of asciiHexSets) {
     data = set[1];
-    for (const byte of Array.from(data.split(' '))) {
+    for (const byte of data.split(' ')) {
       asciiHexBuffer[dir(set[0])].push(byte);
     }
   }
@@ -56,7 +50,7 @@ const parse = function (trace) {
   const asciiIntBuffer = { request: [], response: [] };
   for (dir in asciiHexBuffer) {
     const hexs = asciiHexBuffer[dir];
-    for (const hex of Array.from(hexs)) {
+    for (const hex of hexs) {
       asciiIntBuffer[dir].push(parseInt(`0x${hex}`));
     }
   }
@@ -65,7 +59,7 @@ const parse = function (trace) {
   const stringBuffer = { request: [], response: [] };
   for (dir in asciiIntBuffer) {
     const codes = asciiIntBuffer[dir];
-    for (const code of Array.from(codes)) {
+    for (const code of codes) {
       stringBuffer[dir].push(String.fromCharCode(code));
     }
   }
@@ -83,15 +77,15 @@ const parseToString = function (trace) {
 
   const request = [];
   const requestLines = message.request.split('\r\n');
-  for (var line of Array.from(requestLines)) {
+  for (var line of requestLines) {
     request.push(`> ${line}`);
   }
   output += request.join('\r\n');
   output += '\n';
   output += '\r\n';
   const response = [];
   const responseLines = message.response.split('\r\n');
-  for (line of Array.from(responseLines)) {
+  for (line of responseLines) {
     response.push(`< ${line}`);
   }
   output += response.join('\r\n');
@@ -105,15 +99,15 @@ const parseBackRequestAndResponseFromString = function (string) {
 
   const request = [];
   const stringLines = string.split('\r\n');
-  for (var line of Array.from(stringLines)) {
+  for (var line of stringLines) {
     if (/^> /.test(line)) { request.push(line.replace(/^> /, '')); }
   }
 
   // removing trailing LF
   output.request = request.join('\r\n').replace(/\n$/, '');
 
   const response = [];
-  for (line of Array.from(stringLines)) {
+  for (line of stringLines) {
     if (/^< /.test(line)) { response.push(line.replace(/^< /, '')); }
   }