Skip to content
This repository was archived by the owner on Nov 8, 2024. It is now read-only.

Commit dbd6aaf

Browse files
kylefkylef
authored
Prevent null title for unnamed section in Apiary Blueprint (#342)
Prevent null title for unnamed section in Apiary Blueprint
2 parents 38fdacc + 823e06d commit dbd6aaf

File tree

4 files changed

+142
-1
lines changed

4 files changed

+142
-1
lines changed

‎packages/fury-adapter-apiary-blueprint-parser/CHANGELOG.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# Changelog
22

3+
## Master
4+
5+
### Bug Fixes
6+
7+
- Prevents placing a null title element in a resource group when the section
8+
name is empty.
9+
310
## 3.0.0-beta.9 (2019-07-02)
411

512
### Enhancements

‎packages/fury-adapter-apiary-blueprint-parser/lib/parser.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,9 @@ class Parser {
8686
const { Copy, Category, Resource } = this.namespace.elements;
8787

8888
const group = new Category();
89-
group.title = section.name;
89+
if (section.name) {
90+
group.title = section.name;
91+
}
9092
group.classes.push('resourceGroup');
9193

9294
if (section.description) {

‎packages/fury-adapter-apiary-blueprint-parser/test/fixtures/unnamed-section.json‎

Lines changed: 127 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
1+
{
2+
"element": "parseResult",
3+
"content": [
4+
{
5+
"element": "category",
6+
"meta": {
7+
"classes": {
8+
"element": "array",
9+
"content": [
10+
{
11+
"element": "string",
12+
"content": "api"
13+
}
14+
]
15+
},
16+
"title": {
17+
"element": "string",
18+
"content": "Sample API"
19+
}
20+
},
21+
"content": [
22+
{
23+
"element": "category",
24+
"meta": {
25+
"classes": {
26+
"element": "array",
27+
"content": [
28+
{
29+
"element": "string",
30+
"content": "resourceGroup"
31+
}
32+
]
33+
}
34+
},
35+
"content": [
36+
{
37+
"element": "resource",
38+
"attributes": {
39+
"href": {
40+
"element": "string",
41+
"content": "/message"
42+
}
43+
},
44+
"content": [
45+
{
46+
"element": "transition",
47+
"meta": {
48+
"title": {
49+
"element": "string",
50+
"content": "GET"
51+
}
52+
},
53+
"attributes": {
54+
"href": {
55+
"element": "string",
56+
"content": "/message"
57+
}
58+
},
59+
"content": [
60+
{
61+
"element": "httpTransaction",
62+
"content": [
63+
{
64+
"element": "httpRequest",
65+
"attributes": {
66+
"method": {
67+
"element": "string",
68+
"content": "GET"
69+
}
70+
}
71+
},
72+
{
73+
"element": "httpResponse",
74+
"attributes": {
75+
"statusCode": {
76+
"element": "number",
77+
"content": 200
78+
},
79+
"headers": {
80+
"element": "httpHeaders",
81+
"content": [
82+
{
83+
"element": "member",
84+
"content": {
85+
"key": {
86+
"element": "string",
87+
"content": "Content-Type"
88+
},
89+
"value": {
90+
"element": "string",
91+
"content": "text/plain"
92+
}
93+
}
94+
}
95+
]
96+
}
97+
},
98+
"content": [
99+
{
100+
"element": "asset",
101+
"meta": {
102+
"classes": {
103+
"element": "array",
104+
"content": [
105+
{
106+
"element": "string",
107+
"content": "messageBody"
108+
}
109+
]
110+
}
111+
},
112+
"content": "Hello World!"
113+
}
114+
]
115+
}
116+
]
117+
}
118+
]
119+
}
120+
]
121+
}
122+
]
123+
}
124+
]
125+
}
126+
]
127+
}

‎packages/fury-adapter-apiary-blueprint-parser/test/fixtures/unnamed-section.txt‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
--- Sample API ---
2+
GET /message
3+
< 200
4+
< Content-Type: text/plain
5+
Hello World!

0 commit comments

Comments
 (0)