fix(oas3): redefine path name allowed chars

Author: klokane

packages/fury-adapter-oas3-parser/lib/parser/oas/parseParameterObject.js

@@ -30,12 +30,12 @@ const isSupportedIn = R.anyPass([
 
 const unreservedCharacterRegex = /^[A-z0-9\\.\\_\\~\\-]+$/;
 const reservedHeaderNamesRegex = /Accept|Content-Type|Authorization/i;
+const pathNameAllowedRegex = /^[A-z0-9._]+$/;
 
 const encodeQueryName = name => encodeURIComponent(name)
   .replace(/[!'()*]/g, c => `%${c.charCodeAt(0).toString(16).toUpperCase()}`) //  as sugested by https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent#Description
   .replace(/%25([0-9a-f]{2})/gi, (match, hex) => `%${hex}`); // revert double encoded sequences
 
-
 function nameContainsReservedCharacter(parameter) {
   return !unreservedCharacterRegex.test(parameter.get('name').toValue());
 }
@@ -114,7 +114,13 @@ function parseParameterObject(context, object) {
 
   const hasLocation = R.curry((location, parameter) => parameter.getValue('in') === location);
 
-  const validatePathName = R.when(nameContainsReservedCharacter, createUnsupportedNameError);
+  const validatePathName = R.when(
+    R.pipe(R.invoker(1, 'get')('name'),
+      R.invoker(0, 'toValue'),
+      R.test(pathNameAllowedRegex),
+      R.not),
+    createUnsupportedNameError
+  );
 
   const nameContainsReservedHeaderName = parameter => parameter.get('name')
     .toValue()

packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseParameterObject-test.js

@@ -44,6 +44,17 @@ describe('Parameter Object', () => {
       expect(parseResult).to.contain.error("'Parameter Object' 'name' contains unsupported characters. Only alphanumeric characters are currently supported");
     });
 
+    it('does not allow character `-` in path name', () => {
+      const parameter = new namespace.elements.Object({
+        name: 'not-allowed',
+        in: 'path',
+      });
+
+      const parseResult = parse(context, parameter);
+
+      expect(parseResult).to.contain.error("'Parameter Object' 'name' contains unsupported characters. Only alphanumeric characters are currently supported");
+    });
+
     it('allows name to contain unreserved URI Template characters', () => {
       // as per https://tools.ietf.org/html/rfc6570#section-1.5
       const alpha = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';