fix(oas3): handle internal YAML parser error

Author: kylef

packages/fury-adapter-oas3-parser/lib/parser/parseYAML.js

@@ -111,8 +111,10 @@ function parse(source, context) {
     if (error.problem) {
       const problem = error.problem.replace('\t', '\\t');
       message = `${problem}, ${error.context}`;
-    } else {
+    } else if (error.context) {
       message = error.context;
+    } else {
+      ({ message } = error);
     }
 
     const annotation = new namespace.elements.Annotation(
@@ -121,12 +123,14 @@ function parse(source, context) {
     );
 
     const marker = error.context_mark || error.problem_mark;
-    copySourceMap(
-      marker,
-      marker,
-      annotation,
-      namespace
-    );
+    if (marker) {
+      copySourceMap(
+        marker,
+        marker,
+        annotation,
+        namespace
+      );
+    }
 
     parseResult.push(annotation);
     return parseResult;

packages/fury-adapter-oas3-parser/test/unit/parser/parseYAML-test.js

@@ -31,6 +31,18 @@ describe('#parseYAML', () => {
 
       expect(parseResult).contain.error('YAML Syntax: found character \\t that cannot start any token, while scanning for the next token').with.sourceMap([[14, 0]]);
     });
+
+    it('can handle internal YAML parser error', () => {
+      // Protection against YAML parser bug where source map information isn't available
+      // Particular case: https://github.com/connec/yaml-js/issues/46
+
+      const parseResult = parseYAML("key:\n  key:\n      key: 'x\nkey: 'string'", context);
+
+      expect(parseResult).to.be.instanceof(namespace.elements.ParseResult);
+      expect(parseResult.errors.length).to.equal(1);
+
+      expect(parseResult).contain.error('YAML Syntax: logic failure');
+    });
   });
 
   it('can parse a string into a string element', () => {