fix(oas3): add parent name to 'servers' warning

Author: Marco Friso

packages/fury-adapter-oas3-parser/lib/parser/oas/parseOpenAPIObject.js

@@ -110,7 +110,7 @@ function parseOASObject(context, object) {
 
   const parseMember = R.cond([
     [hasKey('openapi'), parseOpenAPI(context)],
-    [hasKey('servers'), R.compose(parseServersArray(context), getValue)],
+    [hasKey('servers'), R.compose(parseServersArray(context, name), getValue)],
     [hasKey('info'), R.compose(parseInfoObject(context), getValue)],
     [hasKey('components'), R.compose(parseComponentsObject(context), getValue)],
     [hasKey('paths'), R.compose(asArray, parsePathsObject(context), getValue)],

packages/fury-adapter-oas3-parser/lib/parser/oas/parseServersArray.js

@@ -3,8 +3,6 @@ const pipeParseResult = require('../../pipeParseResult');
 const parseArray = require('../parseArray');
 const parseServerObject = require('./parseServerObject');
 
-const name = 'Servers Array';
-
 /**
  * Parse Servers Array
  *
@@ -14,11 +12,11 @@ const name = 'Servers Array';
  *
  * @private
  */
-function parseServersArray(context, element) {
+function parseServersArray(context, name, element) {
   const { namespace } = context;
 
   const parseServers = pipeParseResult(namespace,
-    parseArray(context, name, R.curry(parseServerObject)(context)),
+    parseArray(context, `${name}' 'servers`, R.curry(parseServerObject)(context)),
     array => new namespace.elements.Category(
       array.content, { classes: ['hosts'] }
     ));

packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseServersArray-test.js

@@ -15,21 +15,23 @@ describe('#parseServersArray', () => {
   it('warns when it is not an array', () => {
     const servers = new namespace.elements.Object();
 
-    const parseResult = parse(context, servers);
+    const name = 'parent-name';
+    const parseResult = parse(context, name, servers);
 
     expect(parseResult.length).to.equal(1);
-    expect(parseResult).to.contain.warning("'Servers Array' is not an array");
+    expect(parseResult).to.contain.warning("'parent-name' 'servers' is not an array");
   });
 
   it('parses correctly when there is a single server', () => {
-    const server = new namespace.elements.Array([
+    const servers = new namespace.elements.Array([
       {
         url: 'https://user.server.com/1.0',
         description: 'The production API server',
       },
     ]);
 
-    const parseResult = parse(context, server);
+    const name = 'parent-name';
+    const parseResult = parse(context, name, servers);
 
     expect(parseResult.length).to.equal(1);
 
@@ -45,7 +47,7 @@ describe('#parseServersArray', () => {
   });
 
   it('parses correctly when there are multiple servers', () => {
-    const server = new namespace.elements.Array([
+    const servers = new namespace.elements.Array([
       {
         url: 'https://user.server.com/1.0',
       },
@@ -55,7 +57,8 @@ describe('#parseServersArray', () => {
       },
     ]);
 
-    const parseResult = parse(context, server);
+    const name = 'parent-name';
+    const parseResult = parse(context, name, servers);
 
     expect(parseResult.length).to.equal(1);