fix(core): allow error parse results to be serialized, fixes #315

Author: pksunkara

packages/fury/lib/fury.js

@@ -265,6 +265,11 @@ class Fury {
       return Promise.reject(error);
     }
 
+    if (!api) {
+      // eslint-disable-next-line no-param-reassign
+      api = new this.minim.elements.Category();
+    }
+
     const promise = adapter.serialize({ api, namespace: this.minim, mediaType });
 
     if (done) {

packages/fury/test/serialize-test.js

@@ -4,6 +4,12 @@ const assert = require('./assert');
 
 describe('Serialize', () => {
   describe('using callback', () => {
+    const JSONSerializeAdapter = {
+      name: 'json',
+      mediaTypes: ['application/json'],
+      serialize: ({ api, namespace }) => Promise.resolve(JSON.stringify(namespace.serialiser.serialise(api))),
+    };
+
     it('errors with unknown mediaType', (done) => {
       const fury = new Fury();
       const api = new fury.minim.elements.Category();
@@ -34,11 +40,7 @@ describe('Serialize', () => {
 
     it('can serialize with matching adapter', (done) => {
       const fury = new Fury();
-      fury.use({
-        name: 'json',
-        mediaTypes: ['application/json'],
-        serialize: ({ api, namespace }) => Promise.resolve(JSON.stringify(namespace.serialiser.serialise(api))),
-      });
+      fury.use(JSONSerializeAdapter);
 
       const api = new fury.minim.elements.Category();
 
@@ -48,6 +50,17 @@ describe('Serialize', () => {
         done();
       });
     });
+
+    it('can serialize undefined `api` by creating default category', (done) => {
+      const fury = new Fury();
+      fury.use(JSONSerializeAdapter);
+
+      fury.serialize({ api: undefined, mediaType: 'application/json' }, (error, result) => {
+        expect(error).to.be.null;
+        expect(result).to.equal('{"element":"category"}');
+        done();
+      });
+    });
   });
 
   describe('using async/await', () => {