Don't throw error when media type is invalid (#323)

Don't throw error when media type is invalid

Author: pksunkara

packages/fury-adapter-oas3-parser/CHANGELOG.md

@@ -7,6 +7,11 @@
 - Adds support for example values for text based media types such as
   `text/*` and `application/xml`.
 
+### Bug Fixes
+
+- Prevents the parser from throwing an exception when encountering an invalid
+  media type.
+
 ## 0.9.0 (2019-07-02)
 
 This release brings significant performance improvement to parsing large

packages/fury-adapter-oas3-parser/lib/parser/oas/parseMediaTypeObject.js

@@ -110,7 +110,8 @@ const parseExampleObjectOrRef = parseReference('examples', parseExampleObject);
 
 const isValidMediaType = (mediaType) => {
   try {
-    contentTyper.parse(mediaType.toValue());
+    const { type } = contentTyper.parse(mediaType.toValue());
+    mediaTyper.parse(type);
   } catch (error) {
     return false;
   }

packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseMediaTypeObject-test.js

@@ -21,14 +21,22 @@ describe('Media Type Object', () => {
     expect(parseResult).to.contain.warning("'Media Type Object' is not an object");
   });
 
-  it('provides warning when media type is invalid', () => {
+  it('provides warning when content type is invalid', () => {
     const mediaType = new namespace.elements.Member('foo', {});
 
     const parseResult = parse(context, messageBodyClass, mediaType);
 
     expect(parseResult).to.contain.warning("'Media Type Object' media type 'foo' is invalid");
   });
 
+  it('provides warning when media type is invalid', () => {
+    const mediaType = new namespace.elements.Member('*/*', {});
+
+    const parseResult = parse(context, messageBodyClass, mediaType);
+
+    expect(parseResult).to.contain.warning("'Media Type Object' media type '*/*' is invalid");
+  });
+
   it('permits media type with parameters', () => {
     const mediaType = new namespace.elements.Member('application/json; charset=utf-8', {});