Merge pull request #1883 from alanpoulain/fix/access-control-double-check

[GraphQL] Remove useless double check of access_control in resolvers

Author: meyerbaptiste

src/GraphQl/Resolver/Factory/CollectionResolverFactory.php

@@ -89,13 +89,6 @@ public function __invoke(string $resourceClass = null, string $rootClass = null,
 
             $this->canAccess($this->resourceAccessChecker, $resourceMetadata, $resourceClass, $info, $collection, 'query');
 
-            if (null !== $this->resourceAccessChecker) {
-                $isGranted = $resourceMetadata->getGraphqlAttribute('query', 'access_control', null, true);
-                if (null !== $isGranted && !$this->resourceAccessChecker->isGranted($resourceClass, $isGranted, ['object' => $collection])) {
-                    throw Error::createLocatedError('Access Denied.', $info->fieldNodes, $info->path);
-                }
-            }
-
             if (!$this->paginationEnabled) {
                 $data = [];
                 foreach ($collection as $index => $object) {

src/GraphQl/Resolver/ItemResolver.php

@@ -19,7 +19,6 @@
 use ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface;
 use ApiPlatform\Core\Security\ResourceAccessCheckerInterface;
 use ApiPlatform\Core\Util\ClassInfoTrait;
-use GraphQL\Error\Error;
 use GraphQL\Type\Definition\ResolveInfo;
 use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
 
@@ -71,13 +70,6 @@ public function __invoke($source, $args, $context, ResolveInfo $info)
         $resourceMetadata = $this->resourceMetadataFactory->create($resourceClass);
         $this->canAccess($this->resourceAccessChecker, $resourceMetadata, $resourceClass, $info, $item, 'query');
 
-        if (null !== $this->resourceAccessChecker) {
-            $isGranted = $resourceMetadata->getGraphqlAttribute('query', 'access_control', null, true);
-            if (null !== $isGranted && !$this->resourceAccessChecker->isGranted($resourceClass, $isGranted, ['object' => $item])) {
-                throw Error::createLocatedError('Access Denied.', $info->fieldNodes, $info->path);
-            }
-        }
-
         $normalizationContext = $resourceMetadata->getGraphqlAttribute('query', 'normalization_context', [], true);
 
         return $this->normalizer->normalize($item, ItemNormalizer::FORMAT, $normalizationContext + $baseNormalizationContext);