[GraphQL] Fix identifiers (#1805)

* Remove final from ItemNormalizer (add a PHPDoc final instead)

* Modify GraphQL item normalizer to manage identifiers correctly

* Remove uneeded code in mutation resolver

Author: alanpoulain

src/GraphQl/Resolver/Factory/ItemMutationResolverFactory.php

@@ -85,11 +85,6 @@ public function __invoke(string $resourceClass = null, string $rootClass = null,
             switch ($operationName) {
                 case 'create':
                 case 'update':
-                    unset($args['input']['id']);
-                    if (isset($args['input']['_id'])) {
-                        $args['input']['id'] = $args['input']['_id'];
-                    }
-
                     $context = null === $item ? ['resource_class' => $resourceClass] : ['resource_class' => $resourceClass, 'object_to_populate' => $item];
                     $item = $this->normalizer->denormalize($args['input'], $resourceClass, ItemNormalizer::FORMAT, $context);
                     $this->validate($item, $info, $resourceMetadata, $operationName);

src/GraphQl/Serializer/ItemNormalizer.php

@@ -23,23 +23,32 @@
 
 use ApiPlatform\Core\Metadata\Property\PropertyMetadata;
 use ApiPlatform\Core\Serializer\AbstractItemNormalizer;
+use ApiPlatform\Core\Serializer\ItemNormalizer as BaseItemNormalizer;
 
 /**
  * GraphQL normalizer.
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
  */
-final class ItemNormalizer extends AbstractItemNormalizer
+final class ItemNormalizer extends BaseItemNormalizer
 {
     const FORMAT = 'graphql';
     const ITEM_KEY = '#item';
 
+    /**
+     * {@inheritdoc}
+     */
+    public function supportsNormalization($data, $format = null)
+    {
+        return self::FORMAT === $format && parent::supportsNormalization($data, $format);
+    }
+
     /**
      * {@inheritdoc}
      */
     public function normalize($object, $format = null, array $context = [])
     {
-        $data = parent::normalize($object, $format, $context);
+        $data = AbstractItemNormalizer::normalize($object, $format, $context);
         $data[self::ITEM_KEY] = serialize($object); // calling serialize prevent weird normalization process done by Webonyx's GraphQL PHP
 
         return $data;
@@ -57,16 +66,35 @@ protected function normalizeCollectionOfRelations(PropertyMetadata $propertyMeta
     /**
      * {@inheritdoc}
      */
-    public function supportsNormalization($data, $format = null)
+    public function supportsDenormalization($data, $type, $format = null)
     {
-        return self::FORMAT === $format && parent::supportsNormalization($data, $format);
+        return self::FORMAT === $format && parent::supportsDenormalization($data, $type, $format);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function supportsDenormalization($data, $type, $format = null)
+    protected function getAllowedAttributes($classOrObject, array $context, $attributesAsString = false)
     {
-        return self::FORMAT === $format && parent::supportsDenormalization($data, $type, $format);
+        $allowedAttributes = parent::getAllowedAttributes($classOrObject, $context, $attributesAsString);
+
+        if (($context['api_denormalize'] ?? false) && false !== ($indexId = array_search('id', $allowedAttributes, true))) {
+            $allowedAttributes[] = '_id';
+            array_splice($allowedAttributes, $indexId, 1);
+        }
+
+        return $allowedAttributes;
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    protected function setAttributeValue($object, $attribute, $value, $format = null, array $context = [])
+    {
+        if ('_id' === $attribute) {
+            $attribute = 'id';
+        }
+
+        parent::setAttributeValue($object, $attribute, $value, $format, $context);
     }
 }

src/Serializer/ItemNormalizer.php

@@ -18,9 +18,11 @@
 /**
  * Generic item normalizer.
  *
+ * @final
+ *
  * @author Kévin Dunglas <dunglas@gmail.com>
  */
-final class ItemNormalizer extends AbstractItemNormalizer
+class ItemNormalizer extends AbstractItemNormalizer
 {
     /**
      * {@inheritdoc}