[SPARK-54423][SS] Introducing OffsetMap to enable Named Streaming Sources #53123
+284
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericm-db
changed the title
HyukjinKwon
changed the title
anishshri-db
reviewed
Dec 2, 2025
| // Using index as sourceId initially, can be extended to support user-provided names | ||
| // This is initialized in the same path as the sources Seq (defined above) and is used | ||
| // in the same way, when OffsetLog v2 is used. | ||
| @volatile protected var sourceIdMap: Map[String, SparkDataStream] = Map.empty |
Contributor
There was a problem hiding this comment.
Why do we mark this as volatile ?
anishshri-db
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introducing the OffsetMap format to key source progress by source name, as opposed to ordinal in the logical plan
Why are the changes needed?
These changes are needed in order to enable source evolution on a streaming query (adding, removing, reordering sources) without requiring the user to set a new checkpoint directory
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No