[feat] [C API] Expose Get/Set Listener Name in C API #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2023
merlimat
approved these changes
Dec 11, 2023
shibd
approved these changes
Dec 11, 2023
Contributor
|
PR validation / Build the Wireshark dissector (macos-12) is very flaky due to the upstream (homebrew) issue. Let's ignore this test for now and merge it. |
Contributor
Author
|
Thanks all for the quick review, and for looking into those checks! Do you know if there's an expected timeline for |
Contributor
|
I updated the timeline with 2023/01/19 just now. |
|
apache/pulsar-client-node#214 is currently being blocked due to these changes not being released. What's the expected timeline for a release? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369
Motivation
The NodeJS client relies on the C API, which does not yet include the
getListenerandsetListenermethods. This means that using the NodeJS client, one is unable to choose which listener to create a client for.Modifications
Exposed
getListenerandsetListenervia the C API.Verifying this change
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)