system/settings: fix assertion triggered by uninitialized variables

Jean THOMAS · xiaoxiang781216 · commit bb508520f1e2 · 2025-06-26T19:23:02.000+08:00
Fix non-NULL pointer assertion in `get_setting()` caused by
uninitialized pointer variables.

Signed-off-by: Jean THOMAS &lt;jean@lambdaconcept.com&gt;
diff --git a/system/settings/settings.c b/system/settings/settings.c
@@ -1312,7 +1312,7 @@ int settings_create(FAR char *key, enum settings_type_e type, ...)
 int settings_type(FAR char *key, FAR enum settings_type_e *stype)
 {
   int ret;
-  FAR setting_t *setting;
+  FAR setting_t *setting = NULL;
 
   if (!g_settings.initialized)
     {
@@ -1360,7 +1360,7 @@ int settings_type(FAR char *key, FAR enum settings_type_e *stype)
 int settings_get(FAR char *key, enum settings_type_e type, ...)
 {
   int ret;
-  FAR setting_t *setting;
+  FAR setting_t *setting = NULL;
 
   if (!g_settings.initialized)
     {
@@ -1458,7 +1458,7 @@ int settings_get(FAR char *key, enum settings_type_e type, ...)
 int settings_set(FAR char *key, enum settings_type_e type, ...)
 {
   int ret;
-  FAR setting_t *setting;
+  FAR setting_t *setting = NULL;
   uint32_t h;
 
   if (!g_settings.initialized)

Original file line number	Diff line number	Diff line change
`@@ -1312,7 +1312,7 @@ int settings_create(FAR char *key, enum settings_type_e type, ...)`
`1312`	`1312`	`int settings_type(FAR char key, FAR enum settings_type_e stype)`
`1313`	`1313`	`{`
`1314`	`1314`	`int ret;`
`1315`		`- FAR setting_t *setting;`
	`1315`	`+ FAR setting_t *setting = NULL;`
`1316`	`1316`
`1317`	`1317`	`if (!g_settings.initialized)`
`1318`	`1318`	`{`
`@@ -1360,7 +1360,7 @@ int settings_type(FAR char key, FAR enum settings_type_e stype)`
`1360`	`1360`	`int settings_get(FAR char *key, enum settings_type_e type, ...)`
`1361`	`1361`	`{`
`1362`	`1362`	`int ret;`
`1363`		`- FAR setting_t *setting;`
	`1363`	`+ FAR setting_t *setting = NULL;`
`1364`	`1364`
`1365`	`1365`	`if (!g_settings.initialized)`
`1366`	`1366`	`{`
`@@ -1458,7 +1458,7 @@ int settings_get(FAR char *key, enum settings_type_e type, ...)`
`1458`	`1458`	`int settings_set(FAR char *key, enum settings_type_e type, ...)`
`1459`	`1459`	`{`
`1460`	`1460`	`int ret;`
`1461`		`- FAR setting_t *setting;`
	`1461`	`+ FAR setting_t *setting = NULL;`
`1462`	`1462`	`uint32_t h;`
`1463`	`1463`
`1464`	`1464`	`if (!g_settings.initialized)`