Revert "Index open performs version check on each segment, ignores indexCreatedVersionMajor (#14607)"

This reverts commit 3bf1011.

Author: Michael Sokolov

lucene/CHANGES.txt

@@ -131,7 +131,6 @@ Other
 * GITHUB#14761: Use more Comparators for PriorityQueue implementations. (Simon Cooper)
 * GITHUB#14817: Refactor some complex uses of PriorityQueue to use Comparators. (Simon Cooper)
 
-* GITHUB#14607: Index open performs version check on each segment, ignores indexCreatedVersionMajor (Rahul Goswami)
 ======================= Lucene 10.4.0 =======================
 
 API Changes

lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBasicBackwardsCompatibility.java

@@ -864,7 +864,7 @@ public void testFailOpenOldIndex() throws IOException {
     assertTrue(
         ex.getMessage()
             .contains(
-                "This Lucene version only supports indexes with major version "
+                "This Lucene version only supports indexes created with major version "
                     + Version.LATEST.major
                     + " or later"));
     // now open with allowed min version

lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java

@@ -346,12 +346,30 @@ public static final SegmentInfos readCommit(
             input);
       }
 
+      if (indexCreatedVersion < minSupportedMajorVersion) {
+        throw new IndexFormatTooOldException(
+            input,
+            "Index created with Lucene "
+                + indexCreatedVersion
+                + ".x is not supported by Lucene "
+                + Version.LATEST
+                + ". This Lucene version only supports indexes created with major version "
+                + minSupportedMajorVersion
+                + " or later (found: "
+                + indexCreatedVersion
+                + ", minimum: "
+                + minSupportedMajorVersion
+                + "). To resolve this issue: (1) Re-index your data using Lucene "
+                + Version.LATEST.major
+                + ".x, or (2) Use an older Lucene version that supports your index format.");
+      }
+
       SegmentInfos infos = new SegmentInfos(indexCreatedVersion);
       infos.id = id;
       infos.generation = generation;
       infos.lastGeneration = generation;
       infos.luceneVersion = luceneVersion;
-      parseSegmentInfos(directory, input, infos, format, minSupportedMajorVersion);
+      parseSegmentInfos(directory, input, infos, format);
       return infos;
 
     } catch (Throwable t) {
@@ -367,12 +385,7 @@ public static final SegmentInfos readCommit(
   }
 
   private static void parseSegmentInfos(
-      Directory directory,
-      DataInput input,
-      SegmentInfos infos,
-      int format,
-      int minSupportedMajorVersion)
-      throws IOException {
+      Directory directory, DataInput input, SegmentInfos infos, int format) throws IOException {
     infos.version = CodecUtil.readBELong(input);
     // System.out.println("READ sis version=" + infos.version);
     infos.counter = input.readVLong();
@@ -389,7 +402,6 @@ private static void parseSegmentInfos(
     }
 
     long totalDocs = 0;
-
     for (int seg = 0; seg < numSegments; seg++) {
       String segName = input.readString();
       byte[] segmentID = new byte[StringHelper.ID_LENGTH];
@@ -483,30 +495,6 @@ private static void parseSegmentInfos(
                 + infos.indexCreatedVersionMajor,
             input);
       }
-
-      int createdOrSegmentMinVersion =
-          info.getMinVersion() == null
-              ? infos.indexCreatedVersionMajor
-              : info.getMinVersion().major;
-
-      // version >=7 are expected to record minVersion
-      if (info.getMinVersion() == null || info.getMinVersion().major < minSupportedMajorVersion) {
-        throw new IndexFormatTooOldException(
-            input,
-            "Index has segments derived from Lucene version "
-                + createdOrSegmentMinVersion
-                + ".x and is not supported by Lucene "
-                + Version.LATEST
-                + ". This Lucene version only supports indexes with major version "
-                + minSupportedMajorVersion
-                + " or later (found: "
-                + createdOrSegmentMinVersion
-                + ", minimum supported: "
-                + minSupportedMajorVersion
-                + "). To resolve this issue re-index your data using Lucene "
-                + minSupportedMajorVersion
-                + ".x or later.");
-      }
     }
 
     infos.userData = input.readMapOfStrings();