-
Notifications
You must be signed in to change notification settings - Fork 14.8k
KAFKA-19951: Update lz4 dependency version for CVE-2025-12183 & CVE-2025-66566 #21035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Updated lz4 dependency version from 1.8.0 to 1.8.1. For https://nvd.nist.gov/vuln/detail/CVE-2025-12183
|
Thanks for the patch. Could you also update |
|
@DL1231 thank you, updated license binary, do you know how |
|
I linked the PR to KAFKA-19951. Regarding the compression level, it's explained in |
|
Also there's still a build issue: |
It looks like there was a recent change to discontinue https://github.com/lz4/lz4-java, in favor of community fork https://github.com/yawkat/lz4-java . I'll try updating to new GAV |
|
Maintainer here. Interesting, did you see that error when depending on org.lz4:lz4-java:1.8.1 directly, without any reference to at.yawk.lz4? Maybe there's something wrong with the gradle capability metadata |
|
Looks like max compression level is unchanged at |
Yeah, had to switch to your gav for it to work (I'm just a random person not affil with apache): 51c520e |
Simple example demonstrating the issue mentioned by @mimaison: If only There might be an issue with the capability configuration together with the relocation settings, which could be the reason for the problem. |
|
@mjschwaiger I made a test case here: https://github.com/yawkat/test-case-gradle-rename-capability I think it's a gradle bug, I've asked on the gradle community slack about it. |
chia7712
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@mimaison do you have time to take a look at this? |
|
BTW: If the Java project is discontinued, I think it would be a good idea to get rid of the library. Not sure where I could raise this question as an issue. |
I recommend KAFKA-17301 for raising this issue 😄 |
gradle/dependencies.gradle
Outdated
| lz4: "1.8.0", | ||
| // https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/record/CompressionType.java#L73-L74 | ||
| // https://github.com/yawkat/lz4-java/blob/main/src/java/net/jpountz/lz4/LZ4Constants.java#L23-L24 | ||
| lz4: "1.8.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we directly bump to 1.10.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done (cd8be9e)
org.lz4:lz4-java is not maintained but at.yawk.lz4:lz4-java is a new fork that is maintained. |
DL1231
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the patch.
|
Really looking forward to this team!. We have many services using this library and the "CVE alerts" already raised. Thanks for the great job! |
|
@erikanderson sorry for intervening on your PR, but we have two planned releases waiting for this patch 😃 |
FrankYang0529
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the patch.
|
I recommend you wait a few hours before merging this. Another (smaller, unrelated) CVE was found in lz4-java. |
|
If someone else runs into this coming from Spring Boot / Spring Kafka + Gradle. |
|
The readme of the new repository and the old repository contains a message saying that this has been forked to fix a specific CVE. At the same time - the link to that CVE seems quite fishy (it's a page that kinda looks like the Sonatype page, but is hosted on Supply chain attacks like sha1-hulud are happening quite often right now. Just asking. |
|
@apokralipsa That's only prudent. You can see that the CVE was published by sonatype if you look at the CVE feed: https://www.cvedetails.com/vulnerability-list/assigner-366/Sonatype.html There is also a comment describing the move in the relocation pom: https://repo.maven.apache.org/maven2/org/lz4/lz4-java/1.8.1/lz4-java-1.8.1.pom If I was malicious and had access to publish org.lz4 to maven central, I wouldn't need to move the group id in the first place, I could just continue with the old namespace. Because I do not have permission to publish org.lz4, I had to secure support from sonatype and the lz4 project to do the move. |
|
@yawkat @apokralipsa doesn't say this CVE isn't real. He has (IMO valid) concerns about the url you provided (https://sites.google.com/sonatype.com/vulnerabilities/cve-2025-12183) instead of the valid one (like this: https://www.cve.org/CVERecord?id=CVE-2025-12183). |
|
Yes, I understand that, and I find it prudent that you pay attention to this. This vulnerability and fix is definitely suspicious due to the project governance changes, compared to e.g. the xz backdoor. However https://sites.google.com/sonatype.com/vulnerabilities/cve-2025-12183 is a real Sonatype site, and you can see the CVE metadata is published by Sonatype in the CVE feed. I'm just providing evidence that I am honest :) |
|
CVE-2025-66566 has been published and fixed in 1.10.1. I suggest you move to that version. Though cloudflare seems to be having some trouble that breaks maven central at the moment. |
@yawkat I'm not sure that is the right CVE, that one is for oat++ https://nvd.nist.gov/vuln/detail/CVE-2025-6566 . Can you link to the right CVE? |
|
66566, not 6566. It's not on nvd yet i guess |
|
My mistake, misread the number, and when I did search for the new value it gave me the oat one. Looks like second CVE has been published: https://nvd.nist.gov/vuln/detail/CVE-2025-66566 |
|
In the mean time I have contacted Sonatype over email and they have confirmed that they are aware of the relocation and they have been in touch with the previous owners of lz4-java. |
|
@yawkat : Does Sonatype also need to configure relocation for 1.10.1? I still get this error when trying to update my local (Maven) project: In my Gradle projects I can still use the So either Sonatype needs to support relocation or everyone needs to replace the dependency, I suppose? (Thanks for your great work so far, by the way! 🌻 🚀 ) |
|
There will be no relocation for versions past 1.8.1 |
|
Dear all, is it good to go for merging? it would be cool to have your approval 😄 |
|
There's still a mention of |
mimaison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updated lz4 dependency version from 1.8.0 to 1.10.1
CVE-2025-12183
https://nvd.nist.gov/vuln/detail/CVE-2025-12183
CVE-2025-66566
https://nvd.nist.gov/vuln/detail/CVE-2025-66566
Releases
https://github.com/yawkat/lz4-java/releases/tag/v1.8.1
https://github.com/yawkat/lz4-java/releases/tag/v1.10.0
https://github.com/yawkat/lz4-java/releases/tag/v1.10.1
Reviewers: Gaurav Narula gaurav_narula2@apple.com, Lan Ding
isDing_L@163.com, Chia-Ping Tsai chia7712@gmail.com, Mickael Maison
mimaison@apache.org, PoAn Yang payang@apache.org