fix: fix rewrite_not to process complex nested not (#1431)

Author: ZENOTME

crates/iceberg/src/expr/predicate.rs

@@ -28,6 +28,8 @@ use itertools::Itertools;
 use serde::{Deserialize, Serialize};
 
 use crate::error::Result;
+use crate::expr::visitors::predicate_visitor::visit;
+use crate::expr::visitors::rewrite_not::RewriteNotVisitor;
 use crate::expr::{Bind, BoundReference, PredicateOperator, Reference};
 use crate::spec::{Datum, PrimitiveLiteral, SchemaRef};
 use crate::{Error, ErrorKind};
@@ -652,29 +654,8 @@ impl Predicate {
     /// assert_eq!(&format!("{result}"), "a >= 5");
     /// ```
     pub fn rewrite_not(self) -> Predicate {
-        match self {
-            Predicate::And(expr) => {
-                let [left, right] = expr.inputs;
-                let new_left = Box::new(left.rewrite_not());
-                let new_right = Box::new(right.rewrite_not());
-                Predicate::And(LogicalExpression::new([new_left, new_right]))
-            }
-            Predicate::Or(expr) => {
-                let [left, right] = expr.inputs;
-                let new_left = Box::new(left.rewrite_not());
-                let new_right = Box::new(right.rewrite_not());
-                Predicate::Or(LogicalExpression::new([new_left, new_right]))
-            }
-            Predicate::Not(expr) => {
-                let [inner] = expr.inputs;
-                inner.negate()
-            }
-            Predicate::Unary(expr) => Predicate::Unary(expr),
-            Predicate::Binary(expr) => Predicate::Binary(expr),
-            Predicate::Set(expr) => Predicate::Set(expr),
-            Predicate::AlwaysTrue => Predicate::AlwaysTrue,
-            Predicate::AlwaysFalse => Predicate::AlwaysFalse,
-        }
+        visit(&mut RewriteNotVisitor::new(), &self)
+            .expect("RewriteNotVisitor guarantees always success")
     }
 }
 

crates/iceberg/src/expr/visitors/mod.rs

@@ -21,6 +21,8 @@ pub(crate) mod inclusive_metrics_evaluator;
 pub(crate) mod inclusive_projection;
 pub(crate) mod manifest_evaluator;
 pub(crate) mod page_index_evaluator;
+pub(crate) mod predicate_visitor;
+pub(crate) mod rewrite_not;
 pub(crate) mod row_group_metrics_evaluator;
 pub(crate) mod strict_metrics_evaluator;
 pub(crate) mod strict_projection;