Skip to content

Commit 668e78b

Browse files
committed
Adjust comments, mostly just to kick CI.
1 parent c2fcc66 commit 668e78b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

crates/iceberg/src/arrow/record_batch_transformer.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -407,11 +407,11 @@ impl RecordBatchTransformer {
407407
// 3. Use initial_default
408408
// 4. Return null
409409
//
410-
// WHY check partition constants before Parquet field IDs (Java: BaseParquetReaders.java:299):
410+
// Why check partition constants before Parquet field IDs (Java: BaseParquetReaders.java:299):
411411
// In add_files scenarios, partition columns may exist in BOTH Parquet AND partition metadata.
412412
// Partition metadata is authoritative - it defines which partition this file belongs to.
413413

414-
// WHY verify names when checking field IDs:
414+
// Why verify names when checking field IDs:
415415
// add_files can create field ID conflicts (Parquet field_id=1->"name", Iceberg field_id=1->"id").
416416
// Name mismatches with name_mapping present indicate conflicts, treat field as "not present".
417417
// Without name_mapping, name mismatches are just column renames, so trust the field ID.
@@ -1502,7 +1502,7 @@ mod test {
15021502

15031503
/// Verifies field ID conflict detection for add_files imports.
15041504
///
1505-
/// WHY: add_files can import Parquet with conflicting field IDs (field_id=1->"name" in Parquet
1505+
/// Why: add_files can import Parquet with conflicting field IDs (field_id=1->"name" in Parquet
15061506
/// vs field_id=1->"id" in Iceberg). Name-checking detects conflicts, treats fields as "not present",
15071507
/// allowing spec fallback to partition constants and name mapping.
15081508
///

0 commit comments

Comments
 (0)