fix clippy

Author: CTTY

crates/iceberg/src/transaction/append.rs

@@ -94,7 +94,6 @@ impl TransactionAction for FastAppendAction {
             vec![],
             vec![],
             vec![],
-            None,
         );
 
         // validate added files

crates/iceberg/src/transaction/rewrite_files.rs

@@ -151,16 +151,15 @@ impl TransactionAction for RewriteFilesAction {
             self.added_delete_files.clone(),
             self.deleted_data_files.clone(),
             self.deleted_delete_files.clone(),
-            self.data_sequence_number.clone(),
         );
 
         let rewrite_operation = RewriteFilesOperation {
             added_data_files: self.added_data_files.clone(),
             added_delete_files: self.added_delete_files.clone(),
             deleted_data_files: self.deleted_data_files.clone(),
             deleted_delete_files: self.deleted_delete_files.clone(),
-            starting_snapshot_id: self.starting_snapshot_id.clone(),
-            data_sequence_number: self.data_sequence_number.clone(),
+            starting_snapshot_id: self.starting_snapshot_id,
+            data_sequence_number: self.data_sequence_number,
         };
 
         // todo should be able to configure to use the merge manifest process

crates/iceberg/src/transaction/snapshot.rs

@@ -82,7 +82,6 @@ pub(crate) struct SnapshotProducer<'a> {
     // It starts from 0 and increments for each new manifest file.
     // Note: This counter is limited to the range of (0..u64::MAX).
     manifest_counter: RangeFrom<u64>,
-    starting_sequence_number: Option<i64>,
 }
 
 impl<'a> SnapshotProducer<'a> {
@@ -97,7 +96,6 @@ impl<'a> SnapshotProducer<'a> {
         added_delete_files: Vec<DataFile>,
         deleted_data_files: Vec<DataFile>,
         deleted_delete_files: Vec<DataFile>,
-        starting_sequence_number: Option<i64>,
     ) -> Self {
         Self {
             table,
@@ -110,7 +108,6 @@ impl<'a> SnapshotProducer<'a> {
             deleted_data_files,
             deleted_delete_files,
             manifest_counter: (0..),
-            starting_sequence_number,
         }
     }
 

crates/iceberg/src/transaction/validate.rs

@@ -91,7 +91,7 @@ pub(crate) trait SnapshotValidator {
         let snapshots = ancestors_between(
             &Arc::new(base.metadata().clone()),
             to_snapshot_id,
-            from_snapshot_id.clone(),
+            from_snapshot_id,
         );
 
         for current_snapshot in snapshots {
@@ -193,18 +193,12 @@ pub(crate) trait SnapshotValidator {
         }
 
         // Get starting seq num from starting snapshot if available
-        let starting_sequence_number = if from_snapshot_id.is_some()
-            && base
-                .metadata()
-                .snapshots
-                .get(&from_snapshot_id.unwrap())
-                .is_some()
-        {
-            base.metadata()
-                .snapshots
-                .get(&from_snapshot_id.unwrap())
-                .unwrap()
-                .sequence_number()
+
+        let starting_sequence_number = if let Some(from_snapshot_id) = from_snapshot_id {
+            match base.metadata().snapshots.get(&from_snapshot_id) {
+                Some(snapshot) => snapshot.sequence_number(),
+                None => INITIAL_SEQUENCE_NUMBER,
+            }
         } else {
             INITIAL_SEQUENCE_NUMBER
         };