Skip to content

Conversation

@mas-chen
Copy link
Contributor

…ing nested unit tests

The root cause of the duplicate nested test execution is noted in this github issue: junit-team/junit-framework#3782. TLDR, the outer test runs once (running all its nested tests), then the nested tests run again due to the include test regex.

Surefire also excludes nested tests by default. https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html

I have tested this approach in mas-chen#8 and realized that excluding tests was only available from 1.1.0 of the parent pom.

@mas-chen mas-chen requested a review from MartijnVisser April 26, 2024 02:16
@mas-chen
Copy link
Contributor Author

This shaves 1-2 minutes from CI

@mas-chen mas-chen force-pushed the FLINK-34127-new branch 2 times, most recently from 2566dab to e11942e Compare April 26, 2024 02:23
@github-actions
Copy link

This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant