Rename from keep_duplicate_keys to drop_duplicate_keys

Author: timsaucer

python/datafusion/dataframe.py

@@ -774,7 +774,7 @@ def join(
         left_on: None = None,
         right_on: None = None,
         join_keys: None = None,
-        keep_duplicate_keys: bool = False,
+        drop_duplicate_keys: bool = True,
     ) -> DataFrame: ...
 
     @overload
@@ -787,7 +787,7 @@ def join(
         left_on: str | Sequence[str],
         right_on: str | Sequence[str],
         join_keys: tuple[list[str], list[str]] | None = None,
-        keep_duplicate_keys: bool = False,
+        drop_duplicate_keys: bool = True,
     ) -> DataFrame: ...
 
     @overload
@@ -800,7 +800,7 @@ def join(
         join_keys: tuple[list[str], list[str]],
         left_on: None = None,
         right_on: None = None,
-        keep_duplicate_keys: bool = False,
+        drop_duplicate_keys: bool = True,
     ) -> DataFrame: ...
 
     def join(
@@ -812,7 +812,7 @@ def join(
         left_on: str | Sequence[str] | None = None,
         right_on: str | Sequence[str] | None = None,
         join_keys: tuple[list[str], list[str]] | None = None,
-        keep_duplicate_keys: bool = False,
+        drop_duplicate_keys: bool = True,
     ) -> DataFrame:
         """Join this :py:class:`DataFrame` with another :py:class:`DataFrame`.
 
@@ -825,7 +825,7 @@ def join(
                 "right", "full", "semi", "anti".
             left_on: Join column of the left dataframe.
             right_on: Join column of the right dataframe.
-            keep_duplicate_keys: When False, the columns from the right DataFrame
+            drop_duplicate_keys: When True, the columns from the right DataFrame
                 that have identical names in the ``on`` fields to the left DataFrame
                 will be dropped.
             join_keys: Tuple of two lists of column names to join on. [Deprecated]
@@ -875,7 +875,7 @@ def join(
             right_on = [right_on]
 
         return DataFrame(
-            self.df.join(right.df, how, left_on, right_on, keep_duplicate_keys)
+            self.df.join(right.df, how, left_on, right_on, drop_duplicate_keys)
         )
 
     def join_on(

src/dataframe.rs

@@ -629,7 +629,7 @@ impl PyDataFrame {
         how: &str,
         left_on: Vec<PyBackedStr>,
         right_on: Vec<PyBackedStr>,
-        keep_duplicate_keys: bool,
+        drop_duplicate_keys: bool,
     ) -> PyDataFusionResult<Self> {
         let join_type = match how {
             "inner" => JoinType::Inner,
@@ -656,7 +656,7 @@ impl PyDataFrame {
             None,
         )?;
 
-        if !keep_duplicate_keys {
+        if drop_duplicate_keys {
             let mutual_keys = left_keys
                 .iter()
                 .zip(right_keys.iter())