[SOL] Adjust SBF customization after upgrading to rust 1.65.0

Author: dmakarov

.github/workflows/ci.yml

@@ -226,7 +226,7 @@ jobs:
         uses: rust-lang/simpleinfra/github-actions/cancel-outdated-builds@master
         with:
           github_token: "${{ secrets.github_token }}"
-        if: "success() && !env.SKIP_JOB && github.ref != 'refs/heads/try'"
+        if: "success() && !env.SKIP_JOB && github.ref != 'refs/heads/try' && github.ref != 'refs/heads/try-perf'"
       - name: collect CPU statistics
         run: src/ci/scripts/collect-cpu-stats.sh
         if: success() && !env.SKIP_JOB
@@ -245,9 +245,6 @@ jobs:
       - name: install WIX
         run: src/ci/scripts/install-wix.sh
         if: success() && !env.SKIP_JOB
-      - name: ensure the build happens on a partition with enough space
-        run: src/ci/scripts/symlink-build-dir.sh
-        if: success() && !env.SKIP_JOB
       - name: disable git crlf conversion
         run: src/ci/scripts/disable-git-crlf-conversion.sh
         if: success() && !env.SKIP_JOB

compiler/rustc_codegen_ssa/src/back/metadata.rs

@@ -208,9 +208,10 @@ pub(crate) fn create_object_file(sess: &Session) -> Option<write::Object<'static
         "avr" => Architecture::Avr,
         "msp430" => Architecture::Msp430,
         "hexagon" => Architecture::Hexagon,
-        "bpf" => Architecture::Bpf,
         "loongarch64" => Architecture::LoongArch64,
         "csky" => Architecture::Csky,
+        "bpf" => Architecture::Bpf,
+        "sbf" => Architecture::Bpf,
         // Unsupported architecture.
         _ => return None,
     };

compiler/rustc_target/src/abi/call/sbf.rs

@@ -26,7 +26,7 @@ pub fn compute_abi_info<Ty>(fn_abi: &mut FnAbi<'_, Ty>) {
         classify_ret(&mut fn_abi.ret);
     }
 
-    for arg in &mut fn_abi.args {
+    for arg in fn_abi.args.iter_mut() {
         if arg.is_ignore() {
             continue;
         }

compiler/rustc_target/src/spec/sbf_base.rs

@@ -1,5 +1,5 @@
 use crate::abi::Endian;
-use super::{LinkArgs, LinkerFlavor, PanicStrategy, TargetOptions, LldFlavor};
+use super::{cvs, LinkArgs, LinkerFlavor, PanicStrategy, TargetOptions, LldFlavor};
 
 pub fn opts() -> TargetOptions {
     let linker_script = r"
@@ -33,6 +33,7 @@ SECTIONS
     lld_args.push("-z".into());
     lld_args.push("notext".into());
     let mut pre_link_args = LinkArgs::new();
+    pre_link_args.insert(LinkerFlavor::Ld, lld_args.clone());
     pre_link_args.insert(LinkerFlavor::Lld(LldFlavor::Ld), lld_args);
 
     TargetOptions {
@@ -46,6 +47,7 @@ SECTIONS
         env: "".into(),
         executables: true,
         features: "+solana".into(),
+        families: cvs!["solana"],
         link_script: Some(linker_script.into()),
         linker: Some("rust-lld".into()),
         linker_flavor: LinkerFlavor::Lld(LldFlavor::Ld),

compiler/rustc_target/src/spec/tests/tests_impl.rs

@@ -27,7 +27,8 @@ impl Target {
             matches!(self.linker_flavor, LinkerFlavor::WasmLld(..))
         );
         assert_eq!(self.os == "emscripten", matches!(self.linker_flavor, LinkerFlavor::EmCc));
-        assert_eq!(self.arch == "bpf", matches!(self.linker_flavor, LinkerFlavor::Bpf));
+        assert_eq!(self.arch == "bpf" && self.features != "+solana",
+                   matches!(self.linker_flavor, LinkerFlavor::Bpf));
         assert_eq!(self.arch == "nvptx64", matches!(self.linker_flavor, LinkerFlavor::Ptx));
 
         for args in [

library/core/benches/lib.rs

@@ -1,5 +1,5 @@
 // wasm32 does not support benches (no time).
-#![cfg(not(any(target_arch = "wasm32", target_arch = "bpf", target_arch = "sbf")))]
+#![cfg(not(any(target_arch = "wasm32", target_family = "solana")))]
 #![feature(flt2dec)]
 #![feature(test)]
 #![feature(trusted_random_access)]

library/core/benches/num/int_log/mod.rs

@@ -1,4 +1,4 @@
-#![cfg(all(not(target_arch = "bpf"), not(target_arch = "sbf")))]
+#![cfg(not(target_family = "solana"))]
 use rand::Rng;
 use test::{black_box, Bencher};
 

library/core/src/fmt/mod.rs

@@ -5,7 +5,7 @@
 use crate::cell::{Cell, Ref, RefCell, RefMut, SyncUnsafeCell, UnsafeCell};
 use crate::char::EscapeDebugExtArgs;
 use crate::iter;
-#[cfg(any(target_arch = "bpf", target_arch = "sbf"))]
+#[cfg(target_family = "solana")]
 use crate::intrinsics::abort;
 use crate::marker::PhantomData;
 use crate::mem;

library/core/src/fmt/num.rs

@@ -474,7 +474,7 @@ mod imp {
     );
 }
 
-#[cfg(not(any(target_pointer_width = "64", target_arch = "wasm32", target_arch = "bpf", target_arch = "sbf")))]
+#[cfg(not(any(target_pointer_width = "64", target_arch = "wasm32", target_family = "solana")))]
 mod imp {
     use super::*;
     impl_Display!(i8, u8, i16, u16, i32, u32, isize, usize as u32 via to_u32 named fmt_u32);

library/core/tests/array.rs

@@ -1,4 +1,4 @@
-#![cfg(all(not(target_arch = "bpf"), not(target_arch = "sbf")))]
+#![cfg(not(target_family = "solana"))]
 use core::{array, assert_eq};
 use core::convert::TryFrom;
 use core::num::NonZeroUsize;
@@ -513,7 +513,7 @@ fn array_rsplit_array_mut_out_of_bounds() {
 }
 
 #[test]
-#[cfg(all(not(target_arch = "bpf"), not(target_arch = "sbf")))]
+#[cfg(not(target_family = "solana"))]
 fn array_intoiter_advance_by() {
     use std::cell::Cell;
     struct DropCounter<'a>(usize, &'a Cell<usize>);
@@ -567,7 +567,7 @@ fn array_intoiter_advance_by() {
 }
 
 #[test]
-#[cfg(all(not(target_arch = "bpf"), not(target_arch = "sbf")))]
+#[cfg(not(target_family = "solana"))]
 fn array_intoiter_advance_back_by() {
     use std::cell::Cell;
     struct DropCounter<'a>(usize, &'a Cell<usize>);