Skip to content

Commit e3307b7

Browse files
committed
IOS-5420 Add code review to cpp comand
1 parent 378163a commit e3307b7

File tree

2 files changed

+33
-6
lines changed

2 files changed

+33
-6
lines changed

.claude/commands/codeReview.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,13 @@ git diff develop...HEAD
2323
### Step 2: Apply Review Standards
2424

2525
**Apply the shared review guidelines from:**
26-
`.github/workflows/code-review-guidelines.md`
26+
`.claude/CODE_REVIEW_GUIDE.md`
2727

2828
Follow all core rules, review sections, common mistakes, and analysis checklist defined in that file.
2929

30+
**Also consult:**
31+
- `.claude/skills/code-review-developer/SKILL.md` - Quick reference for critical rules and workflow
32+
3033
**Context adaptation for local reviews:**
3134
- This is a local review (not a GitHub PR)
3235
- Reference file:line locations from the git diff

.claude/commands/cpp.md

Lines changed: 29 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,40 @@
1-
Commit, push, pull request
1+
Commit, review, push, pull request
22

33
## Usage
44
```
55
/cpp [in branch <branch-name>]
66
```
77

88
## Description
9-
Commits the current changes, pushes to remote, and creates a pull request.
9+
Commits the current changes, performs a code review, applies fixes if needed, then pushes to remote and creates a pull request.
1010

1111
## Optional Arguments
1212
- `in branch <branch-name>` - Specifies the target branch to use for the commit, push, and PR
1313

14+
## Workflow
15+
16+
### 1. Commit Changes
17+
- Stage and commit all changes with a descriptive message
18+
- Follow CLAUDE.md commit message guidelines
19+
20+
### 2. Code Review
21+
- Run automated code review using `/codeReview` workflow
22+
- Apply CODE_REVIEW_GUIDE.md standards
23+
- Check for bugs, best practices violations, performance issues, security concerns
24+
25+
### 3. Review Findings
26+
- Present review results to developer
27+
- If issues found, **STOP and discuss** with developer:
28+
- Should we fix the issues now?
29+
- Are the findings valid or false positives?
30+
- Should we proceed anyway?
31+
- **Developer decides next steps** - never auto-amend commits
32+
33+
### 4. Push and PR (when approved)
34+
- Only proceed when developer approves
35+
- Push to remote with tracking
36+
- Create pull request with summary
37+
1438
## Branch Handling
1539
When a branch name is provided:
1640
1. **Branch doesn't exist locally or remotely**: Creates a new branch with the specified name
@@ -19,12 +43,12 @@ When a branch name is provided:
1943

2044
## Examples
2145
```bash
22-
# Commit, push, and PR on current branch
46+
# Commit, review, push, and PR on current branch
2347
/cpp
2448

25-
# Commit, push, and PR on specific branch (creates if doesn't exist)
49+
# Commit, review, push, and PR on specific branch (creates if doesn't exist)
2650
/cpp in branch ios-5364-add-claude-to-gh-actions
2751

28-
# Commit, push, and PR on existing branch
52+
# Commit, review, push, and PR on existing branch
2953
/cpp in branch develop
3054
```

0 commit comments

Comments
 (0)