Skip to content

Commit 3f9069e

Browse files
authored
Merge pull request #5 from anypointcloud/3-missing-parameter-error-in-json-logger-when-flowing-logs-to-amqp
3 missing parameter error in json logger when flowing logs to amqp
2 parents 0d64d4c + 91bc407 commit 3f9069e

File tree

3 files changed

+10
-27
lines changed

3 files changed

+10
-27
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ PART 2: https://blogs.mulesoft.com/dev/api-dev/json-logging-in-mule-4/
8686
* Replaced joda-time by JDK Date and Time API
8787
* Upgraded depdendencies
8888
* Removed unused dependencies
89+
* Fixed AMQP destination
8990

9091
### 2.2.1 version - Release notes
9192

pom.xml

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -138,21 +138,7 @@
138138
<dependency>
139139
<groupId>com.mulesoft.muleesb.modules</groupId>
140140
<artifactId>anypoint-mq-rest-client</artifactId>
141-
<version>4.0.13-1.fix-race-condition</version>
142-
<exclusions>
143-
<exclusion>
144-
<artifactId>async-http-client</artifactId>
145-
<groupId>com.ning</groupId>
146-
</exclusion>
147-
<exclusion>
148-
<artifactId>spring-core</artifactId>
149-
<groupId>org.springframework</groupId>
150-
</exclusion>
151-
<exclusion>
152-
<groupId>com.google.code.gson</groupId>
153-
<artifactId>gson</artifactId>
154-
</exclusion>
155-
</exclusions>
141+
<version>4.0.12</version>
156142
<scope>compile</scope>
157143
</dependency>
158144
<dependency>

src/main/java/org/mule/extension/jsonlogger/internal/destinations/AMQPDestination.java

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package org.mule.extension.jsonlogger.internal.destinations;
22

3-
import com.mule.extensions.amqp.api.message.AmqpMessageBuilder;
43
import com.mule.extensions.amqp.api.message.AmqpProperties;
54
import org.mule.runtime.api.metadata.TypedValue;
65
import org.mule.runtime.extension.api.annotation.param.NullSafe;
@@ -9,16 +8,14 @@
98
import org.mule.runtime.extension.api.annotation.param.display.DisplayName;
109
import org.mule.runtime.extension.api.annotation.param.display.Summary;
1110
import org.mule.runtime.extension.api.annotation.param.reference.ConfigReference;
12-
import org.mule.runtime.extension.api.client.DefaultOperationParameters;
1311
import org.mule.runtime.extension.api.client.ExtensionsClient;
14-
import org.mule.runtime.extension.api.client.OperationParameters;
12+
import org.mule.runtime.extension.api.client.OperationParameterizer;
1513
import org.slf4j.Logger;
1614
import org.slf4j.LoggerFactory;
1715

1816
import javax.inject.Inject;
1917
import java.util.ArrayList;
20-
import java.util.Map;
21-
import java.util.concurrent.ConcurrentHashMap;
18+
import java.util.function.Consumer;
2219

2320
import static org.mule.runtime.api.metadata.DataType.JSON_STRING;
2421

@@ -72,13 +69,12 @@ public ArrayList<String> getSupportedCategories() {
7269
@Override
7370
public void sendToExternalDestination(String finalLog) {
7471
try {
75-
OperationParameters parameters = DefaultOperationParameters.builder().configName(this.amqpConfigurationRef)
76-
.addParameter("exchangeName", this.exchangeDestination)
77-
.addParameter("messageBuilder", AmqpMessageBuilder.class, DefaultOperationParameters.builder()
78-
.addParameter("body", new TypedValue<>(finalLog, JSON_STRING))
79-
.addParameter("properties", new AmqpProperties()))
80-
.build();
81-
extensionsClient.executeAsync("AMQP", "publish", parameters);
72+
Consumer<OperationParameterizer> parameters = operationParameterizer ->
73+
operationParameterizer.withConfigRef(this.amqpConfigurationRef)
74+
.withParameter("exchangeName", this.exchangeDestination)
75+
.withParameter("body", new TypedValue<>(finalLog, JSON_STRING))
76+
.withParameter("properties", new AmqpProperties());
77+
extensionsClient.execute("AMQP", "publish", parameters);
8278
} catch (Exception e) {
8379
LOGGER.error("Error: " + e.getMessage());
8480
e.printStackTrace();

0 commit comments

Comments
 (0)