fix: update no_new_attr import logic for pyvista version compatibility

Author: germa89

src/ansys/mapdl/core/mapdl_core.py

@@ -2700,7 +2700,12 @@ def _enable_picking_entities(
             pass
 
         # adding selection inversor
-        pl.scene._inver_mouse_click_selection = False
+        import pyvista
+
+        if pyvista.version_info >= (0, 46, 0):
+            pyvista.set_new_attribute(pl.scene, "_inver_mouse_click_selection", False)
+        else:
+            pl.scene._inver_mouse_click_selection = False
 
         selection_text = {
             "S": "New selection",

src/ansys/mapdl/core/plotting/plotting_defaults.py

@@ -24,7 +24,14 @@
 from pyvista.core import _vtk_core as _vtk
 from pyvista.core.utilities import translate
 from pyvista.core.utilities.helpers import wrap
-from pyvista.core.utilities.misc import no_new_attr
+
+if pv.version_info >= (0, 46, 0):
+    # From v0.46.0, this decorator is not needed anymore.
+    def no_new_attr(cls):
+        return cls
+
+else:
+    from pyvista.core.utilities.misc import no_new_attr
 
 # I dont want to have to fix a very recent lower bound for pyvista.
 # Hence I'm copying what I need from there.

tests/test_plotting.py

@@ -566,8 +566,8 @@ def test_pick_nodes(mapdl, make_block, selection, verify_image_cache):
     def debug_orders(pl, point):
         pl = pl.scene
         pl.show(auto_close=False)
-        pl.windows_size = (100, 100)
-        width, height = pl.window_size
+        width, height = (100, 100)
+
         if pl._picking_right_clicking_observer is None:
             pl.iren._mouse_left_button_press(
                 int(width * point[0]), int(height * point[1])
@@ -638,8 +638,8 @@ def test_pick_kp(mapdl, make_block, selection):
     def debug_orders(pl, point):
         pl = pl.scene
         pl.show(auto_close=False)
-        pl.windows_size = (100, 100)
-        width, height = pl.window_size
+        width, height = (100, 100)
+
         if pl._picking_right_clicking_observer is None:
             pl.iren._mouse_left_button_press(
                 int(width * point[0]), int(height * point[1])
@@ -759,8 +759,7 @@ def test_pick_node_special_cases(mapdl, make_block):
     def debug_orders_0(pl, point):
         pl = pl.scene
         pl.show(auto_close=False)
-        pl.windows_size = (100, 100)
-        width, height = pl.window_size
+        width, height = (100, 100)
         pl.iren._mouse_move(int(width * point[0]), int(height * point[1]))
 
     mapdl.nsel("S", "node", "", 1)
@@ -777,8 +776,8 @@ def debug_orders_0(pl, point):
     def debug_orders_1(pl, point):
         pl = pl.scene
         pl.show(auto_close=False)
-        pl.windows_size = (100, 100)
-        width, height = pl.window_size
+        width, height = (100, 100)
+
         # First click
         pl.iren._mouse_left_button_press(int(width * point[0]), int(height * point[1]))
         pl.iren._mouse_left_button_release(width, height)
@@ -810,8 +809,8 @@ def test_pick_node_select_unselect_with_mouse(mapdl, make_block):
     def debug_orders_1(pl, point):
         pl = pl.scene
         pl.show(auto_close=False)
-        pl.windows_size = (100, 100)
-        width, height = pl.window_size
+        width, height = (100, 100)
+
         # First click- selecting
         pl.iren._mouse_left_button_press(int(width * point[0]), int(height * point[1]))
         pl.iren._mouse_left_button_release(width, height)
@@ -848,8 +847,7 @@ def test_pick_areas(mapdl, make_block, selection):
     def debug_orders(pl, point):
         pl = pl.scene
         pl.show(auto_close=False)
-        pl.windows_size = (100, 100)
-        width, height = pl.window_size
+        width, height = (100, 100)
         if pl._picking_right_clicking_observer is None:
             pl.iren._mouse_left_button_press(
                 int(width * point[0]), int(height * point[1])