Skip to content

Commit ba467b8

Browse files
author
cwardgar
committed
Remove unnecessary curly brackets from *when: statements
The braces are unnecessary. See http://docs.ansible.com/ansible/playbooks_conditionals.html#the-when-statement Their presence caused a warning: [WARNING]: when statements should not include jinja2 templating delimiters such as {{ }} or {% %}.
1 parent b558aa5 commit ba467b8

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

tasks/check_environment.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
- name: determine if Java is already installed
1010
shell: which java
1111
register: oracle_java_task_installed
12-
changed_when: "{{ oracle_java_task_installed.rc != 0 }}"
12+
changed_when: oracle_java_task_installed.rc != 0
1313
failed_when: no
1414
# oracle_java_installed.rc == 0 : installed
1515
# oracle_java_installed.rc == 1 : not installed
@@ -32,7 +32,7 @@
3232

3333
- debug:
3434
var="{{ item }}"
35-
when: "{{ item }} is defined and debug | default(false)"
35+
when: item is defined and debug | default(false)
3636
with_items:
3737
- oracle_java_installed
3838
- oracle_java_task_installed

tasks/debian/main.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
changed_when: licence_not_accepted.rc != 0
1919
become: yes
2020

21-
when: "{{ ansible_distribution == 'Ubuntu' }}"
21+
when: ansible_distribution == 'Ubuntu'
2222

2323
- block:
2424
- name: debian | ensure the webupd8 launchpad apt repository key is present
@@ -38,11 +38,11 @@
3838
- deb-src
3939
become: yes
4040

41-
when: "{{ ansible_distribution == 'Debian' }}"
41+
when: ansible_distribution == 'Debian'
4242

4343
- name: debian | set license as accepted
4444
debconf: name='oracle-java{{ oracle_java_version }}-installer' question='shared/accepted-oracle-license-v1-1' value='true' vtype='select'
45-
when: "{{ licence_not_accepted|changed or licence_not_accepted|skipped }}"
45+
when: licence_not_accepted|changed or licence_not_accepted|skipped
4646
become: yes
4747

4848
- name: debian | ensure Java is installed

tasks/debug.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
- debug:
88
var="{{ item }}"
9-
when: "{{ item }} is defined"
9+
when: item is defined
1010
with_items:
1111
- oracle_java_cache_valid_time
1212
- oracle_java_home

0 commit comments

Comments
 (0)