Skip to content

Commit 234868e

Browse files
committed
ci: restore secrets: inheirt for pip-compile workflows
See comment for more details.
1 parent 05a1858 commit 234868e

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

.github/workflows/pip-compile-dev.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,9 @@ jobs:
6666
python-versions: "${{ matrix.python-versions }}"
6767
reset-branch: "${{ inputs.reset-branch || false }}"
6868
labels: "${{ inputs.labels || 'no_backport,tooling' }}"
69-
secrets:
70-
BOT_APP_ID: "${{ secrets.BOT_APP_ID }}"
71-
BOT_APP_KEY: "${{ secrets.BOT_APP_KEY }}"
69+
# Pass using inherit, as this seems to be the only possible way to access
70+
# secrets defined in an enviornment when using nested workflows.
71+
secrets: inherit # zizmor: ignore[secrets-inherit]
72+
# secrets:
73+
# BOT_APP_ID: "${{ secrets.BOT_APP_ID }}"
74+
# BOT_APP_KEY: "${{ secrets.BOT_APP_KEY }}"

.github/workflows/pip-compile-docs.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ jobs:
3636
reset-branch: "${{ inputs.reset-branch || false }}"
3737
labels: "${{ inputs.labels || 'doc builds,no_backport' }}"
3838
python-versions: "3.12"
39-
secrets:
40-
BOT_APP_ID: "${{ secrets.BOT_APP_ID }}"
41-
BOT_APP_KEY: "${{ secrets.BOT_APP_KEY }}"
39+
# Pass using inherit, as this seems to be the only possible way to access
40+
# secrets defined in an enviornment when using nested workflows.
41+
secrets: inherit # zizmor: ignore[secrets-inherit]
42+
# secrets:
43+
# BOT_APP_ID: "${{ secrets.BOT_APP_ID }}"
44+
# BOT_APP_KEY: "${{ secrets.BOT_APP_KEY }}"

0 commit comments

Comments
 (0)