Skip to content

Commit 190a4e4

Browse files
committed
Use base ref instead of base sha.
1 parent 6975aa3 commit 190a4e4

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

.github/workflows/_shared-docs-build-pr.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,12 @@ jobs:
287287
- name: Checkout BASE
288288
uses: actions/checkout@v3
289289
with:
290-
ref: ${{ github.event.pull_request.base.sha }}
290+
# Use base.ref, not base.sha, to make sure we do not get a checkout of the base at an earlier time
291+
# (when the PR's branch was branched off the PR's target branch), but right now. Without this there
292+
# will be a potentially large list of changes since the merge commit we check out for HEAD is based
293+
# on a far newer version. I'm not 100% sure whether this is also a good idea for the closed event
294+
# though...
295+
ref: ${{ github.event.pull_request.base.ref }}
291296
path: ${{ steps.vars.outputs.checkout-path }}
292297

293298
- name: Initialize the build environment (BASE)

0 commit comments

Comments
 (0)