Qt coding style. Need to change the _Window class name.

anshulgupta0803 · anshulgupta0803 · commit fe43c6574fc6 · 2017-07-30T03:38:36.000+05:30
diff --git a/app/components.cpp b/app/components.cpp
@@ -1,24 +1,26 @@
 #include "components.h"
 #include <poppler/qt5/poppler-qt5.h>
 
-Tabs::Tabs(QWidget* parent) :
+Tabs::Tabs(QWidget *parent) :
     QWidget(parent),
-    tabs(new QQuickWidget(QUrl("qrc:/app/Tabs.qml"), this)) {
+    tabs(new QQuickWidget(QUrl("qrc:/app/Tabs.qml"), this))
+{
 
     tabs->setResizeMode(QQuickWidget::SizeRootObjectToView);
     tabs->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);
     rootObject = tabs->rootObject();
 }
 
-Root::Root(QWidget* parent) :
+Root::Root(QWidget *parent) :
     QWidget(parent),
-    root(new QQuickWidget(QUrl("qrc:/app/Root.qml"), this)) {
+    root(new QQuickWidget(QUrl("qrc:/app/Root.qml"), this))
+{
 
     root->setResizeMode(QQuickWidget::SizeRootObjectToView);
     root->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);
     rootObject = root->rootObject();
 }
-Preview::Preview(QPrinter* _printer, QWidget* parent) :
+Preview::Preview(QPrinter *_printer, QWidget *parent) :
     QWidget(parent),
     printer(_printer),
     preview(new QPrintPreviewWidget(printer, this))
@@ -31,12 +33,13 @@ Preview::Preview(QPrinter* _printer, QWidget* parent) :
     printer->setFullPage(false);
 
     QObject::connect(preview,
-                     SIGNAL(paintRequested(QPrinter*)),
+                     SIGNAL(paintRequested(QPrinter *)),
                      this,
                      SLOT(print()));
 }
 
-void Preview::print() {
+void Preview::print()
+{
     QPainter painter(printer);
     painter.setRenderHints(QPainter::Antialiasing |
                            QPainter::TextAntialiasing |
@@ -45,7 +48,7 @@ void Preview::print() {
     QFile f;
     f.setFileName(":/app/test.pdf");
     f.open(QIODevice::ReadOnly);
-    QByteArray pdf=f.readAll();
+    QByteArray pdf = f.readAll();
 
     Poppler::Document *document = Poppler::Document::loadFromData(pdf);
     if (!document)
@@ -59,7 +62,8 @@ void Preview::print() {
     if (page == nullptr)
         qCritical("File '%s' is empty?", qUtf8Printable(":/app/test.pdf"));
 
-    QImage image = page->renderToImage(72.0, 72.0, 0, 0, page->pageSize().width(), page->pageSize().height());
+    QImage image = page->renderToImage(72.0, 72.0, 0, 0, page->pageSize().width(),
+                                       page->pageSize().height());
     if (image.isNull())
         qCritical("Error!");
 
@@ -70,26 +74,30 @@ void Preview::print() {
     painter.end();
 }
 
-void Preview::setZoom(qreal zoomFactor) {
-    if(previewPainted)
+void Preview::setZoom(qreal zoomFactor)
+{
+    if (previewPainted)
         preview->setZoomFactor(zoomFactor  * (widgetHeight / paperHeight));
     preview->updatePreview();
     currentZoomFactor = zoomFactor;
 }
 
-void Preview::showNextPage() {
+void Preview::showNextPage()
+{
     pageNumber = pageNumber < (pageCount - 1) ? pageNumber + 1 : pageNumber;
     preview->updatePreview();
 }
 
-void Preview::showPrevPage() {
+void Preview::showPrevPage()
+{
     pageNumber = pageNumber > 0 ? pageNumber - 1 : pageNumber;
     preview->updatePreview();
 }
 
-Controls::Controls(QWidget* parent) :
+Controls::Controls(QWidget *parent) :
     QWidget(parent),
-    controls(new QQuickWidget(QUrl("qrc:/app/Controls.qml"), this)) {
+    controls(new QQuickWidget(QUrl("qrc:/app/Controls.qml"), this))
+{
 
     controls->setResizeMode(QQuickWidget::SizeRootObjectToView);
     controls->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);
diff --git a/app/components.h b/app/components.h
@@ -7,32 +7,35 @@
 #include <QPainter>
 #include <QPrinter>
 
-class Tabs : public QWidget {
+class Tabs : public QWidget
+{
     Q_OBJECT
 public:
-    QQuickItem* rootObject;
-    Tabs(QWidget* parent = Q_NULLPTR);
+    QQuickItem *rootObject;
+    Tabs(QWidget *parent = Q_NULLPTR);
     ~Tabs() = default;
 
 private:
-    QQuickWidget* tabs;
+    QQuickWidget *tabs;
 };
 
-class Root : public QWidget {
+class Root : public QWidget
+{
     Q_OBJECT
 public:
-    QQuickItem* rootObject;
-    Root(QWidget* parent = Q_NULLPTR);
+    QQuickItem *rootObject;
+    Root(QWidget *parent = Q_NULLPTR);
     ~Root() = default;
 
 private:
-    QQuickWidget* root;
+    QQuickWidget *root;
 };
 
-class Preview : public QWidget {
+class Preview : public QWidget
+{
     Q_OBJECT
 public:
-    Preview(QPrinter* _printer, QWidget* parent = Q_NULLPTR);
+    Preview(QPrinter *_printer, QWidget *parent = Q_NULLPTR);
     ~Preview() = default;
     qreal widgetHeight = 0;
     qreal currentZoomFactor = 1;
@@ -44,23 +47,24 @@ public Q_SLOTS:
     void showPrevPage();
 
 private:
-    QPrinter* printer;
-    QPrintPreviewWidget* preview;
+    QPrinter *printer;
+    QPrintPreviewWidget *preview;
     int pageNumber = 0;
     int pageCount = 0;
     qreal paperHeight = 0;
     bool previewPainted = 0;
 };
 
-class Controls : public QWidget {
+class Controls : public QWidget
+{
     Q_OBJECT
 public:
-    QQuickItem* rootObject;
-    Controls(QWidget* parent = Q_NULLPTR);
+    QQuickItem *rootObject;
+    Controls(QWidget *parent = Q_NULLPTR);
     ~Controls() = default;
 
 private:
-    QQuickWidget* controls;
+    QQuickWidget *controls;
 };
 
 
diff --git a/app/preview.cpp b/app/preview.cpp
@@ -7,7 +7,8 @@
 
 /* The preview works by using poppler to convert a page of pdf to QImage */
 
-QImage QPdfPreview::requestImage(const QString &id, QSize *size, const QSize &requested_size) {
+QImage QPdfPreview::requestImage(const QString &id, QSize *size, const QSize &requested_size)
+{
     QString filename;
     QStringList imagesource = id.split("/");
     QStringList::iterator it;
@@ -28,13 +29,13 @@ QImage QPdfPreview::requestImage(const QString &id, QSize *size, const QSize &re
     QImage image;
 
     Poppler::Document *document = Poppler::Document::load(filename);
-    if (!document || document->isLocked()){
+    if (!document || document->isLocked()) {
         qCritical("File '%s' does not exist or is locked!", qUtf8Printable(filename));
         return image;
     }
 
     Poppler::Page *page = document->page(pageNumber);
-    if (page == nullptr){
+    if (page == nullptr) {
         qCritical("File '%s' is empty?", qUtf8Printable(filename));
         return image;
     }
@@ -57,17 +58,19 @@ QImage QPdfPreview::requestImage(const QString &id, QSize *size, const QSize &re
     return image;
 }
 
-int QPreviewData::get_number_of_pages(QString filename){
+int QPreviewData::get_number_of_pages(QString filename)
+{
     Poppler::Document *document = Poppler::Document::load(filename);
-    if (!document || document->isLocked()){
+    if (!document || document->isLocked()) {
         qCritical("File '%s' does not exist or is locked!", qUtf8Printable(filename));
         return 0;
     }
 
     return document->numPages();
 }
 
-QSizeF QPreviewData::getPageSize(QString page) {
+QSizeF QPreviewData::getPageSize(QString page)
+{
     /*
      * Need to come up with a different logic
      * This will return page size of A1 for A10 or
diff --git a/app/window.cpp b/app/window.cpp
@@ -46,7 +46,7 @@ _Window::_Window(QPrinter *printer, QWidget *parent) :
                      preview,
                      SLOT(showPrevPage()));
 
-    QObject* generalObject = root->rootObject->findChild<QObject*>("generalObject");
+    QObject *generalObject = root->rootObject->findChild<QObject *>("generalObject");
 
     QObject::connect(generalObject,
                      SIGNAL(newPrinterSelected(QString)),
@@ -89,40 +89,46 @@ _Window::_Window(QPrinter *printer, QWidget *parent) :
     init_backend();
 }
 
-CPrintDialog::CPrintDialog(QPrinter* printer, QWidget *parent) :
+CPrintDialog::CPrintDialog(QPrinter *printer, QWidget *parent) :
     QAbstractPrintDialog(printer, parent)
 {
     _window = new _Window(printer, parent);
     _window->show();
 }
 
-void _Window::tabBarIndexChanged(qint32 index) {
+void _Window::tabBarIndexChanged(qint32 index)
+{
     root->rootObject->setProperty("index", index);
 }
 
-void _Window::swipeViewIndexChanged(qint32 index) {
+void _Window::swipeViewIndexChanged(qint32 index)
+{
     tabs->rootObject->setProperty("index", index);
 }
 
-void _Window::cancelButtonClicked() {
+void _Window::cancelButtonClicked()
+{
     exit(0);
 }
 
-static int add_printer_callback(PrinterObj *p) {
+static int add_printer_callback(PrinterObj *p)
+{
     //qDebug() << "Printer" << p->name << "added!";
     _window->addPrinter(p->name);
 }
 
-static int remove_printer_callback(char *printer_name) {
+static int remove_printer_callback(char *printer_name)
+{
     qDebug() << "Printer" << printer_name << "removed!";
 }
 
-gpointer _Window::ui_add_printer(gpointer user_data) {
+gpointer _Window::ui_add_printer(gpointer user_data)
+{
     /*
      * Need this delay so that the FrontendObj
      * initialization completes
     */
-    bool* enabled = (bool*)user_data;
+    bool *enabled = (bool *)user_data;
     for (int i = 0; i < 100000000; i++);
     Command cmd;
     if (*enabled)
@@ -134,23 +140,25 @@ gpointer _Window::ui_add_printer(gpointer user_data) {
     g_hash_table_foreach(f->printer, ui_add_printer_aux, NULL);
 }
 
-void ui_add_printer_aux(gpointer key, gpointer value, gpointer user_data) {
-    _window->addPrinter((const char*)key);
+void ui_add_printer_aux(gpointer key, gpointer value, gpointer user_data)
+{
+    _window->addPrinter((const char *)key);
 }
 
-void _Window::addPrinter(const char *printer) {
-    QObject* obj = root->rootObject->findChild<QObject*>("generalObject");
+void _Window::addPrinter(const char *printer)
+{
+    QObject *obj = root->rootObject->findChild<QObject *>("generalObject");
     if (obj) {
         QMetaObject::invokeMethod(obj,
                                   "updateDestinationModel",
                                   Q_ARG(QVariant, printer));
-    }
-    else
+    } else
         qDebug() << "generalObject Not Found";
 }
 
-gpointer _Window::parse_commands(gpointer user_data) {
-    Command* cmd = (Command*)user_data;
+gpointer _Window::parse_commands(gpointer user_data)
+{
+    Command *cmd = (Command *)user_data;
     if (cmd->command.compare("hide-remote-cups") == 0)
         hide_remote_cups_printers(f);
     else if (cmd->command.compare("unhide-remote-cups") == 0)
@@ -172,7 +180,8 @@ gpointer _Window::parse_commands(gpointer user_data) {
     }
 }
 
-void _Window::init_backend() {
+void _Window::init_backend()
+{
     event_callback add_cb = (event_callback)add_printer_callback;
     event_callback rem_cb = (event_callback)remove_printer_callback;
     f = get_new_FrontendObj(NULL, add_cb, rem_cb);
@@ -182,25 +191,27 @@ void _Window::init_backend() {
     //ui_add_printer(&enabled);
 }
 
-void _Window::clearPrinters() {
-    QObject* obj = root->rootObject->findChild<QObject*>("generalObject");
+void _Window::clearPrinters()
+{
+    QObject *obj = root->rootObject->findChild<QObject *>("generalObject");
     if (obj) {
         QMetaObject::invokeMethod(obj,
                                   "clearDestinationModel");
-    }
-    else
+    } else
         qDebug() << "generalObject Not Found";
 }
 
-void _Window::newPrinterSelected(const QString &printer) {
+void _Window::newPrinterSelected(const QString &printer)
+{
     Command cmd;
     cmd.command = "get-all-options";
     cmd.arg1 = printer.toStdString();
     if (cmd.arg1.compare("") != 0)
         parse_commands(&cmd);
 }
 
-void _Window::remotePrintersToggled(const QString &enabled) {
+void _Window::remotePrintersToggled(const QString &enabled)
+{
     qDebug() << enabled;
 }
 
diff --git a/app/window.h b/app/window.h
diff --git a/common-print-dialog.pro b/common-print-dialog.pro
