Warn for bindings named same as variants when matching against a borrow

LeSeulArtichaut · LeSeulArtichaut · commit 4f6398541212 · 2020-01-02T00:50:51.000+01:00
diff --git a/src/librustc_mir/hair/pattern/check_match.rs b/src/librustc_mir/hair/pattern/check_match.rs
@@ -284,7 +284,7 @@ fn check_for_bindings_named_same_as_variants(cx: &MatchVisitor<'_, '_>, pat: &Pa
             if let Some(ty::BindByValue(hir::Mutability::Not)) =
                 cx.tables.extract_binding_mode(cx.tcx.sess, p.hir_id, p.span)
             {
-                let pat_ty = cx.tables.pat_ty(p);
+                let pat_ty = cx.tables.pat_ty(p).peel_refs();
                 if let ty::Adt(edef, _) = pat_ty.kind {
                     if edef.is_enum()
                         && edef.variants.iter().any(|variant| {

Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,7 @@ fn check_for_bindings_named_same_as_variants(cx: &MatchVisitor<'_, '_>, pat: &Pa`
`284`	`284`	`if let Some(ty::BindByValue(hir::Mutability::Not)) =`
`285`	`285`	`cx.tables.extract_binding_mode(cx.tcx.sess, p.hir_id, p.span)`
`286`	`286`	`{`
`287`		`- let pat_ty = cx.tables.pat_ty(p);`
	`287`	`+ let pat_ty = cx.tables.pat_ty(p).peel_refs();`
`288`	`288`	`if let ty::Adt(edef, _) = pat_ty.kind {`
`289`	`289`	`if edef.is_enum()`
`290`	`290`	`&& edef.variants.iter().any(\|variant\| {`