Improve test coverage of quantity methods with unit system parameter (#844)

Author: angularsen

CodeGen/Generators/UnitsNetGen/UnitTestBaseClassGenerator.cs

@@ -74,6 +74,7 @@ public override string Generate()
 using System.Globalization;
 using System.Linq;
 using System.Threading;
+using UnitsNet.Tests.TestsBase;
 using UnitsNet.Units;
 using Xunit;
 
@@ -87,7 +88,7 @@ namespace UnitsNet.Tests
     /// Test of {_quantity.Name}.
     /// </summary>
 // ReSharper disable once PartialTypeWithSinglePart
-    public abstract partial class {_quantity.Name}TestsBase
+    public abstract partial class {_quantity.Name}TestsBase : QuantityTestsBase
     {{");
             foreach (var unit in _quantity.Units) Writer.WL($@"
         protected abstract double {unit.PluralName}InOne{_baseUnit.SingularName} {{ get; }}");
@@ -127,13 +128,28 @@ public void Ctor_WithNaNValue_ThrowsArgumentException()
         {{
             Assert.Throws<ArgumentException>(() => new {_quantity.Name}(double.NaN, {_baseUnitFullName}));
         }}
+"); Writer.WL($@"
 
         [Fact]
         public void Ctor_NullAsUnitSystem_ThrowsArgumentNullException()
         {{
-            Assert.Throws<ArgumentNullException>(() => new {_quantity.Name}(value: 1.0, unitSystem: null));
+            Assert.Throws<ArgumentNullException>(() => new {_quantity.Name}(value: 1, unitSystem: null));
+        }}
+
+        [Fact]
+        public void Ctor_SIUnitSystem_ThrowsArgumentExceptionIfNotSupported()
+        {{
+            Func<object> TestCode = () => new {_quantity.Name}(value: 1, unitSystem: UnitSystem.SI);
+            if (SupportsSIUnitSystem)
+            {{
+                var quantity = ({_quantity.Name}) TestCode();
+                Assert.Equal(1, quantity.Value);
+            }}
+            else
+            {{
+                Assert.Throws<ArgumentException>(TestCode);
+            }}
         }}
-"); Writer.WL($@"
 
         [Fact]
         public void {_quantity.Name}_QuantityInfo_ReturnsQuantityInfoDescribingQuantity()
@@ -207,6 +223,23 @@ public void As()
             Writer.WL($@"
         }}
 
+        [Fact]
+        public void As_SIUnitSystem_ThrowsArgumentExceptionIfNotSupported()
+        {{
+            var quantity = new {_quantity.Name}(value: 1, unit: {_quantity.Name}.BaseUnit);
+            Func<object> AsWithSIUnitSystem = () => quantity.As(UnitSystem.SI);
+
+            if (SupportsSIUnitSystem)
+            {{
+                var value = (double) AsWithSIUnitSystem();
+                Assert.Equal(1, value);
+            }}
+            else
+            {{
+                Assert.Throws<ArgumentException>(AsWithSIUnitSystem);
+            }}
+        }}
+
         [Fact]
         public void ToUnit()
         {{
@@ -224,6 +257,14 @@ public void ToUnit()
             Writer.WL($@"
         }}
 
+        [Fact]
+        public void ToBaseUnit_ReturnsQuantityWithBaseUnit()
+        {{
+            var quantityInBaseUnit = {_quantity.Name}.From{_baseUnit.PluralName}(1).ToBaseUnit();
+            Assert.Equal({_quantity.Name}.BaseUnit, quantityInBaseUnit.Unit);");
+            Writer.WL($@"
+        }}
+
         [Fact]
         public void ConversionRoundTrip()
         {{
@@ -657,11 +698,10 @@ public void NegationOperator_ReturnsQuantity_WithNegatedValue(double value)
         {{
             var quantity = {_quantity.Name}.From{_baseUnit.PluralName}(value);
             Assert.Equal({_quantity.Name}.From{_baseUnit.PluralName}(-value), -quantity);
-        }}
-");
+        }}");
         }
 
-Writer.WL( $@"
+Writer.WL($@"
     }}
 }}" );
             return Writer.ToString();

Common/UnitDefinitions/Volume.json

@@ -29,6 +29,9 @@
       "FromUnitToBaseFunc": "x",
       "FromBaseToUnitFunc": "x",
       "Prefixes": [ "Hecto", "Kilo" ],
+      "BaseUnits": {
+        "L": "Meter"
+      },
       "Localization": [
         {
           "Culture": "en-US",

UnitsNet.Tests/CustomCode/AccelerationTests.cs

@@ -7,6 +7,8 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class AccelerationTests : AccelerationTestsBase
     {
+        protected override bool SupportsSIUnitSystem => true;
+
         protected override double KilometersPerSecondSquaredInOneMeterPerSecondSquared => 1E-3;
 
         protected override double MetersPerSecondSquaredInOneMeterPerSecondSquared => 1;

UnitsNet.Tests/CustomCode/AmountOfSubstanceTests.cs

@@ -28,6 +28,8 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class AmountOfSubstanceTests : AmountOfSubstanceTestsBase
     {
+        protected override bool SupportsSIUnitSystem => true;
+
         protected override double CentimolesInOneMole => 1e2;
         protected override double CentipoundMolesInOneMole => 0.002204622621848776 * 1e2;
         protected override double DecimolesInOneMole => 1e1;
@@ -43,7 +45,7 @@ public class AmountOfSubstanceTests : AmountOfSubstanceTestsBase
         protected override double NanopoundMolesInOneMole => 0.002204622621848776 * 1e9;
         protected override double PoundMolesInOneMole => 0.002204622621848776;
         protected override double MegamolesInOneMole => 1e-6;
-        
+
         [Fact]
         public void NumberOfParticlesInOneMoleEqualsAvogadroConstant()
         {
@@ -71,7 +73,7 @@ public void MassFromAmountOfSubstanceAndMolarMass(
         {
             AmountOfSubstance amountOfSubstance = new AmountOfSubstance(amountOfSubstanceValue, amountOfSubstanceUnit);
             MolarMass molarMass = new MolarMass(molarMassValue, molarMassUnit);
-            
+
             Mass mass = amountOfSubstance * molarMass;
 
             AssertEx.EqualTolerance(expectedMass, mass.As(expectedMassUnit), tolerence);

UnitsNet.Tests/CustomCode/AmplitudeRatioTests.cs

@@ -8,6 +8,7 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class AmplitudeRatioTests : AmplitudeRatioTestsBase
     {
+        protected override bool SupportsSIUnitSystem => false;
         protected override double DecibelMicrovoltsInOneDecibelVolt => 121;
 
         protected override double DecibelMillivoltsInOneDecibelVolt => 61;

UnitsNet.Tests/CustomCode/AngleTests.cs

@@ -8,6 +8,8 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class AngleTests : AngleTestsBase
     {
+        protected override bool SupportsSIUnitSystem => false;
+
         protected override double DegreesInOneDegree => 1;
 
         protected override double GradiansInOneDegree => 400 / 360.0;

UnitsNet.Tests/CustomCode/ApparentEnergyTests.cs

@@ -27,6 +27,8 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ApparentEnergyTests : ApparentEnergyTestsBase
     {
+        protected override bool SupportsSIUnitSystem => false;
+
         protected override double VoltampereHoursInOneVoltampereHour => 1;
 
         protected override double KilovoltampereHoursInOneVoltampereHour => 1E-3;

UnitsNet.Tests/CustomCode/ApparentPowerTests.cs

@@ -27,6 +27,8 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ApparentPowerTests : ApparentPowerTestsBase
     {
+        protected override bool SupportsSIUnitSystem => false;
+
         protected override double VoltamperesInOneVoltampere => 1;
 
         protected override double KilovoltamperesInOneVoltampere => 1E-3;

UnitsNet.Tests/CustomCode/AreaDensityTests.cs

@@ -27,6 +27,8 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class AreaDensityTests : AreaDensityTestsBase
     {
+        protected override bool SupportsSIUnitSystem => true;
+
         protected override double KilogramsPerSquareMeterInOneKilogramPerSquareMeter => 1;
     }
 }

UnitsNet.Tests/CustomCode/AreaMomentOfInertiaTests.cs

@@ -28,6 +28,8 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class AreaMomentOfInertiaTests : AreaMomentOfInertiaTestsBase
     {
+        protected override bool SupportsSIUnitSystem => true;
+
         protected override double CentimetersToTheFourthInOneMeterToTheFourth => 1e8;
 
         protected override double DecimetersToTheFourthInOneMeterToTheFourth => 1e4;