Remove pragma statements on obsolete warns (#872)

Author: angularsen

CodeGen/CodeGen.csproj

@@ -5,6 +5,8 @@
     <TargetFramework>netcoreapp2.1</TargetFramework>
     <LangVersion>latest</LangVersion>
     <Nullable>enable</Nullable>
+    <!-- Allow compile with various nullability warnings until fixed. -->
+    <WarningsNotAsErrors>8600,8601,8603,8604,8618,8619,8625</WarningsNotAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

CodeGen/Generators/UnitsNetGen/UnitTestBaseClassGenerator.cs

@@ -166,10 +166,8 @@ public void Ctor_SIUnitSystem_ThrowsArgumentExceptionIfNotSupported()
             var unitNames = units.Select(x => x.ToString());
 
             // Obsolete members
-#pragma warning disable 618
             Assert.Equal(units, quantityInfo.Units);
             Assert.Equal(unitNames, quantityInfo.UnitNames);
-#pragma warning restore 618
         }}
 
         [Fact]
@@ -515,7 +513,6 @@ public void ToString_SFormatAndCulture_FormatsNumberWithGivenDigitsAfterRadixFor
             Assert.Equal(""0.1235 {_baseUnitEnglishAbbreviation}"", new {_quantity.Name}(0.123456{_numberSuffix}, {_baseUnitFullName}).ToString(""s4"", culture));
         }}
 
-        #pragma warning disable 612, 618
 
         [Fact]
         public void ToString_NullFormat_ThrowsArgumentNullException()
@@ -538,7 +535,6 @@ public void ToString_NullProvider_EqualsCurrentUICulture()
             Assert.Equal(quantity.ToString(CultureInfo.CurrentUICulture, ""g""), quantity.ToString(null, ""g""));
         }}
 
-        #pragma warning restore 612, 618
 
         [Fact]
         public void Convert_ToBool_ThrowsInvalidCastException()

Directory.Build.props

@@ -9,4 +9,11 @@
   <Target Name="VSTestIfTestProject">
     <CallTarget Targets="VSTest" Condition="'$(IsTestProject)' == 'true'" />
   </Target>
+
+  <!-- Warnings and errors -->
+  <PropertyGroup>
+    <!-- Warning instead of compile error on obsolete errors.-->
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <WarningsNotAsErrors>612,618</WarningsNotAsErrors>
+  </PropertyGroup>
 </Project>

UnitsNet.Benchmark/UnitsNet.Benchmark.csproj

@@ -10,7 +10,6 @@
     <Product>UnitsNet.Benchmark</Product>
     <LangVersion>latest</LangVersion>
     <RootNamespace>UnitsNet</RootNamespace>
-    <MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

UnitsNet.NumberExtensions.Tests/UnitsNet.NumberExtensions.Tests.csproj

@@ -4,7 +4,6 @@
     <TargetFrameworks>netcoreapp2.1</TargetFrameworks>
     <RootNamespace>UnitsNet.NumberExtensions.Tests</RootNamespace>
     <LangVersion>latest</LangVersion>
-    <MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>
     <IsTestProject>true</IsTestProject>
   </PropertyGroup>
 

UnitsNet.NumberExtensions/UnitsNet.NumberExtensions.csproj

@@ -23,7 +23,6 @@
     <Nullable>enable</Nullable>
     <RootNamespace>UnitsNet</RootNamespace>
     <TargetFrameworks>netstandard2.0;net40</TargetFrameworks>
-    <MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

UnitsNet.Serialization.JsonNet.CompatibilityTests/UnitsNet.Serialization.JsonNet.CompatibilityTests.csproj

@@ -4,7 +4,6 @@
     <TargetFrameworks>netcoreapp2.1</TargetFrameworks>
     <RootNamespace>UnitsNet.Serialization.JsonNet.CompatibilityTests</RootNamespace>
     <LangVersion>latest</LangVersion>
-    <MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>
     <IsTestProject>true</IsTestProject>
   </PropertyGroup>
 

UnitsNet.Serialization.JsonNet.Tests/UnitsNet.Serialization.JsonNet.Tests.csproj

@@ -4,7 +4,6 @@
     <TargetFrameworks>netcoreapp2.1</TargetFrameworks>
     <RootNamespace>UnitsNet.Serialization.JsonNet.Tests</RootNamespace>
     <LangVersion>latest</LangVersion>
-    <MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>
     <IsTestProject>true</IsTestProject>
   </PropertyGroup>
 

UnitsNet.Serialization.JsonNet/UnitsNet.Serialization.JsonNet.csproj

@@ -24,7 +24,6 @@
     <LangVersion>latest</LangVersion>
     <RootNamespace>UnitsNet.Serialization.JsonNet</RootNamespace>
     <TargetFrameworks>netstandard2.0;net40</TargetFrameworks>
-    <MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>
   </PropertyGroup>
 
   <!-- SourceLink -->