Remove SupportsSIUnitSystem => true property overrides (#1537)

Fixes #1463

---------

Co-authored-by: Andreas Gullberg Larsen <andreas.larsen84@gmail.com>

Author: lipchev

UnitsNet.Tests/CustomCode/AbsorbedDoseOfIonizingRadiationTests.cs

@@ -24,7 +24,6 @@ namespace UnitsNet.Tests.CustomCode
     public class AbsorbedDoseOfIonizingRadiationTests : AbsorbedDoseOfIonizingRadiationTestsBase
     {
         // Override properties in base class here
-        protected override bool SupportsSIUnitSystem => true;
         protected override double CentigraysInOneGray => 100;
         protected override double FemtograysInOneGray => 1E+15;
         protected override double GigagraysInOneGray => 1E-9;

UnitsNet.Tests/CustomCode/AccelerationTests.cs

@@ -7,8 +7,6 @@ namespace UnitsNet.Tests
 {
     public class AccelerationTests : AccelerationTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
-
         protected override double KilometersPerSecondSquaredInOneMeterPerSecondSquared => 1E-3;
 
         protected override double MetersPerSecondSquaredInOneMeterPerSecondSquared => 1;

UnitsNet.Tests/CustomCode/AmountOfSubstanceTests.cs

@@ -28,8 +28,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class AmountOfSubstanceTests : AmountOfSubstanceTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
-
         protected override double CentimolesInOneMole => 1e2;
         protected override double CentipoundMolesInOneMole => 0.002204622621848776 * 1e2;
         protected override double DecimolesInOneMole => 1e1;
@@ -71,9 +69,10 @@ public void NumberOfParticlesInTwoMolesIsDoubleAvogadroConstant()
         }
 
         [Theory]
+        // 10 Moles of Oxygen weight 10 times as much as 1 Mole of Oxygen (MolarMass)
         [InlineData(10, AmountOfSubstanceUnit.Mole,
-            KnownQuantities.MolarMassOfOxygen, MolarMassUnit.GramPerMole,
-            10 * KnownQuantities.MolarMassOfOxygen, MassUnit.Gram)] // 10 Moles of Oxygen weight 10 times as much as 1 Mole of Oxygen (MolarMass)
+                    KnownQuantities.MolarMassOfOxygen, MolarMassUnit.GramPerMole,
+                    10 * KnownQuantities.MolarMassOfOxygen, MassUnit.Gram)]
         public void MassFromAmountOfSubstanceAndMolarMass(
             double amountOfSubstanceValue, AmountOfSubstanceUnit amountOfSubstanceUnit,
             double molarMassValue, MolarMassUnit molarMassUnit,
@@ -88,10 +87,11 @@ public void MassFromAmountOfSubstanceAndMolarMass(
         }
 
         [Theory]
+        // molarity(HCl) = 5g / (1.2L * 36.46) = 0.114 mol/l = 0.114 M
         [InlineData(5, MassUnit.Gram,
-            KnownQuantities.MolarMassHClInGramsPerMole, MolarMassUnit.GramPerMole,
-            1.2, VolumeUnit.Liter,
-            0.1142805, MolarityUnit.MolePerLiter)] // molarity(HCl) = 5g / (1.2L * 36.46) = 0.114 mol/l = 0.114 M
+                    KnownQuantities.MolarMassHClInGramsPerMole, MolarMassUnit.GramPerMole,
+                    1.2, VolumeUnit.Liter,
+                    0.1142805, MolarityUnit.MolePerLiter)]
         public void MolarityFromComponentMassAndSolutionVolume(
             double componentMassValue, MassUnit componentMassUnit,
             double componentMolarMassValue, MolarMassUnit componentMolarMassUnit,
@@ -109,10 +109,11 @@ public void MolarityFromComponentMassAndSolutionVolume(
         }
 
         [Theory]
+        // 1.2 L of solution required for obtaining 0.1142805 Moles/L from 5g HCl
         [InlineData(5, MassUnit.Gram,
-            KnownQuantities.MolarMassHClInGramsPerMole, MolarMassUnit.GramPerMole,
-            0.1142805, MolarityUnit.MolePerLiter,
-            1.2, VolumeUnit.Liter)] // 1.2 L of solution required for obtaining 0.1142805 Moles/L from 5g HCl
+                    KnownQuantities.MolarMassHClInGramsPerMole, MolarMassUnit.GramPerMole,
+                    0.1142805, MolarityUnit.MolePerLiter,
+                    1.2, VolumeUnit.Liter)]
         public void VolumeSolutionFromComponentMassAndDesiredConcentration(
             double componentMassValue, MassUnit componentMassUnit,
             double componentMolarMassValue, MolarMassUnit componentMolarMassUnit,

UnitsNet.Tests/CustomCode/AmplitudeRatioTests.cs

@@ -8,7 +8,6 @@ namespace UnitsNet.Tests
 {
     public class AmplitudeRatioTests : AmplitudeRatioTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
         protected override double DecibelMicrovoltsInOneDecibelVolt => 121;
 
         protected override double DecibelMillivoltsInOneDecibelVolt => 61;
@@ -51,7 +50,7 @@ public void ExpectVoltageConvertedToAmplitudeRatioCorrectly(double voltage, doub
             // Amplitude ratio increases linearly by 20 dBV with power-of-10 increases of voltage.
             ElectricPotential v = ElectricPotential.FromVolts(voltage);
 
-            double actual = AmplitudeRatio.FromElectricPotential(v).DecibelVolts;
+            var actual = AmplitudeRatio.FromElectricPotential(v).DecibelVolts;
             Assert.Equal(expected, actual);
         }
 
@@ -65,8 +64,8 @@ public void ExpectAmplitudeRatioConvertedToVoltageCorrectly(double amplitudeRati
         {
             // Voltage increases by powers of 10 for every 20 dBV increase in amplitude ratio.
             AmplitudeRatio ar = AmplitudeRatio.FromDecibelVolts(amplitudeRatio);
-
-            double actual = ar.ToElectricPotential().Volts;
+            
+            var actual = ar.ToElectricPotential().Volts;
             Assert.Equal(expected, actual);
         }
 
@@ -80,8 +79,8 @@ public void ExpectAmplitudeRatioConvertedToVoltageCorrectly(double amplitudeRati
         public void AmplitudeRatioToPowerRatio_50OhmImpedance(double dBmV, double expected)
         {
             AmplitudeRatio ampRatio = AmplitudeRatio.FromDecibelMillivolts(dBmV);
-
-            double actual = Math.Round(ampRatio.ToPowerRatio(ElectricResistance.FromOhms(50)).DecibelMilliwatts, 2);
+            
+            var actual = Math.Round(ampRatio.ToPowerRatio(ElectricResistance.FromOhms(50)).DecibelMilliwatts, 2);
             Assert.Equal(expected, actual);
         }
 
@@ -93,8 +92,8 @@ public void AmplitudeRatioToPowerRatio_50OhmImpedance(double dBmV, double expect
         public void AmplitudeRatioToPowerRatio_75OhmImpedance(double dBmV, double expected)
         {
             AmplitudeRatio ampRatio = AmplitudeRatio.FromDecibelMillivolts(dBmV);
-
-            double actual = Math.Round(ampRatio.ToPowerRatio(ElectricResistance.FromOhms(75)).DecibelMilliwatts, 2);
+            
+            var actual = Math.Round(ampRatio.ToPowerRatio(ElectricResistance.FromOhms(75)).DecibelMilliwatts, 2);
             Assert.Equal(expected, actual);
         }
     }

UnitsNet.Tests/CustomCode/AngleTests.cs

@@ -8,7 +8,6 @@ namespace UnitsNet.Tests
 {
     public class AngleTests : AngleTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
         protected override double RadiansInOneRadian => 1;
         protected override double DeciradiansInOneRadian => 1E1;
         protected override double CentiradiansInOneRadian => 1E2;

UnitsNet.Tests/CustomCode/AreaDensityTests.cs

@@ -28,8 +28,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class AreaDensityTests : AreaDensityTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
-
         protected override double GramsPerSquareMeterInOneKilogramPerSquareMeter => 1000;
 
         protected override double KilogramsPerSquareMeterInOneKilogramPerSquareMeter => 1;

UnitsNet.Tests/CustomCode/AreaMomentOfInertiaTests.cs

@@ -28,8 +28,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class AreaMomentOfInertiaTests : AreaMomentOfInertiaTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
-
         protected override double CentimetersToTheFourthInOneMeterToTheFourth => 1e8;
 
         protected override double DecimetersToTheFourthInOneMeterToTheFourth => 1e4;

UnitsNet.Tests/CustomCode/AreaTests.cs

@@ -8,8 +8,6 @@ namespace UnitsNet.Tests
 {
     public class AreaTests : AreaTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
-
         protected override double SquareKilometersInOneSquareMeter => 1E-6;
 
         protected override double SquareMetersInOneSquareMeter => 1;
@@ -71,7 +69,7 @@ public void AreaTimesDensityEqualsLinearDensity()
         [InlineData(0.5, 0.19634954084936208)]
         [InlineData(1, 0.7853981633974483)]
         [InlineData(2, 3.141592653589793)]
-        public void AreaFromCicleDiameterCalculatedCorrectly(double diameterMeters, double expected)
+        public void AreaFromCircleDiameterCalculatedCorrectly(double diameterMeters, double expected)
         {
             Length diameter = Length.FromMeters(diameterMeters);
 
@@ -85,7 +83,7 @@ public void AreaFromCicleDiameterCalculatedCorrectly(double diameterMeters, doub
         [InlineData(0.5, 0.7853981633974483)]
         [InlineData(1, 3.141592653589793)]
         [InlineData(2, 12.566370614359173)]
-        public void AreaFromCicleRadiusCalculatedCorrectly(double radiusMeters, double expected)
+        public void AreaFromCircleRadiusCalculatedCorrectly(double radiusMeters, double expected)
         {
             Length radius = Length.FromMeters(radiusMeters);
 

UnitsNet.Tests/CustomCode/BitRateTests.cs

@@ -27,8 +27,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class BitRateTests : BitRateTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
-
         protected override double BitsPerSecondInOneBitPerSecond => 1;
         protected override double BytesPerSecondInOneBitPerSecond => 1.25E-1;
 

UnitsNet.Tests/CustomCode/BrakeSpecificFuelConsumptionTests.cs

@@ -8,8 +8,6 @@ namespace UnitsNet.Tests
 {
     public class BrakeSpecificFuelConsumptionTests : BrakeSpecificFuelConsumptionTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
-
         protected override double GramsPerKiloWattHourInOneKilogramPerJoule => 3600000000;
 
         protected override double KilogramsPerJouleInOneKilogramPerJoule => 1.0;
@@ -26,15 +24,15 @@ public void PowerTimesBrakeSpecificFuelConsumptionEqualsMassFlow()
         [Fact]
         public void DoubleDividedByBrakeSpecificFuelConsumptionEqualsSpecificEnergy()
         {
-            SpecificEnergy massFlow = 2.0 / BrakeSpecificFuelConsumption.FromKilogramsPerJoule(4.0);
+            SpecificEnergy massFlow = 2 / BrakeSpecificFuelConsumption.FromKilogramsPerJoule(4);
             Assert.Equal(SpecificEnergy.FromJoulesPerKilogram(0.5), massFlow);
         }
 
         [Fact]
         public void BrakeSpecificFuelConsumptionTimesSpecificEnergyEqualsEnergy()
         {
-            double value = BrakeSpecificFuelConsumption.FromKilogramsPerJoule(20.0) * SpecificEnergy.FromJoulesPerKilogram(10.0);
-            Assert.Equal(200.0, value);
+            var value = BrakeSpecificFuelConsumption.FromKilogramsPerJoule(20) * SpecificEnergy.FromJoulesPerKilogram(10);
+            Assert.Equal(200, value);
         }
     }
 }