style(eslint): enable space-in-parens rule (#11589)

Author: Splaktar

.eslintrc.json

@@ -222,7 +222,7 @@
         "sort-vars": "off",
         "space-before-blocks": "off",
         "space-before-function-paren": "off",
-        "space-in-parens": "off",
+        "space-in-parens": ["error", "never"],
         "space-infix-ops": "off",
         "space-unary-ops": "off",
         "spaced-comment": "off",

config/ngModuleData.js

@@ -42,6 +42,6 @@ function buildScanner(pattern) {
 }
 
 module.exports = {
-  material : buildScanner( MATERIAL_ONLY ),
-  any      : buildScanner( ANY )
+  material : buildScanner(MATERIAL_ONLY),
+  any      : buildScanner(ANY)
 };

docs/app/js/app.js

@@ -333,11 +333,11 @@ function(SERVICES, COMPONENTS, DEMOS, PAGES, $location, $rootScope, $http, $wind
     }]
   });
 
-  sections.push( {
+  sections.push({
         name: 'Contributors',
         url: 'contributors',
         type: 'link'
-      } );
+      });
 
   sections.push({
     name: 'License',
@@ -660,7 +660,7 @@ function($scope, COMPONENTS, BUILDCONFIG, $mdSidenav, $timeout, $mdDialog, menu,
 
   function goHome($event) {
     menu.selectPage(null, null);
-    $location.path( '/' );
+    $location.path('/');
   }
 
   function openPage() {
@@ -723,7 +723,7 @@ function($scope, $rootScope) {
   '$rootScope', '$http',
 function($rootScope, $http) {
   $rootScope.currentComponent = $rootScope.currentDoc = null;
-  if ( !$rootScope.contributors ) {
+  if (!$rootScope.contributors) {
     $http
       .get('./contributors.json')
       .then(function(response) {

docs/app/js/codepen.js

@@ -86,7 +86,7 @@
         head: LINK_FONTS_ROBOTO,
 
         js: processJs(files.js),
-        css: mergeFiles( files.css ).join(' '),
+        css: mergeFiles(files.css).join(' '),
 
         js_external: externalScripts.concat([ASSET_CACHE_JS, CORE_JS]).join(';'),
         css_external: [CORE_CSS, DOC_CSS].join(';')

docs/config/index.js

@@ -48,7 +48,7 @@ module.exports = new Package('angular-md', [
     docTypes: ['content'],
     getPath: function(doc) {
       let docPath = path.dirname(doc.fileInfo.relativePath);
-      if ( doc.fileInfo.baseName !== 'index' ) {
+      if (doc.fileInfo.baseName !== 'index') {
         docPath = path.join(docPath, doc.fileInfo.baseName);
       }
       return docPath;

docs/config/processors/buildConfig.js

@@ -18,7 +18,7 @@ module.exports = function buildConfigProcessor() {
     });
 
     return q.all([ getSHA(), getCommitDate() ])
-            .then( function(){
+            .then(function(){
               return docs;
           });
   }

gulp/tasks/build-scss.js

@@ -44,9 +44,9 @@ exports.task = function() {
   );
 
   streams.push(
-      gulp.src( config.cssIEPaths.slice() )         // append raw CSS for IE Fixes
-        .pipe( concat('angular-material.layouts.ie_fixes.css') )
-        .pipe( gulp.dest(layoutDest) )
+      gulp.src(config.cssIEPaths.slice())         // append raw CSS for IE Fixes
+        .pipe(concat('angular-material.layouts.ie_fixes.css'))
+        .pipe(gulp.dest(layoutDest))
   );
 
   // Generate standalone SCSS (and CSS) file for Layouts API
@@ -101,7 +101,7 @@ exports.task = function() {
 
   function getPaths () {
     const paths = config.scssBaseFiles.slice();
-    if ( modules ) {
+    if (modules) {
       paths.push.apply(paths, modules.split(',').map(function (module) {
         return 'src/components/' + module + '/*.scss';
       }));

gulp/tasks/karma-fast.js

@@ -17,12 +17,12 @@ const args = util.args;
 exports.task = function (done) {
   let errorCount = 0;
 
-  if ( args.browsers ) {
+  if (args.browsers) {
     karmaConfig.browsers = args.browsers.trim().split(',');
   }
   // NOTE: `karma-fast` does NOT test Firefox by default.
 
-  if ( args.reporters ) {
+  if (args.reporters) {
     karmaConfig.reporters = args.reporters.trim().split(',');
   }
 

gulp/tasks/karma.js

@@ -13,9 +13,9 @@ const karmaConfig = {
 exports.dependencies = ['build'];
 
 exports.task = function (done) {
-  if ( args.browsers )  karmaConfig.browsers = args.browsers.trim().split(',');
-  if ( args.reporters ) karmaConfig.reporters = args.reporters.trim().split(',');
-  if ( args.config )    karmaConfig.configFile = ROOT + '/' + args.config.trim();
+  if (args.browsers)  karmaConfig.browsers = args.browsers.trim().split(',');
+  if (args.reporters) karmaConfig.reporters = args.reporters.trim().split(',');
+  if (args.config)    karmaConfig.configFile = ROOT + '/' + args.config.trim();
 
   gutil.log(gutil.colors.blue('Running unit tests on unminified source.'));
 

gulp/util.js

@@ -45,14 +45,14 @@ function buildJs () {
 
   gutil.log("building js files...");
 
-  const jsBuildStream = gulp.src( jsFiles )
+  const jsBuildStream = gulp.src(jsFiles)
       .pipe(filterNonCodeFiles())
       .pipe(utils.buildNgMaterialDefinition())
       .pipe(plumber())
       .pipe(ngAnnotate())
       .pipe(utils.addJsWrapper(true));
 
-  const jsProcess = series(jsBuildStream, themeBuildStream() )
+  const jsProcess = series(jsBuildStream, themeBuildStream())
       .pipe(concat('angular-material.js'))
       .pipe(BUILD_MODE.transform())
       .pipe(insert.prepend(config.banner))
@@ -88,7 +88,7 @@ function minifyCss(extraOptions) {
  */
 function buildModule(module, opts) {
   opts = opts || {};
-  if ( module.indexOf(".") < 0) {
+  if (module.indexOf(".") < 0) {
     module = "material.components." + module;
   }
   gutil.log('Building ' + module + (opts.isRelease && ' minified' || '') + ' ...');
@@ -224,7 +224,7 @@ function filterNonCodeFiles() {
 
 // builds the theming related css and provides it as a JS const for angular
 function themeBuildStream() {
-  return gulp.src( config.themeBaseFiles.concat(path.join(config.paths, '*-theme.scss')) )
+  return gulp.src(config.themeBaseFiles.concat(path.join(config.paths, '*-theme.scss')))
       .pipe(concat('default-theme.scss'))
       .pipe(utils.hoistScssVariables())
       .pipe(sass())