Skip to content

Commit bd37867

Browse files
committed
refactor(aria/menu): rename isVisible to visible
(cherry picked from commit 1629175)
1 parent a9ce6e4 commit bd37867

File tree

4 files changed

+122
-122
lines changed

4 files changed

+122
-122
lines changed

src/aria/menu/menu.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ export class MenuTrigger<V> {
148148
'[attr.id]': '_pattern.id()',
149149
'[attr.aria-disabled]': '_pattern.disabled()',
150150
'[attr.tabindex]': 'tabIndex()',
151-
'[attr.data-visible]': 'isVisible()',
151+
'[attr.data-visible]': 'visible()',
152152
'(keydown)': '_pattern.onKeydown($event)',
153153
'(mouseover)': '_pattern.onMouseOver($event)',
154154
'(mouseout)': '_pattern.onMouseOut($event)',
@@ -212,7 +212,7 @@ export class Menu<V> {
212212
readonly items = () => this._items().map(i => i._pattern);
213213

214214
/** Whether the menu is visible. */
215-
readonly isVisible = computed(() => this._pattern.isVisible());
215+
readonly visible = computed(() => this._pattern.visible());
216216

217217
/** The tab index of the menu. */
218218
readonly tabIndex = computed(() => this._pattern.tabIndex());
@@ -243,7 +243,7 @@ export class Menu<V> {
243243
this._deferredContentAware?.contentVisible.set(true);
244244
} else {
245245
this._deferredContentAware?.contentVisible.set(
246-
this._pattern.isVisible() || !!this.parent()?._pattern.hasBeenFocused(),
246+
this._pattern.visible() || !!this.parent()?._pattern.hasBeenFocused(),
247247
);
248248
}
249249
});
@@ -253,7 +253,7 @@ export class Menu<V> {
253253
// update the display property. The result is focus() being called on an element that is not
254254
// focusable. This simply retries focusing the element after render.
255255
afterRenderEffect(() => {
256-
if (this._pattern.isVisible()) {
256+
if (this._pattern.visible()) {
257257
const activeItem = untracked(() => this._pattern.inputs.activeItem());
258258
this._pattern.listBehavior.goto(activeItem!);
259259
}

0 commit comments

Comments
 (0)