test: enable @typescript-eslint/no-unnecessary-type-assertion lint rule

clydin · clydin · commit fa9bce0e9ae5 · 2024-06-25T16:57:03.000-04:00
The `@typescript-eslint/no-unnecessary-type-assertion` rule is now enabled and all failures
have been addressed within the code.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -107,7 +107,6 @@
     "@typescript-eslint/no-empty-function": "off",
     "@typescript-eslint/no-implied-eval": "off",
     "@typescript-eslint/no-var-requires": "off",
-    "@typescript-eslint/no-unnecessary-type-assertion": "off",
     "@typescript-eslint/no-unsafe-argument": "off",
     "@typescript-eslint/no-unsafe-assignment": "off",
     "@typescript-eslint/no-unsafe-call": "off",
diff --git a/modules/testing/builder/src/builder-harness.ts b/modules/testing/builder/src/builder-harness.ts
@@ -204,7 +204,7 @@ export class BuilderHarness<T> {
           // Harness builder targets currently do not support configurations
           return {};
         } else {
-          return (this.builderTargets.get(target)?.options || {}) as json.JsonObject;
+          return this.builderTargets.get(target)?.options || {};
         }
       },
       hasTarget: async (project, target) => {
diff --git a/packages/angular/build/src/tools/angular/transformers/jit-resource-transformer.ts b/packages/angular/build/src/tools/angular/transformers/jit-resource-transformer.ts
@@ -99,7 +99,7 @@ function visitDecorator(
     return node;
   }
 
-  const objectExpression = args[0] as ts.ObjectLiteralExpression;
+  const objectExpression = args[0];
   const styleReplacements: ts.Expression[] = [];
 
   // visit all properties
diff --git a/packages/angular/build/src/utils/i18n-options.ts b/packages/angular/build/src/utils/i18n-options.ts
@@ -39,7 +39,7 @@ function normalizeTranslationFileOption(
   }
 
   if (Array.isArray(option) && option.every((element) => typeof element === 'string')) {
-    return option as string[];
+    return option;
   }
 
   let errorMessage = `Project i18n locales translation field value for '${locale}' is malformed. `;
diff --git a/packages/angular_devkit/architect/src/jobs/create-job-handler.ts b/packages/angular_devkit/architect/src/jobs/create-job-handler.ts
@@ -164,10 +164,10 @@ export function createJobHandler<A extends JsonValue, I extends JsonValue, O ext
       if (isPromise(result)) {
         result = from(result);
       } else if (!isObservable(result)) {
-        result = of(result as O);
+        result = of(result);
       }
 
-      subscription = (result as Observable<O>).subscribe(
+      subscription = result.subscribe(
         (value: O) => subject.next({ kind: JobOutboundMessageKind.Output, description, value }),
         (error) => subject.error(error),
         () => complete(),
diff --git a/packages/angular_devkit/architect/src/jobs/simple-scheduler.ts b/packages/angular_devkit/architect/src/jobs/simple-scheduler.ts
@@ -418,7 +418,7 @@ export class SimpleScheduler<
 
     const output = outboundBus.pipe(
       filter((x) => x.kind == JobOutboundMessageKind.Output),
-      map((x) => (x as JobOutboundMessageOutput<O>).value),
+      map((x) => x.value),
       shareReplay(1),
     );
 
diff --git a/packages/angular_devkit/architect/src/jobs/simple-scheduler_spec.ts b/packages/angular_devkit/architect/src/jobs/simple-scheduler_spec.ts
@@ -461,6 +461,7 @@ describe('SimpleScheduler', () => {
 
       const job = scheduler.schedule('job', 0);
       let sideValue = '';
+      // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
       const c = job.getChannel('any') as Observable<string>;
       c.subscribe((x) => (sideValue = x));
 
@@ -486,6 +487,7 @@ describe('SimpleScheduler', () => {
 
       const job = scheduler.schedule('job', 0);
       let sideValue = '';
+      // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
       const c = job.getChannel('any', { type: 'number' }) as Observable<string>;
       expect(c).toBeDefined(null);
 
diff --git a/packages/angular_devkit/build_angular/src/builders/dev-server/webpack-server.ts b/packages/angular_devkit/build_angular/src/builders/dev-server/webpack-server.ts
@@ -97,6 +97,7 @@ export function serveWebpackBrowser(
       logger.warn(`Warning: 'outputHashing' option is disabled when using the dev-server.`);
     }
 
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
     const browserOptions = (await context.validateOptions(
       {
         ...rawBrowserOptions,
diff --git a/packages/angular_devkit/build_angular/src/tools/babel/webpack-loader.ts b/packages/angular_devkit/build_angular/src/tools/babel/webpack-loader.ts
@@ -114,7 +114,7 @@ export default custom<ApplicationPresetOptions>(() => {
         }
 
         customOptions.i18n = {
-          ...(i18n as NonNullable<ApplicationPresetOptions['i18n']>),
+          ...i18n,
           pluginCreators: i18nPluginCreators,
         };
 
diff --git a/packages/angular_devkit/core/node/host.ts b/packages/angular_devkit/core/node/host.ts
@@ -208,13 +208,11 @@ export class NodeJsSyncHost implements virtualFs.Host<Stats> {
   }
 
   isDirectory(path: Path): Observable<boolean> {
-    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-    return this.stat(path)!.pipe(map((stat) => stat.isDirectory()));
+    return this.stat(path).pipe(map((stat) => stat.isDirectory()));
   }
 
   isFile(path: Path): Observable<boolean> {
-    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-    return this.stat(path)!.pipe(map((stat) => stat.isFile()));
+    return this.stat(path).pipe(map((stat) => stat.isFile()));
   }
 
   // Some hosts may not support stat.
diff --git a/packages/angular_devkit/schematics/src/rules/call.ts b/packages/angular_devkit/schematics/src/rules/call.ts
@@ -55,7 +55,7 @@ export function callSource(source: Source, context: SchematicContext): Observabl
     }
 
     if (result && TreeSymbol in result) {
-      return result as Tree;
+      return result;
     }
 
     throw new InvalidSourceResultException(result);
@@ -91,7 +91,7 @@ async function callRuleAsync(rule: Rule, tree: Tree, context: SchematicContext):
   }
 
   if (result && TreeSymbol in result) {
-    return result as Tree;
+    return result;
   }
 
   throw new InvalidRuleResultException(result);
diff --git a/packages/angular_devkit/schematics/src/rules/template.ts b/packages/angular_devkit/schematics/src/rules/template.ts
@@ -138,7 +138,7 @@ export function applyPathTemplate<T extends PathTemplateData>(
           }
 
           // Coerce to string.
-          return '' + (data[pipe] as PathTemplatePipeFunction)(acc);
+          return '' + data[pipe](acc);
         }, '' + replacement);
       }
 
diff --git a/packages/angular_devkit/schematics/src/tree/common_spec.ts b/packages/angular_devkit/schematics/src/tree/common_spec.ts
@@ -58,8 +58,7 @@ export function testTreeVisit({ createTree, sets }: VisitTestSpec) {
           allPaths.push(path);
         });
 
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-        expect(allPaths).toEqual(expected!);
+        expect(allPaths).toEqual(expected);
       });
     });
   });
diff --git a/packages/ngtools/webpack/src/transformers/replace_resources.ts b/packages/ngtools/webpack/src/transformers/replace_resources.ts
@@ -103,7 +103,7 @@ function visitDecorator(
     return node;
   }
 
-  const objectExpression = args[0] as ts.ObjectLiteralExpression;
+  const objectExpression = args[0];
   const styleReplacements: ts.Expression[] = [];
 
   // visit all properties
diff --git a/packages/schematics/angular/app-shell/index.ts b/packages/schematics/angular/app-shell/index.ts
@@ -49,7 +49,7 @@ function getServerModulePath(host: Tree, sourceRoot: string, mainPath: string):
   if (!expNode) {
     return null;
   }
-  const relativePath = (expNode as ts.ExportDeclaration).moduleSpecifier as ts.StringLiteral;
+  const relativePath = expNode.moduleSpecifier as ts.StringLiteral;
   const modulePath = join(sourceRoot, `${relativePath.text}.ts`);
 
   return modulePath;
diff --git a/packages/schematics/angular/component/index.ts b/packages/schematics/angular/component/index.ts
@@ -43,7 +43,7 @@ function buildSelector(options: ComponentOptions, projectPrefix: string) {
 export default function (options: ComponentOptions): Rule {
   return async (host: Tree) => {
     const workspace = await getWorkspace(host);
-    const project = workspace.projects.get(options.project as string);
+    const project = workspace.projects.get(options.project);
 
     if (!project) {
       throw new SchematicsException(`Project "${options.project}" does not exist.`);
@@ -55,7 +55,7 @@ export default function (options: ComponentOptions): Rule {
 
     options.module = findModuleFromOptions(host, options);
 
-    const parsedPath = parseName(options.path as string, options.name);
+    const parsedPath = parseName(options.path, options.name);
     options.name = parsedPath.name;
     options.path = parsedPath.path;
     options.selector =
diff --git a/packages/schematics/angular/directive/index.ts b/packages/schematics/angular/directive/index.ts
@@ -41,7 +41,7 @@ function buildSelector(options: DirectiveOptions, projectPrefix: string) {
 export default function (options: DirectiveOptions): Rule {
   return async (host: Tree) => {
     const workspace = await getWorkspace(host);
-    const project = workspace.projects.get(options.project as string);
+    const project = workspace.projects.get(options.project);
     if (!project) {
       throw new SchematicsException(`Project "${options.project}" does not exist.`);
     }
diff --git a/packages/schematics/angular/module/index.ts b/packages/schematics/angular/module/index.ts
@@ -131,7 +131,7 @@ function buildRoute(options: ModuleOptions, modulePath: string) {
 export default function (options: ModuleOptions): Rule {
   return async (host: Tree) => {
     if (options.path === undefined) {
-      options.path = await createDefaultPath(host, options.project as string);
+      options.path = await createDefaultPath(host, options.project);
     }
 
     if (options.module) {
diff --git a/packages/schematics/angular/pipe/index.ts b/packages/schematics/angular/pipe/index.ts
@@ -28,7 +28,7 @@ import { Schema as PipeOptions } from './schema';
 
 export default function (options: PipeOptions): Rule {
   return async (host: Tree) => {
-    options.path ??= await createDefaultPath(host, options.project as string);
+    options.path ??= await createDefaultPath(host, options.project);
     options.module = findModuleFromOptions(host, options);
 
     const parsedPath = parseName(options.path, options.name);

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ export class BuilderHarness<T> {`
`204`	`204`	`// Harness builder targets currently do not support configurations`
`205`	`205`	`return {};`
`206`	`206`	`} else {`
`207`		`- return (this.builderTargets.get(target)?.options \|\| {}) as json.JsonObject;`
	`207`	`+ return this.builderTargets.get(target)?.options \|\| {};`
`208`	`208`	`}`
`209`	`209`	`},`
`210`	`210`	`hasTarget: async (project, target) => {`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ function visitDecorator(`
`99`	`99`	`return node;`
`100`	`100`	`}`
`101`	`101`
`102`		`- const objectExpression = args[0] as ts.ObjectLiteralExpression;`
	`102`	`+ const objectExpression = args[0];`
`103`	`103`	`const styleReplacements: ts.Expression[] = [];`
`104`	`104`
`105`	`105`	`// visit all properties`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ function normalizeTranslationFileOption(`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`if (Array.isArray(option) && option.every((element) => typeof element === 'string')) {`
`42`		`- return option as string[];`
	`42`	`+ return option;`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	let errorMessage = `Project i18n locales translation field value for '${locale}' is malformed. `;
Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,7 @@ export function serveWebpackBrowser(`
`97`	`97`	logger.warn(`Warning: 'outputHashing' option is disabled when using the dev-server.`);
`98`	`98`	`}`
`99`	`99`
	`100`	`+ // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion`
`100`	`101`	`const browserOptions = (await context.validateOptions(`
`101`	`102`	`{`
`102`	`103`	`...rawBrowserOptions,`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ export default custom<ApplicationPresetOptions>(() => {`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`customOptions.i18n = {`
`117`		`- ...(i18n as NonNullable<ApplicationPresetOptions['i18n']>),`
	`117`	`+ ...i18n,`
`118`	`118`	`pluginCreators: i18nPluginCreators,`
`119`	`119`	`};`
`120`	`120`
Original file line number	Diff line number	Diff line change
`@@ -208,13 +208,11 @@ export class NodeJsSyncHost implements virtualFs.Host<Stats> {`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`isDirectory(path: Path): Observable<boolean> {`
`211`		`- // eslint-disable-next-line @typescript-eslint/no-non-null-assertion`
`212`		`- return this.stat(path)!.pipe(map((stat) => stat.isDirectory()));`
	`211`	`+ return this.stat(path).pipe(map((stat) => stat.isDirectory()));`
`213`	`212`	`}`
`214`	`213`
`215`	`214`	`isFile(path: Path): Observable<boolean> {`
`216`		`- // eslint-disable-next-line @typescript-eslint/no-non-null-assertion`
`217`		`- return this.stat(path)!.pipe(map((stat) => stat.isFile()));`
	`215`	`+ return this.stat(path).pipe(map((stat) => stat.isFile()));`
`218`	`216`	`}`
`219`	`217`
`220`	`218`	`// Some hosts may not support stat.`