fix(@angular/cli): fix issue of folder getting generated on dry run

sumitarora · Brocco · commit e4cedbb293cd · 2017-05-24T18:20:12.000-04:00
Fixes: #6017
diff --git a/packages/@angular/cli/blueprints/class/index.ts b/packages/@angular/cli/blueprints/class/index.ts
@@ -1,5 +1,5 @@
 import {getAppFromConfig} from '../../utilities/app-utils';
-import {dynamicPathParser} from '../../utilities/dynamic-path-parser';
+import {dynamicPathParser, DynamicPathOptions} from '../../utilities/dynamic-path-parser';
 import {CliConfig} from '../../models/config';
 
 const stringUtils = require('ember-cli-string-utils');
@@ -27,7 +27,14 @@ export default Blueprint.extend({
 
   normalizeEntityName: function (entityName: string) {
     const appConfig = getAppFromConfig(this.options.app);
-    const parsedPath = dynamicPathParser(this.project, entityName.split('.')[0], appConfig);
+    const dynamicPathOptions: DynamicPathOptions = {
+      project: this.project,
+      entityName: entityName.split('.')[0],
+      appConfig,
+      dryRun: this.options.dryRun
+    };
+
+    const parsedPath = dynamicPathParser(dynamicPathOptions);
 
     this.dynamicPath = parsedPath;
     return parsedPath.name;
diff --git a/packages/@angular/cli/blueprints/component/index.ts b/packages/@angular/cli/blueprints/component/index.ts
@@ -5,7 +5,7 @@ import { oneLine } from 'common-tags';
 import { NodeHost } from '../../lib/ast-tools';
 import { CliConfig } from '../../models/config';
 import { getAppFromConfig } from '../../utilities/app-utils';
-import { dynamicPathParser } from '../../utilities/dynamic-path-parser';
+import { dynamicPathParser, DynamicPathOptions } from '../../utilities/dynamic-path-parser';
 import { resolveModulePath } from '../../utilities/resolve-module-file';
 
 const Blueprint = require('../../ember-cli/lib/models/blueprint');
@@ -125,7 +125,13 @@ export default Blueprint.extend({
 
   normalizeEntityName: function (entityName: string) {
     const appConfig = getAppFromConfig(this.options.app);
-    const parsedPath = dynamicPathParser(this.project, entityName, appConfig);
+    const dynamicPathOptions: DynamicPathOptions = {
+      project: this.project,
+      entityName,
+      appConfig,
+      dryRun: this.options.dryRun
+    };
+    const parsedPath = dynamicPathParser(dynamicPathOptions);
 
     this.dynamicPath = parsedPath;
 
diff --git a/packages/@angular/cli/blueprints/directive/index.ts b/packages/@angular/cli/blueprints/directive/index.ts
@@ -5,7 +5,7 @@ import { NodeHost } from '../../lib/ast-tools';
 import { CliConfig } from '../../models/config';
 import { getAppFromConfig } from '../../utilities/app-utils';
 import { resolveModulePath } from '../../utilities/resolve-module-file';
-import { dynamicPathParser } from '../../utilities/dynamic-path-parser';
+import { dynamicPathParser, DynamicPathOptions } from '../../utilities/dynamic-path-parser';
 
 const stringUtils = require('ember-cli-string-utils');
 const astUtils = require('../../utilities/ast-utils');
@@ -78,7 +78,13 @@ export default Blueprint.extend({
 
   normalizeEntityName: function (entityName: string) {
     const appConfig = getAppFromConfig(this.options.app);
-    const parsedPath = dynamicPathParser(this.project, entityName, appConfig);
+    const dynamicPathOptions: DynamicPathOptions = {
+      project: this.project,
+      entityName,
+      appConfig,
+      dryRun: this.options.dryRun
+    };
+    const parsedPath = dynamicPathParser(dynamicPathOptions);
 
     this.dynamicPath = parsedPath;
 
diff --git a/packages/@angular/cli/blueprints/enum/index.ts b/packages/@angular/cli/blueprints/enum/index.ts
@@ -1,5 +1,5 @@
 import {getAppFromConfig} from '../../utilities/app-utils';
-import {dynamicPathParser} from '../../utilities/dynamic-path-parser';
+import {dynamicPathParser, DynamicPathOptions} from '../../utilities/dynamic-path-parser';
 
 const stringUtils = require('ember-cli-string-utils');
 const Blueprint = require('../../ember-cli/lib/models/blueprint');
@@ -20,7 +20,13 @@ export default Blueprint.extend({
 
   normalizeEntityName: function (entityName: string) {
     const appConfig = getAppFromConfig(this.options.app);
-    const parsedPath = dynamicPathParser(this.project, entityName, appConfig);
+    const dynamicPathOptions: DynamicPathOptions = {
+      project: this.project,
+      entityName,
+      appConfig,
+      dryRun: this.options.dryRun
+    };
+    const parsedPath = dynamicPathParser(dynamicPathOptions);
 
     this.dynamicPath = parsedPath;
     return parsedPath.name;
diff --git a/packages/@angular/cli/blueprints/guard/index.ts b/packages/@angular/cli/blueprints/guard/index.ts
@@ -3,7 +3,7 @@ import * as path from 'path';
 import { oneLine } from 'common-tags';
 import { NodeHost } from '../../lib/ast-tools';
 import { CliConfig } from '../../models/config';
-import { dynamicPathParser } from '../../utilities/dynamic-path-parser';
+import { dynamicPathParser, DynamicPathOptions } from '../../utilities/dynamic-path-parser';
 import { getAppFromConfig } from '../../utilities/app-utils';
 import { resolveModulePath } from '../../utilities/resolve-module-file';
 
@@ -46,7 +46,13 @@ export default Blueprint.extend({
 
   normalizeEntityName: function (entityName: string) {
     const appConfig = getAppFromConfig(this.options.app);
-    const parsedPath = dynamicPathParser(this.project, entityName, appConfig);
+    const dynamicPathOptions: DynamicPathOptions = {
+      project: this.project,
+      entityName,
+      appConfig,
+      dryRun: this.options.dryRun
+    };
+    const parsedPath = dynamicPathParser(dynamicPathOptions);
 
     this.dynamicPath = parsedPath;
     return parsedPath.name;
diff --git a/packages/@angular/cli/blueprints/interface/index.ts b/packages/@angular/cli/blueprints/interface/index.ts
@@ -1,6 +1,6 @@
 import {CliConfig} from '../../models/config';
 import {getAppFromConfig} from '../../utilities/app-utils';
-import {dynamicPathParser} from '../../utilities/dynamic-path-parser';
+import {dynamicPathParser, DynamicPathOptions} from '../../utilities/dynamic-path-parser';
 
 const stringUtils = require('ember-cli-string-utils');
 const Blueprint = require('../../ember-cli/lib/models/blueprint');
@@ -25,7 +25,13 @@ export default Blueprint.extend({
 
   normalizeEntityName: function (entityName: string) {
     const appConfig = getAppFromConfig(this.options.app);
-    const parsedPath = dynamicPathParser(this.project, entityName, appConfig);
+    const dynamicPathOptions: DynamicPathOptions = {
+      project: this.project,
+      entityName,
+      appConfig,
+      dryRun: this.options.dryRun
+    };
+    const parsedPath = dynamicPathParser(dynamicPathOptions);
 
     this.dynamicPath = parsedPath;
     return parsedPath.name;
diff --git a/packages/@angular/cli/blueprints/module/index.ts b/packages/@angular/cli/blueprints/module/index.ts
@@ -5,7 +5,7 @@ import { NodeHost } from '../../lib/ast-tools';
 import { CliConfig } from '../../models/config';
 import { getAppFromConfig } from '../../utilities/app-utils';
 import { resolveModulePath } from '../../utilities/resolve-module-file';
-import { dynamicPathParser } from '../../utilities/dynamic-path-parser';
+import { dynamicPathParser, DynamicPathOptions } from '../../utilities/dynamic-path-parser';
 
 const stringUtils = require('ember-cli-string-utils');
 const Blueprint = require('../../ember-cli/lib/models/blueprint');
@@ -58,7 +58,13 @@ export default Blueprint.extend({
   normalizeEntityName: function (entityName: string) {
     this.entityName = entityName;
     const appConfig = getAppFromConfig(this.options.app);
-    const parsedPath = dynamicPathParser(this.project, entityName, appConfig);
+    const dynamicPathOptions: DynamicPathOptions = {
+      project: this.project,
+      entityName,
+      appConfig,
+      dryRun: this.options.dryRun
+    };
+    const parsedPath = dynamicPathParser(dynamicPathOptions);
 
     this.dynamicPath = parsedPath;
     return parsedPath.name;
diff --git a/packages/@angular/cli/blueprints/pipe/index.ts b/packages/@angular/cli/blueprints/pipe/index.ts
@@ -2,7 +2,7 @@ import * as chalk from 'chalk';
 import * as path from 'path';
 import { NodeHost } from '../../lib/ast-tools';
 import { CliConfig } from '../../models/config';
-import { dynamicPathParser } from '../../utilities/dynamic-path-parser';
+import { dynamicPathParser, DynamicPathOptions } from '../../utilities/dynamic-path-parser';
 import { getAppFromConfig } from '../../utilities/app-utils';
 import { resolveModulePath } from '../../utilities/resolve-module-file';
 
@@ -72,7 +72,13 @@ export default Blueprint.extend({
 
   normalizeEntityName: function (entityName: string) {
     const appConfig = getAppFromConfig(this.options.app);
-    const parsedPath = dynamicPathParser(this.project, entityName, appConfig);
+    const dynamicPathOptions: DynamicPathOptions = {
+      project: this.project,
+      entityName,
+      appConfig,
+      dryRun: this.options.dryRun
+    };
+    const parsedPath = dynamicPathParser(dynamicPathOptions);
 
     this.dynamicPath = parsedPath;
     return parsedPath.name;
diff --git a/packages/@angular/cli/blueprints/service/index.ts b/packages/@angular/cli/blueprints/service/index.ts
@@ -3,7 +3,7 @@ import * as path from 'path';
 import { oneLine } from 'common-tags';
 import { NodeHost } from '../../lib/ast-tools';
 import { CliConfig } from '../../models/config';
-import { dynamicPathParser } from '../../utilities/dynamic-path-parser';
+import { dynamicPathParser, DynamicPathOptions } from '../../utilities/dynamic-path-parser';
 import { getAppFromConfig } from '../../utilities/app-utils';
 import { resolveModulePath } from '../../utilities/resolve-module-file';
 
@@ -51,7 +51,13 @@ export default Blueprint.extend({
 
   normalizeEntityName: function (entityName: string) {
     const appConfig = getAppFromConfig(this.options.app);
-    const parsedPath = dynamicPathParser(this.project, entityName, appConfig);
+    const dynamicPathOptions: DynamicPathOptions = {
+      project: this.project,
+      entityName,
+      appConfig,
+      dryRun: this.options.dryRun
+    };
+    const parsedPath = dynamicPathParser(dynamicPathOptions);
 
     this.dynamicPath = parsedPath;
     return parsedPath.name;
diff --git a/packages/@angular/cli/ember-cli/lib/models/blueprint.js b/packages/@angular/cli/ember-cli/lib/models/blueprint.js
@@ -517,7 +517,7 @@ Blueprint.prototype.install = function(options) {
     ui.writeLine(chalk.yellow('You specified the dry-run flag, so no' +
       ' changes will be written.'));
   }
-
+  
   this._normalizeEntityName(options.entity);
   this._checkForPod(options.verbose);
   this._checkInRepoAddonExists(options.inRepoAddon);
diff --git a/packages/@angular/cli/utilities/dynamic-path-parser.ts b/packages/@angular/cli/utilities/dynamic-path-parser.ts
@@ -3,19 +3,26 @@ import * as process from 'process';
 import * as fs from 'fs-extra';
 const stringUtils = require('ember-cli-string-utils');
 
-export function dynamicPathParser(project: any, entityName: string, appConfig: any) {
-  const projectRoot = project.root;
-  const sourceDir = appConfig.root;
+export interface DynamicPathOptions {
+  project: any;
+  entityName: string;
+  appConfig: any;
+  dryRun: boolean;
+}
+
+export function dynamicPathParser(options: DynamicPathOptions) {
+  const projectRoot = options.project.root;
+  const sourceDir = options.appConfig.root;
   const appRoot = path.join(sourceDir, 'app');
   const cwd = process.env.PWD;
 
   const rootPath = path.join(projectRoot, appRoot);
-  let outputPath = path.join(rootPath, entityName);
+  let outputPath = path.join(rootPath, options.entityName);
 
-  if (entityName.indexOf(path.sep) === 0) {
-    outputPath = path.join(rootPath, entityName.substr(1));
+  if (options.entityName.indexOf(path.sep) === 0) {
+    outputPath = path.join(rootPath, options.entityName.substr(1));
   } else if (cwd.indexOf(rootPath) >= 0) {
-    outputPath = path.join(cwd, entityName);
+    outputPath = path.join(cwd, options.entityName);
   }
 
   if (!fs.existsSync(outputPath)) {
@@ -38,15 +45,17 @@ export function dynamicPathParser(project: any, entityName: string, appConfig: a
       // Folder not found, create it, and return it
       const dasherizedPart = stringUtils.dasherize(part);
       const dasherizedDirName = path.join(tempPath, dasherizedPart);
-      fs.mkdirpSync(dasherizedDirName);
+      if (!options.dryRun) {
+        fs.mkdirpSync(dasherizedDirName);
+      }
       return dasherizedDirName;
 
     }, parsedOutputPath.root);
     outputPath = path.join(newPath, parsedOutputPath.name);
   }
 
   if (outputPath.indexOf(rootPath) < 0) {
-    throw `Invalid path: "${entityName}" cannot be ` +
+    throw `Invalid path: "${options.entityName}" cannot be ` +
         `above the "${appRoot}" directory`;
   }
 
diff --git a/packages/@angular/cli/utilities/resolve-module-file.ts b/packages/@angular/cli/utilities/resolve-module-file.ts
@@ -1,6 +1,6 @@
 import * as path from 'path';
 import * as fs from 'fs';
-import { dynamicPathParser } from './dynamic-path-parser';
+import { dynamicPathParser, DynamicPathOptions } from './dynamic-path-parser';
 
 export function resolveModulePath(
   moduleNameFromFlag: string, project: any, projectRoot: any, appConfig: any): string {
@@ -41,7 +41,13 @@ export function resolveModulePath(
 }
 
 function buildFullPath(project: any, relativeModulePath: string, appConfig: any, projectRoot: any) {
-  const parsedPath = dynamicPathParser(project, relativeModulePath, appConfig);
+  const dynamicPathOptions: DynamicPathOptions = {
+    project,
+    entityName: relativeModulePath,
+    appConfig,
+    dryRun: false
+  };
+  const parsedPath = dynamicPathParser(dynamicPathOptions);
   const fullModulePath = path.join(projectRoot, parsedPath.dir, parsedPath.base);
 
   return fullModulePath;
diff --git a/tests/acceptance/dynamic-path-parser.spec.js b/tests/acceptance/dynamic-path-parser.spec.js

Original file line number	Diff line number	Diff line change
`@@ -517,7 +517,7 @@ Blueprint.prototype.install = function(options) {`
`517`	`517`	`ui.writeLine(chalk.yellow('You specified the dry-run flag, so no' +`
`518`	`518`	`' changes will be written.'));`
`519`	`519`	`}`
`520`		`-`
	`520`	`+`
`521`	`521`	`this._normalizeEntityName(options.entity);`
`522`	`522`	`this._checkForPod(options.verbose);`
`523`	`523`	`this._checkInRepoAddonExists(options.inRepoAddon);`