refactor(@angular/cli): remove unused ember task abstraction

Author: clydin

package-lock.json

@@ -48,7 +48,6 @@
     "@schematics/update": "0.5.0",
     "chalk": "~2.2.0",
     "common-tags": "^1.3.1",
-    "core-object": "^3.1.0",
     "ember-cli-string-utils": "^1.0.0",
     "fs-extra": "^4.0.0",
     "lodash": "^4.11.1",

package.json

@@ -14,42 +14,23 @@ process.setMaxListeners(1000);
 
 // Options: Array cliArgs, Stream inputStream, Stream outputStream
 module.exports = function(options) {
-  let UI = options.UI || require('../ui');
   const CLI = require('./cli');
   const Project = require('../models/project');
 
-  // TODO: one UI (lib/models/project.js also has one for now...)
-  let ui = new UI({
-    inputStream: options.inputStream,
-    outputStream: options.outputStream,
-    errorStream: options.errorStream || process.stderr,
-    errorLog: options.errorLog || [],
-    ci: process.env.CI || (/^(dumb|emacs)$/).test(process.env.TERM),
-    writeLevel: (process.argv.indexOf('--silent') !== -1) ? 'ERROR' : undefined,
-  });
-
-
-  let defaultUpdateCheckerOptions = {
-    // checkForUpdates: false,
-  };
-
   let cli = new CLI({
-    ui,
     testing: options.testing,
     name: options.cli ? options.cli.name : 'ember',
-    disableDependencyChecker: options.disableDependencyChecker,
     root: options.cli ? options.cli.root : path.resolve(__dirname, '..', '..'),
     npmPackage: options.cli ? options.cli.npmPackage : 'ember-cli',
   });
 
-  let project = Project.projectOrnullProject(ui, cli);
+  let project = Project.projectOrnullProject(undefined, cli);
 
   let environment = {
     tasks: options.tasks || {},
     cliArgs: options.cliArgs,
     commands: options.commands || {},
     project,
-    settings: defaultUpdateCheckerOptions,
   };
 
   return cli.run(environment);

packages/@angular/cli/ember-cli/lib/cli/index.js

@@ -239,7 +239,6 @@ class Project {
   static closest(pathName, _ui, _cli) {
     let ui = ensureUI(_ui);
 
-    ui.writeDeprecateLine('`Project.closest` is a private method that will be removed, please use `Project.closestSync` instead.');
 
     return closestPackageJSON(pathName).then(result => {
       if (result.pkg && result.pkg.name === 'ember-cli') {
@@ -345,17 +344,6 @@ function ensureInstrumentation(cli, ui) {
 function ensureUI(_ui) {
   let ui = _ui;
 
-  if (!ui) {
-    // TODO: one UI (lib/cli/index.js also has one for now...)
-    const UI = require('../ui');
-    ui = new UI({
-      inputStream: process.stdin,
-      outputStream: process.stdout,
-      ci: process.env.CI || (/^(dumb|emacs)$/).test(process.env.TERM),
-      writeLevel: (process.argv.indexOf('--silent') !== -1) ? 'ERROR' : undefined,
-    });
-  }
-
   return ui;
 }
 

packages/@angular/cli/ember-cli/lib/models/project.js

@@ -1,7 +1,6 @@
 import * as path from 'path';
 
 const cli = require('../../ember-cli/lib/cli');
-const UI = require('../../ember-cli/lib/ui');
 
 
 function loadCommands() {
@@ -30,10 +29,6 @@ function loadCommands() {
 }
 
 export default function(options: any) {
-
-  // patch UI to not print Ember-CLI warnings (which don't apply to Angular CLI)
-  UI.prototype.writeWarnLine = function () { };
-
   options.cli = {
     name: 'ng',
     root: path.join(__dirname, '..', '..'),

packages/@angular/cli/ember-cli/lib/models/task.js

@@ -34,7 +34,6 @@
     "@schematics/update": "0.5.0",
     "chalk": "~2.2.0",
     "common-tags": "^1.3.1",
-    "core-object": "^3.1.0",
     "ember-cli-string-utils": "^1.0.0",
     "fs-extra": "^4.0.0",
     "lodash": "^4.11.1",