refactor(@angular/cli): import type improvements & mcp cleanups

Author: lekhmanrus

packages/angular/cli/src/commands/mcp/cli.ts

@@ -7,8 +7,11 @@
  */
 
 import { StdioServerTransport } from '@modelcontextprotocol/sdk/server/stdio.js';
-import { Argv } from 'yargs';
-import { CommandModule, CommandModuleImplementation } from '../../command-builder/command-module';
+import type { Argv } from 'yargs';
+import {
+  CommandModule,
+  type CommandModuleImplementation,
+} from '../../command-builder/command-module';
 import { isTTY } from '../../utilities/tty';
 import { EXPERIMENTAL_TOOLS, createMcpServer } from './mcp-server';
 

packages/angular/cli/src/commands/mcp/dev-server.ts

@@ -6,8 +6,8 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import { ChildProcess } from 'child_process';
-import { Host } from './host';
+import type { ChildProcess } from 'child_process';
+import type { Host } from './host';
 
 // Log messages that we want to catch to identify the build status.
 

packages/angular/cli/src/commands/mcp/mcp-server.ts

@@ -7,10 +7,10 @@
  */
 
 import { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
-import path from 'node:path';
+import { join } from 'node:path';
 import type { AngularWorkspace } from '../../utilities/config';
 import { VERSION } from '../../utilities/version';
-import { DevServer } from './dev-server';
+import type { DevServer } from './dev-server';
 import { registerInstructionsResource } from './resources/instructions';
 import { AI_TUTOR_TOOL } from './tools/ai-tutor';
 import { BEST_PRACTICES_TOOL } from './tools/best-practices';
@@ -23,7 +23,7 @@ import { FIND_EXAMPLE_TOOL } from './tools/examples';
 import { MODERNIZE_TOOL } from './tools/modernize';
 import { ZONELESS_MIGRATION_TOOL } from './tools/onpush-zoneless-migration/zoneless-migration';
 import { LIST_PROJECTS_TOOL } from './tools/projects';
-import { AnyMcpToolDeclaration, registerTools } from './tools/tool-registry';
+import { type AnyMcpToolDeclaration, registerTools } from './tools/tool-registry';
 
 /**
  * Tools to manage devservers. Should be bundled together, then added to experimental or stable as a group.
@@ -113,7 +113,7 @@ equivalent actions.
     {
       workspace: options.workspace,
       logger,
-      exampleDatabasePath: path.join(__dirname, '../../../lib/code-examples.db'),
+      exampleDatabasePath: join(__dirname, '../../../lib/code-examples.db'),
       devServers: new Map<string, DevServer>(),
     },
     toolDeclarations,

packages/angular/cli/src/commands/mcp/resources/instructions.ts

@@ -6,9 +6,9 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
+import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
 import { readFile } from 'node:fs/promises';
-import path from 'node:path';
+import { join } from 'node:path';
 
 export function registerInstructionsResource(server: McpServer): void {
   server.registerResource(
@@ -24,7 +24,7 @@ export function registerInstructionsResource(server: McpServer): void {
       mimeType: 'text/markdown',
     },
     async () => {
-      const text = await readFile(path.join(__dirname, 'best-practices.md'), 'utf-8');
+      const text = await readFile(join(__dirname, 'best-practices.md'), 'utf-8');
 
       return { contents: [{ uri: 'instructions://best-practices', text }] };
     },

packages/angular/cli/src/commands/mcp/testing/mock-host.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import { Host } from '../host';
+import type { Host } from '../host';
 
 /**
  * A mock implementation of the `Host` interface for testing purposes.

packages/angular/cli/src/commands/mcp/tools/ai-tutor.ts

@@ -7,7 +7,7 @@
  */
 
 import { readFile } from 'node:fs/promises';
-import path from 'node:path';
+import { join } from 'node:path';
 import { declareTool } from './tool-registry';
 
 export const AI_TUTOR_TOOL = declareTool({
@@ -40,10 +40,7 @@ with a new core identity and knowledge base.
     let aiTutorText: string;
 
     return async () => {
-      aiTutorText ??= await readFile(
-        path.join(__dirname, '..', 'resources', 'ai-tutor.md'),
-        'utf-8',
-      );
+      aiTutorText ??= await readFile(join(__dirname, '../resources/ai-tutor.md'), 'utf-8');
 
       return {
         content: [

packages/angular/cli/src/commands/mcp/tools/best-practices.ts

@@ -17,10 +17,10 @@
 
 import { readFile, stat } from 'node:fs/promises';
 import { createRequire } from 'node:module';
-import path from 'node:path';
+import { dirname, isAbsolute, join, relative, resolve } from 'node:path';
 import { z } from 'zod';
 import { VERSION } from '../../../utilities/version';
-import { McpToolContext, declareTool } from './tool-registry';
+import { type McpToolContext, declareTool } from './tool-registry';
 
 const bestPracticesInputSchema = z.object({
   workspacePath: z
@@ -72,7 +72,7 @@ that **MUST** be followed for any task involving the creation, analysis, or modi
  * @returns A promise that resolves to the string content of the bundled markdown file.
  */
 async function getBundledBestPractices(): Promise<string> {
-  return readFile(path.join(__dirname, '..', 'resources', 'best-practices.md'), 'utf-8');
+  return readFile(join(__dirname, '../resources/best-practices.md'), 'utf-8');
 }
 
 /**
@@ -126,14 +126,14 @@ async function getVersionSpecificBestPractices(
       bestPracticesInfo.format === 'markdown' &&
       typeof bestPracticesInfo.path === 'string'
     ) {
-      const packageDirectory = path.dirname(pkgJsonPath);
-      const guidePath = path.resolve(packageDirectory, bestPracticesInfo.path);
+      const packageDirectory = dirname(pkgJsonPath);
+      const guidePath = resolve(packageDirectory, bestPracticesInfo.path);
 
       // Ensure the resolved guide path is within the package boundary.
       // Uses path.relative to create a cross-platform, case-insensitive check.
       // If the relative path starts with '..' or is absolute, it is a traversal attempt.
-      const relativePath = path.relative(packageDirectory, guidePath);
-      if (relativePath.startsWith('..') || path.isAbsolute(relativePath)) {
+      const relativePath = relative(packageDirectory, guidePath);
+      if (relativePath.startsWith('..') || isAbsolute(relativePath)) {
         logger.warn(
           `Detected a potential path traversal attempt in '${pkgJsonPath}'. ` +
             `The path '${bestPracticesInfo.path}' escapes the package boundary. ` +

packages/angular/cli/src/commands/mcp/tools/build.ts

@@ -7,9 +7,9 @@
  */
 
 import { z } from 'zod';
-import { CommandError, Host, LocalWorkspaceHost } from '../host';
+import { CommandError, type Host, LocalWorkspaceHost } from '../host';
 import { createStructuredContentOutput } from '../utils';
-import { McpToolDeclaration, declareTool } from './tool-registry';
+import { type McpToolDeclaration, declareTool } from './tool-registry';
 
 const DEFAULT_CONFIGURATION = 'development';
 

packages/angular/cli/src/commands/mcp/tools/build_spec.ts

@@ -7,7 +7,7 @@
  */
 
 import { CommandError, Host } from '../host';
-import { MockHost } from '../testing/mock-host';
+import type { MockHost } from '../testing/mock-host';
 import { runBuild } from './build';
 
 describe('Build Tool', () => {
@@ -18,7 +18,7 @@ describe('Build Tool', () => {
       runCommand: jasmine.createSpy<Host['runCommand']>('runCommand').and.resolveTo({ logs: [] }),
       stat: jasmine.createSpy<Host['stat']>('stat'),
       existsSync: jasmine.createSpy<Host['existsSync']>('existsSync'),
-    } as Partial<MockHost> as MockHost;
+    } as MockHost;
   });
 
   it('should construct the command correctly with default configuration', async () => {

packages/angular/cli/src/commands/mcp/tools/devserver/serve_spec.ts

@@ -7,9 +7,9 @@
  */
 
 import { EventEmitter } from 'events';
-import { ChildProcess } from 'node:child_process';
-import { MockHost } from '../../testing/mock-host';
-import { McpToolContext } from '../tool-registry';
+import type { ChildProcess } from 'node:child_process';
+import type { MockHost } from '../../testing/mock-host';
+import type { McpToolContext } from '../tool-registry';
 import { startDevServer } from './start-devserver';
 import { stopDevserver } from './stop-devserver';
 import { WATCH_DELAY, waitForDevserverBuild } from './wait-for-devserver-build';
@@ -34,7 +34,7 @@ describe('Serve Tools', () => {
       getAvailablePort: jasmine.createSpy('getAvailablePort').and.callFake(() => {
         return Promise.resolve(portCounter++);
       }),
-    } as Partial<MockHost> as MockHost;
+    } as MockHost;
 
     mockContext = {
       devServers: new Map(),