fix(@angular/cli): don't install using global command but rather install in a different folder

Fixes: #16010

Author: alan-agius4

packages/angular/cli/tasks/install-package.ts

@@ -24,33 +24,28 @@ interface PackageManagerOptions {
   silent: string;
   install: string;
   prefix: string;
+  noBinLinks: string;
+  noLockfile: string;
 }
 
 export function installPackage(
   packageName: string,
   logger: logging.Logger,
   packageManager: PackageManager = PackageManager.Npm,
   extraArgs: string[] = [],
-  global = false,
+  cwd = process.cwd(),
 ) {
   const packageManagerArgs = getPackageManagerArguments(packageManager);
 
   const installArgs: string[] = [
     packageManagerArgs.install,
     packageName,
     packageManagerArgs.silent,
+    packageManagerArgs.noBinLinks,
   ];
 
   logger.info(colors.green(`Installing packages for tooling via ${packageManager}.`));
 
-  if (global) {
-    if (packageManager === PackageManager.Yarn) {
-      installArgs.unshift('global');
-    } else {
-      installArgs.push('--global');
-    }
-  }
-
   const { status } = spawnSync(
     packageManager,
     [
@@ -60,6 +55,7 @@ export function installPackage(
     {
       stdio: 'inherit',
       shell: true,
+      cwd,
     },
   );
 
@@ -82,13 +78,6 @@ export function installTempPackage(
 
   // setup prefix/global modules path
   const packageManagerArgs = getPackageManagerArguments(packageManager);
-  const installArgs: string[] = [
-    packageManagerArgs.prefix,
-    tempPath,
-  ];
-
-  installPackage(packageName, logger, packageManager, installArgs, true);
-
   let tempNodeModules: string;
   if (packageManager !== PackageManager.Yarn && process.platform !== 'win32') {
     // Global installs on Unix systems go to {prefix}/lib/node_modules.
@@ -98,6 +87,15 @@ export function installTempPackage(
     tempNodeModules = join(tempPath, 'node_modules');
   }
 
+  const installArgs: string[] = [
+    packageManagerArgs.prefix,
+    // Yarn will no append 'node_modules' to the path
+    packageManager === PackageManager.Yarn ? tempNodeModules : tempPath,
+    packageManagerArgs.noLockfile,
+  ];
+
+  installPackage(packageName, logger, packageManager, installArgs, tempPath);
+
   // Needed to resolve schematics from this location since we use a custom
   // resolve strategy in '@angular/devkit-core/node'
   // todo: this should be removed when we change the resolutions to use require.resolve
@@ -165,11 +163,15 @@ function getPackageManagerArguments(packageManager: PackageManager): PackageMana
     ? {
       silent: '--silent',
       install: 'add',
-      prefix: '--global-folder',
+      prefix: '--modules-folder',
+      noBinLinks: '--no-bin-links',
+      noLockfile: '--no-lockfile',
     }
     : {
       silent: '--quiet',
       install: 'install',
       prefix: '--prefix',
+      noBinLinks: '--no-bin-links',
+      noLockfile: '--no-package-lock',
     };
 }