style: enable no-debugger and no-console tslint rules

Author: alan-agius4

packages/angular/cli/commands/add-impl.ts

@@ -122,7 +122,9 @@ export class AddCommand extends SchematicCommand<AddCommandSchema> {
         collectionName = manifest.name;
 
         if (await this.hasMismatchedPeer(manifest)) {
-          console.warn('Package has unmet peer dependencies. Adding the package may not succeed.');
+          this.logger.warn(
+            'Package has unmet peer dependencies. Adding the package may not succeed.',
+          );
         }
       } catch (e) {
         this.logger.error('Unable to fetch package manifest: ' + e.message);

packages/angular/cli/lib/cli/index.ts

@@ -13,6 +13,7 @@ import { colors, supportsColor } from '../../utilities/color';
 import { getWorkspaceRaw } from '../../utilities/config';
 import { getWorkspaceDetails } from '../../utilities/project';
 
+// tslint:disable: no-console
 export default async function(options: { testing?: boolean; cliArgs: string[] }) {
   const logger = createConsoleLogger(false, process.stdout, process.stderr, {
     info: s => (supportsColor ? s : colors.unstyle(s)),
@@ -95,6 +96,7 @@ export default async function(options: { testing?: boolean; cliArgs: string[] })
     }
 
     if (options.testing) {
+      // tslint:disable-next-line: no-debugger
       debugger;
       throw err;
     }

packages/angular/cli/lib/init.ts

@@ -7,6 +7,7 @@
  */
 import 'symbol-observable';
 // symbol polyfill must go first
+// tslint:disable: no-console
 // tslint:disable-next-line:ordered-imports import-groups
 import { tags } from '@angular-devkit/core';
 import * as fs from 'fs';

packages/angular/cli/models/analytics.ts

@@ -17,6 +17,7 @@ import { colors } from '../utilities/color';
 import { getWorkspace, getWorkspaceRaw } from '../utilities/config';
 import { isTTY } from '../utilities/tty';
 
+// tslint:disable: no-console
 const analyticsDebug = debug('ng:analytics'); // Generate analytics, including settings and users.
 const analyticsLogDebug = debug('ng:analytics:log'); // Actual logs of events.
 

packages/angular_devkit/architect_cli/bin/architect.ts

@@ -8,22 +8,14 @@
  */
 import { Architect, BuilderInfo, BuilderProgressState, Target } from '@angular-devkit/architect';
 import { WorkspaceNodeModulesArchitectHost } from '@angular-devkit/architect/node';
-import {
-  json,
-  logging,
-  schema,
-  tags,
-  terminal,
-  workspaces,
-} from '@angular-devkit/core';
+import { json, logging, schema, tags, terminal, workspaces } from '@angular-devkit/core';
 import { NodeJsSyncHost, createConsoleLogger } from '@angular-devkit/core/node';
 import { existsSync } from 'fs';
 import * as minimist from 'minimist';
 import * as path from 'path';
 import { tap } from 'rxjs/operators';
 import { MultiProgressBar } from '../src/progress';
 
-
 function findUp(names: string | string[], from: string) {
   if (!Array.isArray(names)) {
     names = [names];
@@ -64,21 +56,19 @@ function usage(logger: logging.Logger, exitCode = 0): never {
   `);
 
   process.exit(exitCode);
-  throw 0;  // The node typing sometimes don't have a never type for process.exit().
+  throw 0; // The node typing sometimes don't have a never type for process.exit().
 }
 
-function _targetStringFromTarget({project, target, configuration}: Target) {
+function _targetStringFromTarget({ project, target, configuration }: Target) {
   return `${project}:${target}${configuration !== undefined ? ':' + configuration : ''}`;
 }
 
-
 interface BarInfo {
   status?: string;
   builder: BuilderInfo;
   target?: Target;
 }
 
-
 async function _executeTarget(
   parentLogger: logging.Logger,
   workspace: workspaces.WorkspaceDefinition,
@@ -104,63 +94,64 @@ async function _executeTarget(
   const run = await architect.scheduleTarget(targetSpec, argv, { logger });
   const bars = new MultiProgressBar<number, BarInfo>(':name :bar (:current/:total) :status');
 
-  run.progress.subscribe(
-    update => {
-      const data = bars.get(update.id) || {
-        id: update.id,
-        builder: update.builder,
-        target: update.target,
-        status: update.status || '',
-        name: ((update.target ? _targetStringFromTarget(update.target) : update.builder.name)
-                + ' '.repeat(80)
-              ).substr(0, 40),
-      };
-
-      if (update.status !== undefined) {
-        data.status = update.status;
-      }
+  run.progress.subscribe(update => {
+    const data = bars.get(update.id) || {
+      id: update.id,
+      builder: update.builder,
+      target: update.target,
+      status: update.status || '',
+      name: (
+        (update.target ? _targetStringFromTarget(update.target) : update.builder.name) +
+        ' '.repeat(80)
+      ).substr(0, 40),
+    };
+
+    if (update.status !== undefined) {
+      data.status = update.status;
+    }
 
-      switch (update.state) {
-        case BuilderProgressState.Error:
-          data.status = 'Error: ' + update.error;
-          bars.update(update.id, data);
-          break;
-
-        case BuilderProgressState.Stopped:
-          data.status = 'Done.';
-          bars.complete(update.id);
-          bars.update(update.id, data, update.total, update.total);
-          break;
-
-        case BuilderProgressState.Waiting:
-          bars.update(update.id, data);
-          break;
-
-        case BuilderProgressState.Running:
-          bars.update(update.id, data, update.current, update.total);
-          break;
-      }
+    switch (update.state) {
+      case BuilderProgressState.Error:
+        data.status = 'Error: ' + update.error;
+        bars.update(update.id, data);
+        break;
+
+      case BuilderProgressState.Stopped:
+        data.status = 'Done.';
+        bars.complete(update.id);
+        bars.update(update.id, data, update.total, update.total);
+        break;
+
+      case BuilderProgressState.Waiting:
+        bars.update(update.id, data);
+        break;
+
+      case BuilderProgressState.Running:
+        bars.update(update.id, data, update.current, update.total);
+        break;
+    }
 
-      bars.render();
-    },
-  );
+    bars.render();
+  });
 
   // Wait for full completion of the builder.
   try {
-    const { success } = await run.output.pipe(
-      tap(result => {
-        if (result.success) {
-          parentLogger.info(terminal.green('SUCCESS'));
-        } else {
-          parentLogger.info(terminal.yellow('FAILURE'));
-        }
-        parentLogger.info('Result: ' + JSON.stringify({ ...result, info: undefined }, null, 4));
-
-        parentLogger.info('\nLogs:');
-        logs.forEach(l => parentLogger.next(l));
-        logs.splice(0);
-      }),
-    ).toPromise();
+    const { success } = await run.output
+      .pipe(
+        tap(result => {
+          if (result.success) {
+            parentLogger.info(terminal.green('SUCCESS'));
+          } else {
+            parentLogger.info(terminal.yellow('FAILURE'));
+          }
+          parentLogger.info('Result: ' + JSON.stringify({ ...result, info: undefined }, null, 4));
+
+          parentLogger.info('\nLogs:');
+          logs.forEach(l => parentLogger.next(l));
+          logs.splice(0);
+        }),
+      )
+      .toPromise();
 
     await run.stop();
     bars.terminate();
@@ -178,7 +169,6 @@ async function _executeTarget(
   }
 }
 
-
 async function main(args: string[]): Promise<number> {
   /** Parse the command line. */
   const argv = minimist(args, { boolean: ['help'] });
@@ -195,18 +185,15 @@ async function main(args: string[]): Promise<number> {
 
   // Load workspace configuration file.
   const currentPath = process.cwd();
-  const configFileNames = [
-    'angular.json',
-    '.angular.json',
-    'workspace.json',
-    '.workspace.json',
-  ];
+  const configFileNames = ['angular.json', '.angular.json', 'workspace.json', '.workspace.json'];
 
   const configFilePath = findUp(configFileNames, currentPath);
 
   if (!configFilePath) {
-    logger.fatal(`Workspace configuration file (${configFileNames.join(', ')}) cannot be found in `
-      + `'${currentPath}' or in parent directories.`);
+    logger.fatal(
+      `Workspace configuration file (${configFileNames.join(', ')}) cannot be found in ` +
+        `'${currentPath}' or in parent directories.`,
+    );
 
     return 3;
   }
@@ -227,10 +214,13 @@ async function main(args: string[]): Promise<number> {
   return await _executeTarget(logger, workspace, root, argv, registry);
 }
 
-main(process.argv.slice(2))
-  .then(code => {
+main(process.argv.slice(2)).then(
+  code => {
     process.exit(code);
-  }, err => {
+  },
+  err => {
+    // tslint:disable-next-line: no-console
     console.error('Error: ' + err.stack || err.message || err);
     process.exit(-1);
-  });
+  },
+);

packages/angular_devkit/build_optimizer/src/build-optimizer/cli.ts

@@ -10,7 +10,7 @@ import { writeFileSync } from 'fs';
 import { join } from 'path';
 import { buildOptimizer } from './build-optimizer';
 
-
+// tslint:disable: no-console
 if (process.argv.length < 3 || process.argv.length > 4) {
   throw new Error(`
     build-optimizer should be called with either one or two arguments:
@@ -30,7 +30,7 @@ if (!inputFile.match(tsOrJsRegExp)) {
 }
 
 // Use provided output file, or add the .bo suffix before the extension.
-const outputFile = process.argv[3] || inputFile.replace(tsOrJsRegExp, (subStr) => `.bo${subStr}`);
+const outputFile = process.argv[3] || inputFile.replace(tsOrJsRegExp, subStr => `.bo${subStr}`);
 
 const boOutput = buildOptimizer({
   inputFilePath: join(currentDir, inputFile),

packages/angular_devkit/build_optimizer/src/build-optimizer/rollup-plugin.ts

@@ -31,19 +31,27 @@ export default function optimizer(options: Options) {
 
   return {
     name: 'build-optimizer',
-    transform: (content: string, id: string): {code: string, map: RawSourceMap}|null => {
+    transform: (content: string, id: string): { code: string; map: RawSourceMap } | null => {
       const normalizedId = id.replace(/\\/g, '/');
-      const isSideEffectFree = options.sideEffectFreeModules &&
+      const isSideEffectFree =
+        options.sideEffectFreeModules &&
         options.sideEffectFreeModules.some(m => normalizedId.indexOf(m) >= 0);
-      const isAngularCoreFile = options.angularCoreModules &&
+      const isAngularCoreFile =
+        options.angularCoreModules &&
         options.angularCoreModules.some(m => normalizedId.indexOf(m) >= 0);
       const { content: code, sourceMap: map } = buildOptimizer({
-        content, inputFilePath: id, emitSourceMap: true, isSideEffectFree, isAngularCoreFile,
+        content,
+        inputFilePath: id,
+        emitSourceMap: true,
+        isSideEffectFree,
+        isAngularCoreFile,
       });
       if (!code) {
         if (DEBUG) {
-          console.error('no transforms produced by buildOptimizer for '
-             + path.relative(process.cwd(), id));
+          // tslint:disable-next-line: no-console
+          console.error(
+            'no transforms produced by buildOptimizer for ' + path.relative(process.cwd(), id),
+          );
         }
 
         return null;

packages/ngtools/webpack/src/benchmark.ts

@@ -9,7 +9,7 @@
 // Use with CLI --no-progress flag for best results.
 // This should be false for commited code.
 const _benchmark = false;
-
+// tslint:disable:no-console
 export function time(label: string) {
   if (_benchmark) {
     console.time(label);