build: update files to be eslint compliant

All TypeScript files have been updated to pass the new eslint-based linting checks. eslint compatible disabling comments have also been added in place of the previous tslint comments.

(cherry picked from commit c1512e4)

Author: clydin

.eslintrc.json

@@ -76,16 +76,21 @@
     "no-useless-escape": "off",
     "@typescript-eslint/await-thenable": "off",
     "@typescript-eslint/ban-types": "off",
+    "@typescript-eslint/no-empty-function": "off",
     "@typescript-eslint/explicit-module-boundary-types": "off",
+    "@typescript-eslint/no-implied-eval": "off",
     "@typescript-eslint/no-var-requires": "off",
+    "@typescript-eslint/no-unnecessary-type-assertion": "off",
     "@typescript-eslint/no-unsafe-assignment": "off",
     "@typescript-eslint/no-unsafe-call": "off",
     "@typescript-eslint/no-unsafe-member-access": "off",
     "@typescript-eslint/no-unsafe-return": "off",
+    "@typescript-eslint/no-unused-vars": "off",
     "@typescript-eslint/prefer-regexp-exec": "off",
     "@typescript-eslint/require-await": "off",
     "@typescript-eslint/restrict-plus-operands": "off",
-    "@typescript-eslint/restrict-template-expressions": "off"
+    "@typescript-eslint/restrict-template-expressions": "off",
+    "@typescript-eslint/unbound-method": "off"
   },
   "overrides": [
     {

lib/packages.ts

@@ -6,8 +6,6 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-// tslint:disable-next-line: no-global-tslint-disable
-// tslint:disable: no-implicit-dependencies
 import { JsonObject } from '@angular-devkit/core';
 import { execSync } from 'child_process';
 import * as fs from 'fs';

packages/angular/cli/commands/analytics-impl.ts

@@ -13,7 +13,7 @@ import {
 } from '../models/analytics';
 import { Command } from '../models/command';
 import { Arguments } from '../models/interface';
-import { ProjectSetting, Schema as AnalyticsCommandSchema, SettingOrProject } from './analytics';
+import { Schema as AnalyticsCommandSchema, ProjectSetting, SettingOrProject } from './analytics';
 
 export class AnalyticsCommand extends Command<AnalyticsCommandSchema> {
   public async run(options: AnalyticsCommandSchema & Arguments) {

packages/angular/cli/commands/doc-impl.ts

@@ -36,7 +36,7 @@ export class DocCommand extends Command<DocCommandSchema> {
       // we try to get the current Angular version of the project
       // and use it if we can find it
       try {
-        /* tslint:disable-next-line:no-implicit-dependencies */
+        /* eslint-disable-next-line import/no-extraneous-dependencies */
         const currentNgVersion = (await import('@angular/core')).VERSION.major;
         domain = `v${currentNgVersion}.angular.io`;
       } catch (e) {}

packages/angular/cli/commands/update-impl.ts

@@ -271,7 +271,7 @@ export class UpdateCommand extends Command<UpdateCommandSchema> {
     return true;
   }
 
-  // tslint:disable-next-line:no-big-function
+  // eslint-disable-next-line max-lines-per-function
   async run(options: UpdateCommandSchema & Arguments) {
     await ensureCompatibleNpm(this.context.root);
 
@@ -665,7 +665,7 @@ export class UpdateCommand extends Command<UpdateCommandSchema> {
     }
 
     // This is a temporary workaround to allow data to be passed back from the update schematic
-    // tslint:disable-next-line: no-any
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const migrations = (global as any).externalMigrations as {
       package: string;
       collection: string;

packages/angular/cli/lib/cli/index.ts

@@ -19,7 +19,7 @@ export { VERSION, Version } from '../../models/version';
 const debugEnv = process.env['NG_DEBUG'];
 const isDebug = debugEnv !== undefined && debugEnv !== '0' && debugEnv.toLowerCase() !== 'false';
 
-// tslint:disable: no-console
+/* eslint-disable no-console */
 export default async function (options: { testing?: boolean; cliArgs: string[] }) {
   // This node version check ensures that the requirements of the project instance of the CLI are met
   const version = process.versions.node.split('.').map((part) => Number(part));
@@ -111,7 +111,7 @@ export default async function (options: { testing?: boolean; cliArgs: string[] }
     }
 
     if (options.testing) {
-      // tslint:disable-next-line: no-debugger
+      // eslint-disable-next-line no-debugger
       debugger;
       throw err;
     }

packages/angular/cli/lib/init.ts

@@ -8,7 +8,6 @@
 
 import 'symbol-observable';
 // symbol polyfill must go first
-// tslint:disable-next-line:ordered-imports import-groups
 import * as fs from 'fs';
 import * as path from 'path';
 import { SemVer } from 'semver';
@@ -22,7 +21,7 @@ if (process.env['NG_CLI_PROFILING']) {
     stopProfiling: (name?: string) => unknown;
   };
   try {
-    profiler = require('v8-profiler-node8'); // tslint:disable-line:no-implicit-dependencies
+    profiler = require('v8-profiler-node8'); // eslint-disable-line import/no-extraneous-dependencies
   } catch (err) {
     throw new Error(
       `Could not require 'v8-profiler-node8'. You must install it separetely with ` +
@@ -90,7 +89,7 @@ if (process.env['NG_CLI_PROFILING']) {
         localVersion = require(path.join(path.dirname(projectLocalCli), '../../package.json'))
           .version;
       } catch (error) {
-        // tslint:disable-next-line no-console
+        // eslint-disable-next-line  no-console
         console.error('Version mismatch check skipped. Unable to retrieve local version: ' + error);
       }
     }
@@ -99,7 +98,7 @@ if (process.env['NG_CLI_PROFILING']) {
     try {
       isGlobalGreater = !!localVersion && globalVersion.compare(localVersion) > 0;
     } catch (error) {
-      // tslint:disable-next-line no-console
+      // eslint-disable-next-line  no-console
       console.error('Version mismatch check skipped. Unable to compare local version: ' + error);
     }
 
@@ -115,7 +114,7 @@ if (process.env['NG_CLI_PROFILING']) {
           `version (${localVersion}). The local Angular CLI version is used.\n\n` +
           'To disable this warning use "ng config -g cli.warnings.versionMismatch false".';
 
-        // tslint:disable-next-line no-console
+        // eslint-disable-next-line  no-console
         console.error(colors.yellow(warning));
       }
     }
@@ -144,7 +143,7 @@ if (process.env['NG_CLI_PROFILING']) {
     process.exit(exitCode);
   })
   .catch((err: Error) => {
-    // tslint:disable-next-line no-console
+    // eslint-disable-next-line  no-console
     console.error('Unknown error: ' + err.toString());
     process.exit(127);
   });

packages/angular/cli/models/analytics.ts

@@ -15,7 +15,7 @@ import { getWorkspace, getWorkspaceRaw } from '../utilities/config';
 import { isTTY } from '../utilities/tty';
 import { AnalyticsCollector } from './analytics-collector';
 
-// tslint:disable: no-console
+/* eslint-disable no-console */
 const analyticsDebug = debug('ng:analytics'); // Generate analytics, including settings and users.
 
 let _defaultAngularCliPropertyCache: string;

packages/angular/cli/models/architect-command.ts

@@ -304,7 +304,7 @@ export abstract class ArchitectCommand<
 
   private getProjectNamesByTarget(targetName: string): string[] {
     const allProjectsForTargetName: string[] = [];
-    // tslint:disable-next-line: no-non-null-assertion
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     for (const [name, project] of this.workspace!.projects) {
       if (project.targets.has(targetName)) {
         allProjectsForTargetName.push(name);
@@ -317,7 +317,7 @@ export abstract class ArchitectCommand<
     } else {
       // For single target commands, we try the default project first,
       // then the full list if it has a single project, then error out.
-      // tslint:disable-next-line: no-non-null-assertion
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       const maybeDefaultProject = this.workspace!.extensions['defaultProject'] as string;
       if (maybeDefaultProject && allProjectsForTargetName.includes(maybeDefaultProject)) {
         return [maybeDefaultProject];

packages/angular/cli/models/command.ts

@@ -126,6 +126,7 @@ export abstract class Command<T extends BaseCommandOptions = BaseCommandOptions>
             The ${this.description.name} command requires to be run outside of a project, but a
             project definition was found at "${this.workspace.filePath}".
           `);
+          // eslint-disable-next-line no-throw-literal
           throw 1;
         }
         break;
@@ -135,6 +136,7 @@ export abstract class Command<T extends BaseCommandOptions = BaseCommandOptions>
             The ${this.description.name} command requires to be run in an Angular project, but a
             project definition could not be found.
           `);
+          // eslint-disable-next-line no-throw-literal
           throw 1;
         }
         break;